From nobody Sun Jul 31 22:04:44 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4LwwKN3vpMz4XdBf; Sun, 31 Jul 2022 22:04:56 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LwwKN3KL9z3kSv; Sun, 31 Jul 2022 22:04:56 +0000 (UTC) (envelope-from dim@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1659305096; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3LokXwze/DL5MBy9y+e4OL5DXBlDLLiM0UbG2b8eck8=; b=kjy/cPlZMYsA+chjICFz8+PtYKJkiYt5PbpSQfndQeitljzXz6AXF5u3rLbRGxfhLVp7Oa 0CO41xqmVqbU+reLuoN2U/VJhvugqMAG4D2t04iQGwlDbX518q6NfV+Vh8Llz6+/z/NNr3 pyAVrENp1gZ9RUtLYA75jET6CbyxpHuRAaYVWJHYhlavw4mcJSonal50Gwaktc89j5DbaC nOQ8HvbE2CJuX4JFirmEak5qevkk7MCOtEQ2HufJaVJLjnSUoVSBICyOAQyaIbjnaIy3y2 t7G5WcRj1KkWZ97skkWisIYH4Ghamar49VfesyvvpPxxQMST9ZbMQ7M5u/pvNQ== Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "tensor.andric.com", Issuer "R3" (verified OK)) (Authenticated sender: dim) by smtp.freebsd.org (Postfix) with ESMTPSA id 4LwwKN1T9MzlSC; Sun, 31 Jul 2022 22:04:56 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtpclient.apple (longrow.home.andric.com [192.168.0.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 67E5140F36; Mon, 1 Aug 2022 00:04:54 +0200 (CEST) Content-Type: multipart/signed; boundary="Apple-Mail=_575F6B3F-3E09-4519-829B-E49BA58D56CC"; protocol="application/pgp-signature"; micalg=pgp-sha1 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: git: 4ba3797c9993 - main - graphics/png: fix build with clang 15 From: Dimitry Andric In-Reply-To: <5yjd-6sad-wny@FreeBSD.org> Date: Mon, 1 Aug 2022 00:04:44 +0200 Cc: "ports-committers@freebsd.org" , "dev-commits-ports-all@freebsd.org" , "dev-commits-ports-main@freebsd.org" Message-Id: <2BED1670-C064-412E-BB7A-8DB9560F96E9@FreeBSD.org> References: <202207311714.26VHEL73016804@gitrepo.freebsd.org> <5yjd-6sad-wny@FreeBSD.org> To: Jan Beich X-Mailer: Apple Mail (2.3696.120.41.1.1) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1659305096; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3LokXwze/DL5MBy9y+e4OL5DXBlDLLiM0UbG2b8eck8=; b=FGnVX5gfO+P0tfJgC4r6b8BY97MQm/zvGyJfayFD4JI2kTy2KPDVf7kSzSUeVdxC3tT+sr Ek4+pWAkfGrr74ViN9dCTYdKJ1OqG/9DuQqvUZE/nmJAxPpk+9oMVZoSVvRG1EQJS0UJXy s+kB+eVv9+imvxzsKGOlMo5oZyaSPaGh0BkRkYx8PcqxWVRIwLpF/XwdGiUepn9eYHLk8E +Wc1+/uPljDsjMKQrWLEbt3cglUAyh+WzeS/GnbAVBwmwvIA5KKxqtawCrJZEbiOpjeQC2 oE7Omn2/ybUGnoa0LuymfaE7DsLe6QHVnqvkPcqlHe/rYbvB7ddPGE5OJox/Tg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1659305096; a=rsa-sha256; cv=none; b=QsaKDqPskzglTim36Kqvm4vrMX1w4T1Au/0uhbwthdZ0SSkMJrjWQfgVi76koeVLwV6GKK 8ce1ELlpgu/myzLrYz9cE+9JyIezmehumXXCKmY8eEQjRz5oA4TseiU3aTTdp0t61Inm1m r6QModuE2DM3XBLrkxfc1C+0VCyd73bbwPidZg9nwJbN2stvv3YNf7kpvrsCLSq0ANj+u2 4f+rU8fmfYlAXkGZi14eXExMUsKQnh8iOH9RfwgFk4gfaJUQHA40GTEvokSr/+XYYs7nli QllmZ0LHNJlcEmGYWurx/f0NeuP8qjk+ILWG+rs33gT9NF/PprlZgug/AD6HTg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N --Apple-Mail=_575F6B3F-3E09-4519-829B-E49BA58D56CC Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 31 Jul 2022, at 20:39, Jan Beich wrote: >=20 > Dimitry Andric writes: >=20 >> The branch main has been updated by dim (src committer): >>=20 >> URL: = https://cgit.FreeBSD.org/ports/commit/?id=3D4ba3797c9993a25a082ed767d4f442= 34b1f7dc04 >>=20 >> commit 4ba3797c9993a25a082ed767d4f44234b1f7dc04 >> Author: Dimitry Andric >> AuthorDate: 2022-07-30 16:37:48 +0000 >> Commit: Dimitry Andric >> CommitDate: 2022-07-31 17:12:11 +0000 >>=20 >> graphics/png: fix build with clang 15 >>=20 >> Building png with clang 15 results in an error: >>=20 >> contrib/libtests/pngvalid.c:11662:4: error: call to undeclared = function 'feenableexcept'; ISO C99 and later do not support implicit = function declarations [-Wimplicit-function-declaration] >> feenableexcept(FE_DIVBYZERO | FE_INVALID | FE_OVERFLOW); >> ^ >>=20 >> This is because clang 15 introduced this new warning, and fenv.h = only >> declares feenableexcept() when compiling for C standards before = C11. >=20 > -Wimplicit-function-declaration is ancient, so Clang 15 made it fatal > for C99 or later. feenableexcept() is under __BSD_VISIBLE, so hidden = in > _POSIX_SOURCE mode as used by libpng. Linux cheats via _GNU_SOURCE > which is ignored on FreeBSD, so you get the above warning. >=20 > Where did C11 come from? >=20 > See also https://github.com/llvm/llvm-project/commit/7d644e1215b3 Indeed, this is a pretty big change, which has the potential to cause lots of breakage; I have added some notes and a request for feedback here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D265425#c13 -Dimitry --Apple-Mail=_575F6B3F-3E09-4519-829B-E49BA58D56CC Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCYub8fAAKCRCwXqMKLiCW o+1RAKDUkzg6HD5gK5hlazWmXX00xYe80ACg+f593AwFAMZQ8QDcGNkSeznSXOo= =juHQ -----END PGP SIGNATURE----- --Apple-Mail=_575F6B3F-3E09-4519-829B-E49BA58D56CC--