From nobody Tue Jul 19 18:45:56 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4LnSTb0Ph4z4Wm4W; Tue, 19 Jul 2022 18:46:11 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LnSTY6G7mz4BsF; Tue, 19 Jul 2022 18:46:09 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Received: by mail-ed1-x531.google.com with SMTP id y8so20867933eda.3; Tue, 19 Jul 2022 11:46:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1WTsXj0oL1wVbiaEK3t8rLLHMDJTYOPzU6k/TNiZKg0=; b=P5wxpYkt+TwGMZVNMEXeXYFmM9NfqD9J+nQX+mtp+pKt8I9fZtkR/uKt3NKQbG0io7 gw3EtKxUzN5a2CF1CpVctdJITW9YZ/BiZsTodY73NLf/6FfG+UYdxhQ4cshCv0ebQ5au SFrDHYdKgJM3D74rXj+Re1GFMpxs0w+QtQDr89tfPoifzC6ehwKagOu7dPPg2QbpHSwv mq196bLyQTR87b3G2OEvnZKsergOdD1TLyHecPxHE+CSBleJbTjCe+WUOAqVHKo/AINL 9T4WEZgqGg8fjUnZNiRiPDltsbw18mFi0wZpK+pBChB1b6yGc0J96BDPUGWJOxYGH0oC vbDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1WTsXj0oL1wVbiaEK3t8rLLHMDJTYOPzU6k/TNiZKg0=; b=Lc4lo1WL6Xkc701YdoZF1kFmW4brpAUxaXkY4/3ZfjmunCPmiPQHhHnEBqaaHeXYcZ 3p2g7YOFWcmwOZu5dQQ9YBeTwfXuRXKJLL5F8R2H14l/6JGU8sAJucg2s7mlrlgq2JAA 07WCxWmdHdAnjA7AHV8abCIYiUxu3jijD/FNy7xw5mbnNykhBr6FTzSX3COYTzK1+MVp D2MkxfWh8WFmf3vYJMeQcJ4Y0mDqbXRvGAqLEfxNd8V/EAcUu2/viWDbdTQ73Fohr6bS I67al/kLsHLTRlsSBgh8t7RGaOwprqUou8UNBPXj/5qefGJrbm+0DT0nGsZuYbY0u3HB ebDQ== X-Gm-Message-State: AJIora+bB/8Rodm73UcRkmxzxjOoS4eCIeJS4uyKvrFb/eGntk/oaarF UZIMdPZ6AGSqQTWvv8pPskZrk97JmdVdnOWMLo98384f X-Google-Smtp-Source: AGRyM1tni2Ssl5Pj008Z+RCm7OsDDqfeRU/RSt1PG7znjY8QbvVjjRmyridUBxSkhAJLxevsFjqoWXvdJndkVQ/Igq8= X-Received: by 2002:a05:6402:51ce:b0:43a:d409:b3e8 with SMTP id r14-20020a05640251ce00b0043ad409b3e8mr45305398edd.166.1658256368535; Tue, 19 Jul 2022 11:46:08 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202207191334.26JDYhAw010500@gitrepo.freebsd.org> <20220719174000.E7F92130@slippy.cwsent.com> In-Reply-To: From: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= Date: Tue, 19 Jul 2022 20:45:56 +0200 Message-ID: Subject: Re: git: c112b84fd807 - main - Revert "x11/fvwm3: Fix FvwmIconMan module segfault" To: Alexey Dokuchaev Cc: Cy Schubert , Cy Schubert , "ports-committers@FreeBSD.org" , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000cb0b9d05e42ce554" X-Rspamd-Queue-Id: 4LnSTY6G7mz4BsF X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20210112 header.b=P5wxpYkt; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of fernando.apesteguia@gmail.com designates 2a00:1450:4864:20::531 as permitted sender) smtp.mailfrom=fernando.apesteguia@gmail.com X-Spamd-Result: default: False [-3.82 / 15.00]; NEURAL_HAM_LONG(-0.99)[-0.992]; NEURAL_HAM_SHORT(-0.97)[-0.968]; NEURAL_HAM_MEDIUM(-0.86)[-0.855]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20210112]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::531:from]; TAGGED_FROM(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MLMMJ_DEST(0.00)[dev-commits-ports-all@freebsd.org,dev-commits-ports-main@freebsd.org]; RCPT_COUNT_FIVE(0.00)[6]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; MID_RHS_MATCH_FROMTLD(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_TLS_LAST(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-ThisMailContainsUnwantedMimeParts: N --000000000000cb0b9d05e42ce554 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable El mar., 19 jul. 2022 19:53, Alexey Dokuchaev escribi= =C3=B3: > On Tue, Jul 19, 2022 at 10:40:00AM -0700, Cy Schubert wrote: > > In message , Alexey Dokuchaev writes: > > > On Tue, Jul 19, 2022 at 01:34:43PM +0000, Cy Schubert wrote: > > > > commit c112b84fd8076a19f30f0705a3c139ef360b101e > > > > > > > > Revert "x11/fvwm3: Fix FvwmIconMan module segfault" > > > > > > > > The maintainer misunderstood the meaning of the maintainer-feedbac= k > > > > flag in bugzilla. > > > > > > This still does not explain if the fix was wrong or not. If it's > wrong, > > > it should've been explained in the commit log, if it's correct then h= ow > > > does reverting it help? > > > > The fix was not wrong. According to the maintainer, the patch fixed the > > bug. > > I presume that anyone who committed this did read the code and made a > clear judgment whether it was correct or not, prior to committing. > > > The maintainer didn't want it committed yet so more people could test i= t. > > I don't see how this can work: those who'd hit the segfault would confirm= , > those who'd not would not. How does it help? There's either a bug in th= e > code or not. At this point it looks like a fix was reverted only to be > recommitted again, resulting in nothing but a needless repochurn. :-/ > Or not. Maybe the fix didn't fix the issue completely or created a new one. That's why the maintainer wanted confirmation first. The committer mixed up two fields. That happens. We're human beings. I think our repo can keep up with two extra commits :-) > ./danfe > --000000000000cb0b9d05e42ce554 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


El mar., 19 jul. 2022 19:53, Alexey Dokuchaev <danfe@freebsd.org> escribi=C3=B3:
On Tue, Jul 19, 2022 at 10:40:00AM -= 0700, Cy Schubert wrote:
> In message <YtbrUdyCPAlM6dCZ@FreeBSD.org>, Alexey Dokuchaev writ= es:
> > On Tue, Jul 19, 2022 at 01:34:43PM +0000, Cy Schubert wrote:
> > > commit c112b84fd8076a19f30f0705a3c139ef360b101e
> > >
> > >=C2=A0 Revert "x11/fvwm3: Fix FvwmIconMan module segfaul= t"
> > >
> > >=C2=A0 The maintainer misunderstood the meaning of the mainta= iner-feedback
> > >=C2=A0 flag in bugzilla.
> >
> > This still does not explain if the fix was wrong or not.=C2=A0 If= it's wrong,
> > it should've been explained in the commit log, if it's co= rrect then how
> > does reverting it help?
>
> The fix was not wrong. According to the maintainer, the patch fixed th= e
> bug.

I presume that anyone who committed this did read the code and made a
clear judgment whether it was correct or not, prior to committing.

> The maintainer didn't want it committed yet so more people could t= est it.

I don't see how this can work: those who'd hit the segfault would c= onfirm,
those who'd not would not.=C2=A0 How does it help?=C2=A0 There's ei= ther a bug in the
code or not.=C2=A0 At this point it looks like a fix was reverted only to b= e
recommitted again, resulting in nothing but a needless repochurn. :-/

Or not= . Maybe the fix didn't fix the issue completely or created a new one. T= hat's why the maintainer wanted confirmation first.

The committer mixed up two fields. That hap= pens. We're human beings. I think our repo can keep up with two extra c= ommits :-)



./danfe
--000000000000cb0b9d05e42ce554--