From nobody Tue Jul 19 17:52:56 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4LnRJ84vjfz4WfWw; Tue, 19 Jul 2022 17:52:56 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LnRJ84MFGz433B; Tue, 19 Jul 2022 17:52:56 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1658253176; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VlqFjnoJsVAKAPxiXZi4VEIXK+yqC19YCueKHW7HCHE=; b=wvqaBlWtONWF1ii4gkLAKjLMcSRTwZlwc9ifmr/Scc8XohVdI/nsPTVdYQSejVqUazXvyw si49AC/0414qdJxbbp4q2SxmxctD8GSOxN9mRy8g0uPt5VJ/wJ41ORXw48Tx7pdTIkpi87 oATjpk7R8l3GuIZv2mYpkqI0ZCM2ENfU1aNdkDslF/i1Ha66SMDvcsPmk56GWtGSW6cUT7 aVDDfqeuMSUf9U49iHBuaY3upo93oWOH3BDxzfrbfdfapYwkWiWcFZ6/qBhLsgfOGZtr0m I60EH6pZeUPzN5Ip0yugS/i+vyZxA/t8ZS4dcm++tjDUyL2ngUs9ESlRYI8wUg== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 73DDF17C8D; Tue, 19 Jul 2022 17:52:56 +0000 (UTC) Date: Tue, 19 Jul 2022 17:52:56 +0000 From: Alexey Dokuchaev To: Cy Schubert Cc: Cy Schubert , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: c112b84fd807 - main - Revert "x11/fvwm3: Fix FvwmIconMan module segfault" Message-ID: References: <202207191334.26JDYhAw010500@gitrepo.freebsd.org> <20220719174000.E7F92130@slippy.cwsent.com> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220719174000.E7F92130@slippy.cwsent.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1658253176; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VlqFjnoJsVAKAPxiXZi4VEIXK+yqC19YCueKHW7HCHE=; b=vAfthv4IkB77YXxj1NSBX9k8P5w4kVHKimk6O6pUADktJt8Ais3cO32KlXF2CPl6nIlyP9 Kry0vLta4P51LaVH4zNrYGkR4ktpcW5X3A4yykVK3DYt7Xdxbvm4JXn4nMxX4tdCsS46Pi 8NZn67AZoD/nsHiPFSwY00mBMlGjH1AVnbh56BeN6LLUHotnmctUAfoVyb5n6RUL9mi+X1 Nqj8nOCIyxvRYVdiVdbNuRZYmV6PVlFIZ+FUe4vxbHHQ3NAdaa/WhVtJimQoyvJoC51KSf jRb++nElGKi8mjm7QBYCvpuBPGuEAyW299Tcx4w6mNHmg6Tw7jaMJ0BfE9W3BQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1658253176; a=rsa-sha256; cv=none; b=I8ebhLiBf7RioUR7BWKMMennO+PvwNlOMQ6Q/kPcB+9jDixXz6pQJYHiC0Bcm70X62B7SP oVOLkybaJtEvQZWdTB15yGnAOU06O7Lc2mdY1KPk77tYmI8cighg6oRv5D/4YumxjMIOCB DPuN3DLmaAy1WJQr6B5d0N/w17rwmoNdl729eFUbEC1aTVrBd9baHHlbQR8FjkPysPpwaU oPUmQ/CoFMWmaTzg9AY0A+Z5ymaKwCgosY2mLOAqZ46sHEcUanGJwAYlury4fYZ6YFEm3N L7l3ERrhv4IRYMkSpAf97Lq0HW3/n+9pYmlvK99op6TIBWXvRk+PFlIKON2zmw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Tue, Jul 19, 2022 at 10:40:00AM -0700, Cy Schubert wrote: > In message , Alexey Dokuchaev writes: > > On Tue, Jul 19, 2022 at 01:34:43PM +0000, Cy Schubert wrote: > > > commit c112b84fd8076a19f30f0705a3c139ef360b101e > > > > > > Revert "x11/fvwm3: Fix FvwmIconMan module segfault" > > > > > > The maintainer misunderstood the meaning of the maintainer-feedback > > > flag in bugzilla. > > > > This still does not explain if the fix was wrong or not. If it's wrong, > > it should've been explained in the commit log, if it's correct then how > > does reverting it help? > > The fix was not wrong. According to the maintainer, the patch fixed the > bug. I presume that anyone who committed this did read the code and made a clear judgment whether it was correct or not, prior to committing. > The maintainer didn't want it committed yet so more people could test it. I don't see how this can work: those who'd hit the segfault would confirm, those who'd not would not. How does it help? There's either a bug in the code or not. At this point it looks like a fix was reverted only to be recommitted again, resulting in nothing but a needless repochurn. :-/ ./danfe