From nobody Tue Jul 19 17:40:00 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4LnR1K3DGvz4WcPc; Tue, 19 Jul 2022 17:40:05 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta001.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LnR1J45Tlz41c0; Tue, 19 Jul 2022 17:40:04 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from shw-obgw-4002a.ext.cloudfilter.net ([10.228.9.250]) by cmsmtp with ESMTP id DmQJop4haS8WrDrCVoSqAh; Tue, 19 Jul 2022 17:40:03 +0000 Received: from spqr.komquats.com ([70.66.148.124]) by cmsmtp with ESMTPA id DrCToDugiC3uhDrCUoffOl; Tue, 19 Jul 2022 17:40:03 +0000 X-Authority-Analysis: v=2.4 cv=a6MjSGeF c=1 sm=1 tr=0 ts=62d6ec73 a=Cwc3rblV8FOMdVN/wOAqyQ==:117 a=Cwc3rblV8FOMdVN/wOAqyQ==:17 a=kj9zAlcOel0A:10 a=RgO8CyIxsXoA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=8a0DyyFBgk7SZ8Z41B0A:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 94E66353; Tue, 19 Jul 2022 10:40:01 -0700 (PDT) Received: by slippy.cwsent.com (Postfix, from userid 1000) id E7F92130; Tue, 19 Jul 2022 10:40:00 -0700 (PDT) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Alexey Dokuchaev cc: Cy Schubert , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: c112b84fd807 - main - Revert "x11/fvwm3: Fix FvwmIconMan module segfault" In-reply-to: References: <202207191334.26JDYhAw010500@gitrepo.freebsd.org> Comments: In-reply-to Alexey Dokuchaev message dated "Tue, 19 Jul 2022 17:35:13 -0000." List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 19 Jul 2022 10:40:00 -0700 Message-Id: <20220719174000.E7F92130@slippy.cwsent.com> X-CMAE-Envelope: MS4xfI0sJ4mlOtdzmBEBMcGbTu8a45Ze1TF7OOtVqacr8iQED2RYJvQOJh998kDmvxYGp8lDMWYQn7j8+4X/pVWUUHCFx4vVihmRsuVawSZwAiLq2OWgvTJ/ s0hC1S1nK1DEyN3H8XSpvbAgeW6UW7GNdJxcY6h0aPM7dK0eO0bggJgNOGf3ksCMWKSmAITqCmfkdVnYxiO9v6uVp25Lje+b3PTYIbMvUzLaNJ5u/qB0bZei 8CtVAqWpauRWU0FgajiMMSwaNatTO+BwJEdCWyR763/8rNxk9CIJk1VjS88tvAxRQFRVMunapDcdXsIIWwd7zNF1aSF6K5/4YXIwUuLBArrzQbsOot2fI5VC PNF6X3Ib X-Rspamd-Queue-Id: 4LnR1J45Tlz41c0 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of cy.schubert@cschubert.com has no SPF policy when checking 3.97.99.32) smtp.mailfrom=cy.schubert@cschubert.com X-Spamd-Result: default: False [-1.80 / 15.00]; AUTH_NA(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.998]; MV_CASE(0.50)[]; RCVD_IN_DNSWL_MED(-0.20)[3.97.99.32:from]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; R_SPF_NA(0.00)[no SPF record]; MLMMJ_DEST(0.00)[dev-commits-ports-all@freebsd.org,dev-commits-ports-main@freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; ARC_NA(0.00)[]; REPLYTO_EQ_FROM(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; RCVD_VIA_SMTP_AUTH(0.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_SOME(0.00)[]; DMARC_NA(0.00)[cschubert.com: no valid DMARC record]; RCVD_TLS_LAST(0.00)[] X-ThisMailContainsUnwantedMimeParts: N In message , Alexey Dokuchaev writes: > On Tue, Jul 19, 2022 at 01:34:43PM +0000, Cy Schubert wrote: > > commit c112b84fd8076a19f30f0705a3c139ef360b101e > > > > Revert "x11/fvwm3: Fix FvwmIconMan module segfault" > > > > The maintainer misunderstood the meaning of the maintainer-feedback > > flag in bugzilla. > > This still does not explain if the fix was wrong or not. If it's wrong, > it should've been explained in the commit log, if it's correct then how > does reverting it help? The fix was not wrong. According to the maintainer, the patch fixed the bug. The maintainer set the maintainer-feedback which was mistakenly taken to mean approved. The maintainer didn't want it committed yet so more people could test it. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org NTP: Web: https://nwtime.org e**(i*pi)+1=0