From nobody Thu Jul 14 05:35:07 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 70A191D4DE68; Thu, 14 Jul 2022 05:35:14 +0000 (UTC) (envelope-from SRS0=libK=XT=FreeBSD.org=mfechner@anny.lostinspace.de) Received: from anny.lostinspace.de (anny.lostinspace.de [195.30.95.33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Lk39F0ghQz3F4y; Thu, 14 Jul 2022 05:35:12 +0000 (UTC) (envelope-from SRS0=libK=XT=FreeBSD.org=mfechner@anny.lostinspace.de) Received: from server.idefix.lan (014-138-067-156.ip-addr.inexio.net [156.67.138.14]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: idefix@fechner.net) by anny.lostinspace.de (Postfix) with ESMTPSA id 30C7D92DD6; Thu, 14 Jul 2022 07:35:08 +0200 (CEST) Received: from [IPV6:2a02:6d40:36a2:f401:8c73:f180:524e:d255] (unknown [IPv6:2a02:6d40:36a2:f401:8c73:f180:524e:d255]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by server.idefix.lan (Postfix) with ESMTPSA id B89FA646142; Thu, 14 Jul 2022 07:35:07 +0200 (CEST) Message-ID: <88109e04-ca58-2d47-b1ef-2b1e5d22a124@FreeBSD.org> Date: Thu, 14 Jul 2022 07:35:07 +0200 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: git: 4671249405c0 - main - net/rubygem-omniauth-auth0: Fix build failure Content-Language: en-US To: Po-Chuan Hsieh Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org References: <202206301432.25UEWIi4077084@gitrepo.freebsd.org> From: Matthias Fechner In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: anny.lostinspace.de X-Rspamd-Queue-Id: 4Lk39F0ghQz3F4y X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of "SRS0=libK=XT=FreeBSD.org=mfechner@anny.lostinspace.de" designates 195.30.95.33 as permitted sender) smtp.mailfrom="SRS0=libK=XT=FreeBSD.org=mfechner@anny.lostinspace.de" X-Spamd-Result: default: False [-3.20 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FORGED_SENDER(0.30)[mfechner@FreeBSD.org,SRS0=libK=XT=FreeBSD.org=mfechner@anny.lostinspace.de]; R_SPF_ALLOW(-0.20)[+a]; RCVD_IN_DNSWL_MED(-0.20)[195.30.95.33:from]; MIME_GOOD(-0.10)[text/plain]; MLMMJ_DEST(0.00)[dev-commits-ports-all,dev-commits-ports-main]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:5539, ipnet:195.30.0.0/16, country:DE]; RCVD_COUNT_THREE(0.00)[3]; RCVD_VIA_SMTP_AUTH(0.00)[]; DMARC_NA(0.00)[freebsd.org]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[mfechner@FreeBSD.org,SRS0=libK=XT=FreeBSD.org=mfechner@anny.lostinspace.de]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N Am 12.07.2022 um 00:37 schrieb Po-Chuan Hsieh: > OK, the failure is about gitlab-ce but the commit message looks like > it causes the build failure of net/rubygem-omniauth-auth0. > > Anyway, you could try this patch [1]. Then we could drop > confusing net/rubygem-omniauth-oauth2-v1. > > [1] https://people.freebsd.org/~sunpoet/patch/gitlab-ce.txt I do not have the test setup here to test such a modification. For this you must setup authentication with auth0 and test that the login afterwards continue to work. But as the new versions will switch the master lib from version 1 to version 2, there is a risk it breaks the authentication. If you tested this and it does not break anything, you have my approval to commit it. Thanks. Gruß Matthias -- "Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the universe trying to produce bigger and better idiots. So far, the universe is winning." -- Rich Cook