From nobody Sat Jul 09 14:52:36 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 0E35417D1638; Sat, 9 Jul 2022 14:52:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LgCmh748Lz3Qf0; Sat, 9 Jul 2022 14:52:36 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1657378357; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Xy9lSVNmP4Ajsa9h+N+4jEjUAqLQgOkm3BJlj0XwE9g=; b=LJ3I4H+Oc3Ds6aiFmPslQaRMd0sSwWlXLLoulpKbiOpFzI04NpTu7OuPQ1z2KFrXQTg+HH RsRt3nt5VZLeZLu5bHPGxJvSDI5NV6SnazanjuXpo8888Bi6KcM/EF4LxJ7zz6IOPAm1Jw UEC2xniEELW7HDJieXC+cNFqDBYBzMJ1NTDpmgaeRHyfVa5jlUehy570hrnAsTA6pMY00Y 1Uf8i5TlhjRbKKHGKPtvDl+baSo/SZZAEO30kM/KsWdfHTDE7eDPA0cjn2OoFxOepfXmxN J4XWa7MlWMyV0AyxrrbuF/bxoBVUeCIoXQ+Ri7iLFnAROkTWAa6AS4qBSaP6cA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4LgCmh6BGkzpnD; Sat, 9 Jul 2022 14:52:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 269Eqar6095978; Sat, 9 Jul 2022 14:52:36 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 269EqamA095977; Sat, 9 Jul 2022 14:52:36 GMT (envelope-from git) Date: Sat, 9 Jul 2022 14:52:36 GMT Message-Id: <202207091452.269EqamA095977@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org From: Yuri Victorovich Subject: git: 6af95e9e48b0 - main - Mk/Scripts/qa.sh: Bogus 'xx doesn't have a SONAME' messages are printed by stage-qa for some shared libraries List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: yuri X-Git-Repository: ports X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6af95e9e48b065580cbac3f329e73c2b83e7f02d Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1657378357; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Xy9lSVNmP4Ajsa9h+N+4jEjUAqLQgOkm3BJlj0XwE9g=; b=lOMagGes4hIb3UJDYtqvD/eaSBOXNq362KjQT8OXqPakNJI3oY1Sve+5eCONQWHx8ygeAY OnhaRY7cPiZyMatuDEwzkUgaEsjZjvG9hzgaPzazLA12STfUT13BI6fpZN9hXGXu2TeJD5 szyGd1z4iK0rqGibg9GOs+U0T+viUBEvgWQ0KNRrQcxE7XKTEJmAnvAaaV2JNpfPlMGLhj Y+uGxTkUEwJQHnJ9gqdoLiCZ3fqGTKLpUnbjH7vqYwCnYSlBmg8T994+2P9XZISEM4iOUs MakKI1oq+Z+WTUXiCRmZmYMV4qrN4H+CW77p+h3TwZD6DIXwKQzPpJN0chsBEw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1657378357; a=rsa-sha256; cv=none; b=rTCsOmkAvnjCAulQvqmMrtB49mOQc0ToaF4oF3s5l8yS5w9qfMVHo1PbYGP5/q/48oYhCm Yn55jrnb9ZS0blS4hoejEaGbgyrhS0IG6fzSRD6mRGpOQytTiqpVBvgs9MPE134Bn57Hvu +jMZYgzrc87p6Ty2nDgI6Ky2/aprN1xZbVQzVG0+o7PlK145GwV6WXEGzBdFRqGwzi1pQU yyb0hJmafpzvoDBWhUifvVYoKETdvu7lOXAKSfR06adDtB+8jz842CzgUR2UOC42lnlnHn axBJHysNcnT+6qrBMRRU5vvHytWjKNsa4iJkBeaCJHzW3TVUoaxueC0VxGXMzQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by yuri: URL: https://cgit.FreeBSD.org/ports/commit/?id=6af95e9e48b065580cbac3f329e73c2b83e7f02d commit 6af95e9e48b065580cbac3f329e73c2b83e7f02d Author: Yuri Victorovich AuthorDate: 2022-07-09 14:50:47 +0000 Commit: Yuri Victorovich CommitDate: 2022-07-09 14:52:33 +0000 Mk/Scripts/qa.sh: Bogus 'xx doesn't have a SONAME' messages are printed by stage-qa for some shared libraries Reason: 'grep -q SONAME' ends before it drains the pipe, pipe fails when the remaining output is too long, and 'set -o pipefail' causes the whole command to fail when it is supposed to succeed. Remedy: Please apply the attached patch fix-SONAME.patch, or alternatively remove 'set -o pipefail' from qa.sh PR: 259992 Approved by: tcberner@ (as portmgr) --- Mk/Scripts/qa.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Mk/Scripts/qa.sh b/Mk/Scripts/qa.sh index 20d1e296dd5c..dd0f3440c299 100644 --- a/Mk/Scripts/qa.sh +++ b/Mk/Scripts/qa.sh @@ -673,7 +673,7 @@ proxydeps() { # When grep -q finds a match it will close the pipe immediately. # This may cause the test to fail when pipefail is turned on. set +o pipefail - if ! readelf -d "${dep_file}" | grep -q SONAME; then + if ! readelf -d "${dep_file}" | grep SONAME > /dev/null; then err "${file} is linked to ${dep_file} which does not have a SONAME. ${dep_file_pkg} needs to be fixed." fi set -o pipefail @@ -724,7 +724,7 @@ sonames() { [ -z "${f}" ] && continue # Ignore symlinks [ -f "${f}" -a ! -L "${f}" ] || continue - if ! readelf -d ${f} | grep -q SONAME; then + if ! readelf -d ${f} | grep SONAME > /dev/null; then warn "${f} doesn't have a SONAME." warn "pkg(8) will not register it as being provided by the port." warn "If another port depend on it, pkg will not be able to know where it comes from."