Re: git: b2eed2d66478 - main - wayland: add wayland virtual category

On Fri, Jul 01, 2022 at 01:51:32PM +0200, Jan Beich wrote:
> Baptiste Daroussin <bapt@FreeBSD.org> writes:
> 
> > The branch main has been updated by bapt:
> >
> > URL: https://cgit.FreeBSD.org/ports/commit/?id=b2eed2d66478efa63594275ffecd1be2d565c983
> >
> > commit b2eed2d66478efa63594275ffecd1be2d565c983
> > Author:     Baptiste Daroussin <bapt@FreeBSD.org>
> > AuthorDate: 2022-07-01 08:00:55 +0000
> > Commit:     Baptiste Daroussin <bapt@FreeBSD.org>
> > CommitDate: 2022-07-01 08:01:22 +0000
> >
> >     wayland: add wayland virtual category
> 
> But why? What does "wayland" here actually means? Otherwise, looks
> similar to "ipv6" virtual category in the past. Easier to list what
> doesn't yet or cannot support Wayland.
> 
> For example, Porter's Handbook defines "wayland" virtual category as
> "Ports to support the Wayland display server". This is ambiguous because
> "server" means Wayland compositors, and Xwayland can bridge X11 clients.

The porter's handbook definition has clearly be written by someone who probably
knows very little about Wayland.

Making a strong definition of what the wayland virtual category is, is probably
hard, the point of flagging a port in the wayland category is to make it easy to
search for an application supporting wayland via: pkg search -g "wayland/*" for
example.

> 
> Does multimedia/arcan fit "wayland" virtual category? arcan-wayland there
> is a Wayland server but also an A12 client, similar to Xwayland.
Then I would say yes
> 
> > ---
> >  x11-wm/cagebreak/Makefile             | 2 +-
> 
> But not x11-wm/cage?

Because I missed it in my quick and dirty flagging, it should be added yes
> 
> >  x11-wm/gamescope/Makefile             | 2 +-
> 
> gamescope does not support running Wayland-only apps like foot. Everything
> goes through Xwayland as it primarily targets fullscreen games under Xorg.

Than it is my mistake and wayland should be removed from there
> 
> $ gamescope -- foot -d none
> No CAP_SYS_NICE, falling back to regular-priority compute and threads.
> Performance will be affected.
> vulkan: selecting physical device 'Intel(R) HD Graphics 530 (SKL GT2)': queue family 0
> vulkan: physical device supports DRM format modifiers
> vulkan: supported DRM formats for sampling usage:
> vulkan:   0x34325241
> vulkan:   0x34325258
> vulkan:   0x3231564E
> wlserver: [backend/headless/backend.c:82] Creating headless backend
> wlserver: Running compositor on wayland display 'gamescope-0'
> wlserver: [backend/headless/backend.c:18] Starting headless backend
> wlserver: [xwayland/server.c:92] Starting Xwayland on :1
> wlserver: [types/wlr_surface.c:748] New wlr_surface 0x84ae82180 (res 0x84af0cb00)
> wlserver: [xwayland/server.c:250] Xserver is ready
> xwm: Failed to find PID for window 0x200001
> (EE) failed to read Wayland events: Broken pipe
> 
> >  x11-wm/kwinft/Makefile                | 2 +-
> 
> But not x11-wm/plasma5-kwin? KWinFT has X11 window manager + X11 compositor,
> full-featured enough to be compatible with Plasma.

Cause I missed it, I tried to avoid kde related things to let them decide as I
don't know where kde stands right now regarding wayland support
> 
> >  x11/alacritty/Makefile                | 2 +-
> 
> alacritty relies on winit for X11 + Wayland support. ports/ have more
> winit consumers
> 
right so it has both x11 and wayland categories right?

>   games/abstreet
>   games/dose-response
>   games/veloren

Best regards,
Bapt