From nobody Mon Jan 10 19:37:13 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 8E3D619516A5; Mon, 10 Jan 2022 19:37:31 +0000 (UTC) (envelope-from ultima1252@gmail.com) Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JXkcW3Qq7z3Lrh; Mon, 10 Jan 2022 19:37:31 +0000 (UTC) (envelope-from ultima1252@gmail.com) Received: by mail-qk1-f176.google.com with SMTP id 69so16153841qkd.6; Mon, 10 Jan 2022 11:37:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ol++HkAxWaz805dzMQsGqiA8D3w6VIjdxhz7oAdi5ww=; b=j2Ut+6vxOVAfuHZdp2wcXD64e5jO0yXUy9hINyJzN/pZhzcWAJc12Ko30QDCkF+tUg zCiGMXTcswQXtTPjihsmw/6AD9fVAq/ZjnRfFoe4ZxylQLHbSQImL9umfDFOIOqEZLA6 81IB1wfKiUMzbOpj+l7YyXZPkjbFpNA/OggaKzjN2X1fHn37vWXTpH26nuYfeb5MtGlI 3Fv7xyd7uI3wW3BABiUR9Q5k8a7B9lhweVL8FF+pYnFVBZ6dbnv1j9tXDFaqtMC4vbrV 92WqpyhJL0lHWoWrAJeXUa5nkY8FAfdYgSP/9X4MEQen9UqLEH1DhlksLp5izoHbdsDA P5nw== X-Gm-Message-State: AOAM531KCzEr8j0zO53PuTZ16pvGBvC/B8tMswQ+LY5nRjbMV8TJNCWv bTnnoxHtnoRE7PP4eBor748qU6Y6QNI= X-Google-Smtp-Source: ABdhPJxvFe5bn74jHtwvCSZYsjHbEYevg0KCfImXN8Sljn8Z2yMS2yAPCvxS6Q7/E0dF96y6dV6lxw== X-Received: by 2002:a05:620a:2589:: with SMTP id x9mr899774qko.325.1641843445109; Mon, 10 Jan 2022 11:37:25 -0800 (PST) Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com. [209.85.219.177]) by smtp.gmail.com with ESMTPSA id s13sm5148499qkp.107.2022.01.10.11.37.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Jan 2022 11:37:24 -0800 (PST) Received: by mail-yb1-f177.google.com with SMTP id h14so23551025ybe.12; Mon, 10 Jan 2022 11:37:24 -0800 (PST) X-Received: by 2002:a25:1388:: with SMTP id 130mr1428730ybt.321.1641843444562; Mon, 10 Jan 2022 11:37:24 -0800 (PST) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202201092309.209N9lFf039776@gitrepo.freebsd.org> In-Reply-To: From: Ultima Date: Mon, 10 Jan 2022 11:37:13 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 9f1b1be53d96 - main - *: Updated guacamole-[server|client] to 1.4.0 To: Rene Ladan Cc: Alexey Dokuchaev , ports-committers , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000004a43c305d53f7794" X-Rspamd-Queue-Id: 4JXkcW3Qq7z3Lrh X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N --0000000000004a43c305d53f7794 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Yeah someone complained about how I was formatting it a couple of months back. Will follow the "topic: action" format as would be more appropriate than asterisk. The 72 character limit is very limiting thought. Best regards, Richard Gallamore On Mon, Jan 10, 2022 at 8:19 AM Rene Ladan wrote: > On Mon, Jan 10, 2022 at 09:18:12AM +0000, Alexey Dokuchaev wrote: > > On Mon, Jan 10, 2022 at 08:18:59AM +0000, Rene Ladan wrote: > > > On Mon, Jan 10, 2022 at 02:15:34AM +0000, Alexey Dokuchaev wrote: > > > > On Sun, Jan 09, 2022 at 11:09:47PM +0000, Richard Gallamore wrote: > > > > > commit 9f1b1be53d965ca9eedef7a6547eb47973c8dae0 > > > > > > > > > > *: Updated guacamole-[server|client] to 1.4.0 > > > > > > > > There's no need to mutilate commit logs with `*:' anymore, JFYI. > > > > > > Talking about mutilating commit logs, how about using the contents > > > of COMMENT as the first line of the commit log of newly added ports > > > instead of a non-informative "new port has been added (+)" ? > > > > This is not mutilation: this won't work as COMMENT alone does not > > constitute *action* inflicted on the port, and amending the COMMENT > > with extra text to make it suitable for action won't fit the line > > limit, which is even less than common ~72 characters due to stupid > > four-characted padding git puts in front of the log. > > > Having a short description of what the port does is more useful > than forcing the git summary in an active tense. > > Ren=C3=A9 > --0000000000004a43c305d53f7794 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Yeah someone complained about how I was formatting it= a couple
of months back. Will follow the "topic: action&quo= t; format as would be
more appropriate than asterisk. The 72 char= acter limit is very limiting
thought.

Best regards,
Richard Gallamore

On Mon, Jan 10, 2022= at 8:19 AM Rene Ladan <rene@freebsd= .org> wrote:
On Mon, Jan 10, 2022 at 09:18:12AM +0000, Alexey Dokuchaev wrote:
> On Mon, Jan 10, 2022 at 08:18:59AM +0000, Rene Ladan wrote:
> > On Mon, Jan 10, 2022 at 02:15:34AM +0000, Alexey Dokuchaev wrote:=
> > > On Sun, Jan 09, 2022 at 11:09:47PM +0000, Richard Gallamore = wrote:
> > > > commit 9f1b1be53d965ca9eedef7a6547eb47973c8dae0
> > > >
> > > >=C2=A0 =C2=A0 =C2=A0*: Updated guacamole-[server|client]= to 1.4.0
> > >
> > > There's no need to mutilate commit logs with `*:' an= ymore, JFYI.
> >
> > Talking about mutilating commit logs, how about using the content= s
> > of COMMENT as the first line of the commit log of newly added por= ts
> > instead of a non-informative "new port has been added (+)&qu= ot; ?
>
> This is not mutilation: this won't work as COMMENT alone does not<= br> > constitute *action* inflicted on the port, and amending the COMMENT > with extra text to make it suitable for action won't fit the line<= br> > limit, which is even less than common ~72 characters due to stupid
> four-characted padding git puts in front of the log.
>
Having a short description of what the port does is more useful
than forcing the git summary in an active tense.

Ren=C3=A9
--0000000000004a43c305d53f7794--