From nobody Mon Jan 03 21:43:58 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 19AF8192754C; Mon, 3 Jan 2022 21:43:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JSTlf5SWnz4Rgs; Mon, 3 Jan 2022 21:43:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 9B4874ECF; Mon, 3 Jan 2022 21:43:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 203LhwkX093623; Mon, 3 Jan 2022 21:43:58 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 203LhwhJ093622; Mon, 3 Jan 2022 21:43:58 GMT (envelope-from git) Date: Mon, 3 Jan 2022 21:43:58 GMT Message-Id: <202201032143.203LhwhJ093622@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org From: Jan Beich Subject: git: deb3482f019c - main - games/openclonk: unbreak build after 9cb3316ecd20 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jbeich X-Git-Repository: ports X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: deb3482f019ce860b2998f0f55475900edd35b9e Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1641246238; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=N7IGMd5aeICopsCKajAiDpM9jTNgX78wH0nqTlQLgts=; b=bvZp6/vFE2dcUQVnA6fyEXQHh4FX63nvcFIwxr+z0/Jog6bT1c/7OYt/3seWBgA/6XwBvs 3I/WUflvqPmlrqOBEimg3GzqkQdrkMn6iRdzaBAtMs6UxtEXRrQHSr5QtGFNpDhUlRHZRU 6Hrq1fsgBRjF895hyt6QPYsXfCMpfntBsNncoziOHaKa9ME1EAJCv/tykCnZMRxz/qI6ho oETiFNA8K8s04XfWs3Fq1I/rI1JScEGBWIzogDezLQqm+nWl9JRep/JkeAezy123Ae20mQ U8jLu0QFJDJMKkw2M0VhykTCBjm+PnWBQoDTCC3Ynq3OKIZ7y4GiX7gSbSZlmw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1641246238; a=rsa-sha256; cv=none; b=Bao3yu5cWDtiQMfRWkM/eSjwTFYp87JEOirqm0QJCdgOW7M1yAN5aR0IfiTVn22sYv+WTh 8MztU8j00jYN9qD3Vp8YCOBDl2BeEVzzeqdusZGGaa63+g3uE3O4wZm65oHJBPAmek4geN G2+ERPbX4NfY+muo86I/BarHuJ/hCL3KIp1kSj666gKqxtAqRCC/kL7A3BQNwUVj541iaS rhLHwk//dWt26br4hwIAVZSHcbYEFakHNEQP0EtEss0KVA/VJl9gZILww4ONhiQD5wowJ5 +dG/mDU0cWNTWylBoTAbzmKKlzTg4T/Z/LCi6m/7YYym8Du2Gmrdmen3zVjOFg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by jbeich: URL: https://cgit.FreeBSD.org/ports/commit/?id=deb3482f019ce860b2998f0f55475900edd35b9e commit deb3482f019ce860b2998f0f55475900edd35b9e Author: Jan Beich AuthorDate: 2022-01-03 19:51:54 +0000 Commit: Jan Beich CommitDate: 2022-01-03 21:43:31 +0000 games/openclonk: unbreak build after 9cb3316ecd20 sdl2 has a namespace pollution where defines unprefixed HAVE_* macros often used by autotools, CMake, Meson. As sdl2 now depends on libinotify for joystick support HAVE_SYS_INOTIFY_H confuses openclonk which itself fails to detect . Due to inconsistent macro visibility and missing -linotify the build breaks. So, force-disable inotify code as it seems to be only used by editor (e.g., reload scenarios on changes) which since openclonk 8.0 requires Qt5. $ rg HAVE_SYS_INOTIFY_H /usr/local/include /usr/local/include/SDL2/SDL_config.h 223:#define HAVE_SYS_INOTIFY_H 1 $ make [...] -- Looking for C++ include sys/inotify.h -- Looking for C++ include sys/inotify.h - not found [...] src/platform/C4FileMonitor.cpp:29:2: error: use of undeclared identifier 'fd' fd = inotify_init1(IN_CLOEXEC); ^ src/platform/C4FileMonitor.cpp:30:6: error: use of undeclared identifier 'fd' if (fd == -1) fd = inotify_init(); ^ src/platform/C4FileMonitor.cpp:30:16: error: use of undeclared identifier 'fd' if (fd == -1) fd = inotify_init(); ^ src/platform/C4FileMonitor.cpp:31:6: error: use of undeclared identifier 'fd' if (fd == -1) LogF("inotify_init %s", strerror(errno)); ^ src/platform/C4FileMonitor.cpp:42:15: error: use of undeclared identifier 'fd' while (close(fd) == -1 && errno == EINTR) { } ^ src/platform/C4FileMonitor.cpp:57:29: error: use of undeclared identifier 'fd' int wd = inotify_add_watch(fd, file, IN_CREATE | IN_MODIFY | IN_MOVED_TO | IN_MOVE_SELF | IN_ONLYDIR); ^ src/platform/C4FileMonitor.cpp:60:2: error: use of undeclared identifier 'watch_descriptors' watch_descriptors[wd] = file; ^ src/platform/C4FileMonitor.cpp:65:59: error: use of undeclared identifier 'fd' if ((pfd->revents & pfd->events) != POLLIN || pfd->fd != fd) ^ src/platform/C4FileMonitor.cpp:66:69: error: use of undeclared identifier 'fd' LogF("C4FileMonitor::Execute unexpectedly called %d %d %hd %hd", fd, pfd->fd, pfd->events, pfd->revents); ^ src/platform/C4FileMonitor.cpp:69:11: error: use of undeclared identifier 'fd' if (read(fd, buf, sizeof(buf)) > 0) ^ src/platform/C4FileMonitor.cpp:71:23: error: use of undeclared identifier 'watch_descriptors' const char * file = watch_descriptors[event->wd]; ^ src/platform/C4FileMonitor.cpp:99:17: error: use of undeclared identifier 'fd' pollfd pfd = { fd, POLLIN, 0 }; ^ PR: 260885 Reported by: pkg-fallout Submitted by: Kevin Zheng (maintainer, different commit message) --- games/openclonk/files/patch-src_platform_C4FileMonitor.cpp | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/games/openclonk/files/patch-src_platform_C4FileMonitor.cpp b/games/openclonk/files/patch-src_platform_C4FileMonitor.cpp new file mode 100644 index 000000000000..e10a95e65c32 --- /dev/null +++ b/games/openclonk/files/patch-src_platform_C4FileMonitor.cpp @@ -0,0 +1,11 @@ +--- src/platform/C4FileMonitor.cpp.orig 2022-01-02 18:07:10 UTC ++++ src/platform/C4FileMonitor.cpp +@@ -21,6 +21,8 @@ + + #include "game/C4Application.h" + ++#undef HAVE_SYS_INOTIFY_H ++ + #ifdef HAVE_SYS_INOTIFY_H + #include +