Re: git: f9080cec69db - main - x11-wm/nscde: Replace expired ksh2020 dependency, Remove DEPRECATED

Hello Cy!

Thank you for help on this matter.
I've reopened https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=267501 with
sugestion you send me so it could be reworked.

Cheers,

Cy Schubert <Cy.Schubert@cschubert.com> escreveu no dia sexta, 30/12/2022
à(s) 08:56:

> In message <202212300841.2BU8f4sd059400@gitrepo.freebsd.org>, Nuno
> Teixeira
> wri
> tes:
> > The branch main has been updated by eduardo:
> >
> > URL:
> https://cgit.FreeBSD.org/ports/commit/?id=f9080cec69db09ce08dc72da892cc8
> > 30fdbfe231
> >
> > commit f9080cec69db09ce08dc72da892cc830fdbfe231
> > Author:     Chris Moerz <freebsd@ny-central.org>
> > AuthorDate: 2022-12-30 08:36:08 +0000
> > Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
> > CommitDate: 2022-12-30 08:40:33 +0000
> >
> >     x11-wm/nscde: Replace expired ksh2020 dependency, Remove DEPRECATED
> >
> >      - add LICENSE_FILE
> >      - fix avoiding use of != in assignments
> >
> >     PR:             267501
> >     MFH:            2022Q4
> > ---
> >  x11-wm/nscde/Makefile | 17 ++++++++---------
> >  1 file changed, 8 insertions(+), 9 deletions(-)
> >
> > diff --git a/x11-wm/nscde/Makefile b/x11-wm/nscde/Makefile
> > index 101e986ba64a..19db82204080 100644
> > --- a/x11-wm/nscde/Makefile
> > +++ b/x11-wm/nscde/Makefile
> > @@ -1,5 +1,6 @@
> >  PORTNAME=    nscde
> >  DISTVERSION= 2.2
> > +PORTREVISION=        1
> >  CATEGORIES=  x11-wm
> >  MASTER_SITES=
> https://github.com/NsCDE/NsCDE/releases/download/${DIST
> > VERSION}/
> >
> > @@ -8,9 +9,7 @@ COMMENT=      Modern CDE clone based on fvwm
> >  WWW=         https://github.com/NsCDE/NsCDE
> >
> >  LICENSE=     GPLv3
> > -
> > -DEPRECATED=  Depends on expired shells/ksh2020
> > -EXPIRATION_DATE=2022-12-31
> > +LICENSE_FILE=        ${WRKSRC}/COPYING
> >
> >  BUILD_DEPENDS=
>  ${PYTHON_PKGNAMEPREFIX}psutil>=5.7.0:sysutils/py-psutil
> > @${PY_FLAVOR} \
> >               ${PYTHON_PKGNAMEPREFIX}xdg>0:devel/py-xdg@${PY_FLAVOR} \
> > @@ -19,7 +18,7 @@ BUILD_DEPENDS=
> ${PYTHON_PKGNAMEPREFIX}psutil>=5.7.0:sy
> > sutils/py-psutil@${PY_FLAV
> >
>  font-bh-lucidatypewriter-100dpi>0:x11-fonts/font-bh-lucidatypew
> > riter-100dpi \
> >               fvwm2:x11-wm/fvwm2 \
> >               gsed:textproc/gsed \
> > -             ksh93:shells/ksh2020 \
> > +             ksh93:shells/ksh93 \
>
> shells/ksh is the continuation of the ksh2020 development. I think you'll
> want that. CDE, for instance tests for the existence of the ksh and ksh93
> binaries. If nscde does the same you may consider testing it with that
> port.
>
> However I'm pondering on flavorizing the three ksh's to allow them to
> coexit if you prefer to wait/discuss. They currently implement this using
> option helpers.
>
> shells/ksh93 is the no longer developed legacy AT&T AST ksh, with all of
> its warts and bugs should a script depend on them.
>
> shells/ksh and shells/ksh-devel are based on a GH project (ksh93/ksh) that
> was forked from ast/ksh when AT&T AST shut down that development and moved
> the development to the ksh2020 branch for safe keeping. The developers at
> the time forked ast/ksh to continue development under their own project.
> So, I think you probably want shells/ksh.
>
> Hope this helps.
>
>
> --
> Cheers,
> Cy Schubert <Cy.Schubert@cschubert.com>
> FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  https://FreeBSD.org
> NTP:           <cy@nwtime.org>    Web:  https://nwtime.org
>
>                         e^(i*pi)+1=0
>
>
>

-- 
Nuno Teixeira
FreeBSD Committer (ports)