From nobody Thu Dec 29 09:31:44 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NjNSs4HQSz2kmLD; Thu, 29 Dec 2022 09:31:57 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NjNSs3mRcz3K7t; Thu, 29 Dec 2022 09:31:57 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1672306317; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fvjeDFclAKxO65bnsRzCumCzpLaAEKyKnHslLVCmExE=; b=ORGitd3WdI/P5fXov7tKMIwoi9KkGTeiGANE+YQmCHb3S8WiliJ0SG3tHcsNHg8xXS2wIZ FTi9YWjfzZuZ2EivNxWag5Jn4eYPg39lUFakLqSaxLx/Q/pMA2/xkDdUdaBfS3lsNcbf+y ZmaY4yoGHpWR01nW9MELWxJaRlL3ztzz/MhuWamYjkrDxdhhonMeE4XnFaoAqBWl/ZIdNJ jVyBUBAdrQ1IDrsNs7ynfHtqaazMH1V8ylBdlfKBB9KfB8QZ1Nb842VHQNzq+LMY3x+M0l /VerODd9zcw2VkL83RxwILDOC0bdLDOTUOUHmNvp9UCvQvnffVuBvKpWF1CBoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1672306317; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fvjeDFclAKxO65bnsRzCumCzpLaAEKyKnHslLVCmExE=; b=YHyWsS3GRCb4HF2moSkJ516IjCWqnbt+ld+uWD65sBQzVritiarmo4grqIOhT1tuG3uDdx 4mcW8RrEL+w12ttUEwH8x5lPrZdewGt1pYGUj9Qpan/gtgFnMbl1Ix/Gk+mbvaFChDOuBq W4Dm1qss0XT/0MIFJGCTWge9XeVOByGrcTSoeuJO2WrPxQii3eWbXy6wF87K2zLBGaBHYc 7G5GmkVddnmoJNvvnWdtslUQztL5Dv62E8+rDFqRPUpYKnyZMWSeZV7ESWc+YoubYy/LpY U4z7zojiWzUa93wPZY7zg1kMDA2lWfxWff/VTU+lPS4Ievd9ZGBkJskxfpuBPA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1672306317; a=rsa-sha256; cv=none; b=t+k58TkiOz4zmayt98GilSmlpXnIakhfWXncMm+Czt9lpZBfy99/AJKfT6jq93OvYOXrE/ 82jiGVLFSvSXgKmRoNCdQ8TTFIxLOdZD5q/+e+SPLeTJAKTrVXYygKFdjMCEdKPRcEw7Fz 9tTDa6Z3gPzvK68yLA5a524Oumz76FhsaNeBjidX6Ba2QfiJjqfdupJiqbKIv3pH92vGnE 89qUjFNc5ndSvjSTixLszXrfkt75mvrHWdcO5ZPAwPV7tJu3iK+1ytFYeDnveDKAdQIYSv eJ3y3otu8IhQmghXqu3ZqIzRSt1yb96GGbXhlxFA9woWXUCMD/YcbBxJcnLYJg== Received: from mail-vs1-f43.google.com (mail-vs1-f43.google.com [209.85.217.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4NjNSs2l6jzmPs; Thu, 29 Dec 2022 09:31:57 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-vs1-f43.google.com with SMTP id i188so17923434vsi.8; Thu, 29 Dec 2022 01:31:57 -0800 (PST) X-Gm-Message-State: AFqh2kpOieNsAI3WHA8OAXHIrlhFTC0IOFH/UzPqFzMZKnWGPQX69ySZ j2Qa+3o9zCXRdhbc4m96jJqS7a6OkrYVFFmQiII= X-Google-Smtp-Source: AMrXdXssy7EIgDtMlrY+xmQo3RX5/DGcaD9bo1yLQibXDu/BZ0QTRolInunfVEl4MZGdrpum3pYJ8V76tz0+hJ09PPU= X-Received: by 2002:a05:6102:3d82:b0:3cb:88c6:293b with SMTP id h2-20020a0561023d8200b003cb88c6293bmr56394vsv.53.1672306316821; Thu, 29 Dec 2022 01:31:56 -0800 (PST) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202212260526.2BQ5QNkY028999@gitrepo.freebsd.org> <8082ef57-e8b6-adc0-5587-a580ce8dbb98@pfeifer.com> In-Reply-To: From: Nuno Teixeira Date: Thu, 29 Dec 2022 09:31:44 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 6622ce688cfd - main - multimedia/libopenshot: Update to 0.3.0 To: Piotr Kubaj Cc: Gerald Pfeifer , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000f84d5905f0f42726" X-ThisMailContainsUnwantedMimeParts: N --000000000000f84d5905f0f42726 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable maintainer is trying to "force" me to use: --- .if !exists(/usr/include/omp.h) USES+=3D gcc-c++11-lib .else USES+=3D compiler:c++14-lang .endif --- But I think we can avoid .else statement and use compiler:c++14-lang on "normal" USES since compiler will be overrided by the .if condition. Am I correct? Piotr Kubaj escreveu no dia quinta, 29/12/2022 =C3=A0(= s) 01:52: > Yes, that is ok. > > On 22-12-29 00:26:01, Nuno Teixeira wrote: > >(...) > > > >Got confused with that commit that have some months old. > > > >Current Makefile has: > >--- > >.if !exists(/usr/include/omp.h) > >USES+=3D compiler:c++14-lang > >USE_GCC=3D yes > >.else > >USES+=3D compiler:c++14-lang > >.endif > >--- > >And it should be corrected to: > >--- > >.if !exists(/usr/include/omp.h) > >USES+=3D compiler:gcc-c++11-lib > >.endif > >--- > > > >Is that ok? > >Sorry because I've got confused > > > >Nuno Teixeira escreveu no dia quarta, 28/12/2022 > =C3=A0(s) > >23:59: > > > >> You have fixed it in > >> > https://cgit.freebsd.org/ports/commit/?id=3Db02f812b43870dc615b6fc713121a= 2e745ed4293 > >> > >> I think I understand it better now > >> > >> Thanks > >> > >> Piotr Kubaj escreveu no dia quarta, 28/12/2022 > =C3=A0(s) > >> 13:43: > >> > >>> It would and I was against removal of USES=3Dcompiler:openmp but it w= as > >>> done anyway without any regard for architectures that don't have > libomp. > >>> > >>> On 22-12-28 14:15:44, Thierry Thomas wrote: > >>> >Le mer. 28 d=C3=A9c. 22 =C3=A0 13:47:02 +0100, Piotr Kubaj > >>> =C3=A9crivait : > >>> > > >>> >> If OpenMP is still necessary, then the best way would be: > >>> >> .if !exists(/usr/include/omp.h) > >>> >> USES+=3D compiler:gcc-c++11-lib > >>> >> .else > >>> >> USES+=3D compiler:c++14-lang > >>> >> .endif > >>> > > >>> >It would be great to re-add an argument "openmp" in Mk/Uses/ > compiler.mk > >>> >to put this kind of code at a central place. > >>> >-- > >>> >Th. Thomas. > >>> > >> > >> > >> -- > >> Nuno Teixeira > >> FreeBSD Committer (ports) > >> > > > > > >-- > >Nuno Teixeira > >FreeBSD Committer (ports) > --=20 Nuno Teixeira FreeBSD Committer (ports) --000000000000f84d5905f0f42726 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
maintainer is trying to "force" me to use:<= /div>
---
.if !exists(/usr/include/omp.h)
USES+=3D gcc-c++11-lib<= br>.else
USES+=3D compiler:c++14-lang
.endif
---
<= br>
But I think we can avoid .else statement and use compiler:c++= 14-lang on "normal" USES since compiler will be overrided by the = .if condition.
Am I correct?

Piotr Kubaj <pkubaj@anongoth.pl> escreveu no dia quint= a, 29/12/2022 =C3=A0(s) 01:52:
Yes, that is ok.

On 22-12-29 00:26:01, Nuno Teixeira wrote:
>(...)
>
>Got confused with that commit that have some months old.
>
>Current Makefile has:
>---
>.if !exists(/usr/include/omp.h)
>USES+=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 compiler:c++14-lang
>USE_GCC=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 yes
>.else
>USES+=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 compiler:c++14-lang
>.endif
>---
>And it should be corrected to:
>---
>.if !exists(/usr/include/omp.h)
>USES+=3D=C2=A0 compiler:gcc-c++11-lib
>.endif
>---
>
>Is that ok?
>Sorry because I've got confused
>
>Nuno Teixeira <eduardo@freebsd.org> escreveu no dia quarta, 28/12/2022 =C3=A0(s= )
>23:59:
>
>> You have fixed it in
>> https:/= /cgit.freebsd.org/ports/commit/?id=3Db02f812b43870dc615b6fc713121a2e745ed42= 93
>>
>> I think I understand it better now
>>
>> Thanks
>>
>> Piotr Kubaj <pkubaj@anongoth.pl> escreveu no dia quarta, 28/12/2022 =C3=A0(= s)
>> 13:43:
>>
>>> It would and I was against removal of USES=3Dcompiler:openmp b= ut it was
>>> done anyway without any regard for architectures that don'= t have libomp.
>>>
>>> On 22-12-28 14:15:44, Thierry Thomas wrote:
>>> >Le mer. 28 d=C3=A9c. 22 =C3=A0 13:47:02 +0100, Piotr Kubaj= <pkubaj@anongot= h.pl>
>>> =C3=A9crivait :
>>> >
>>> >> If OpenMP is still necessary, then the best way would= be:
>>> >> .if !exists(/usr/include/omp.h)
>>> >> USES+=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0compiler:gcc-c++11= -lib
>>> >> .else
>>> >> USES+=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0compiler:c++14-lan= g
>>> >> .endif
>>> >
>>> >It would be great to re-add an argument "openmp"= in Mk/Uses/compiler.mk
>>> >to put this kind of code at a central place.
>>> >--
>>> >Th. Thomas.
>>>
>>
>>
>> --
>> Nuno Teixeira
>> FreeBSD Committer (ports)
>>
>
>
>--
>Nuno Teixeira
>FreeBSD Committer (ports)


--
Nun= o Teixeira
FreeBSD Committer (ports)
--000000000000f84d5905f0f42726--