From nobody Thu Dec 29 00:26:01 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Nj8MB1Kmvz2kdmm; Thu, 29 Dec 2022 00:26:14 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Nj8M94jhZz3n34; Thu, 29 Dec 2022 00:26:13 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1672273573; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Zjiwbl13z9AnQ9xD6+kgKsIPmqJLmEAMFP0cVylhX10=; b=p7Byv9n25A5z23Jnz6x+WzxE8hS3CDrrxRuS+j6Ytub5dDFk9e6PATovUvIPSQV5gmpCcE 3zUvRpGpPwdYWt6kie/majqwGPAh4edsw7uQkdTMXEJz5+QSRirMGbBAAEHcYHvmkVT3Zo +md0wvLdXsksQ0y1JxwHxNlX9dT61o7OnDvXaNDdJlhcDvqECLmFjqFExEznRhuDbges8o O0yBvIRFpCobmmBsNHEShbxbVHo+hAntWnv5f+RgHaDpd7IHbnRegUJxfkOzOCzguhJMsU eXI5QT0w7Q2KJQKMSovcwOeqg1jWDt9kmAnhvDTi8RMGnVINXh+x0pJynY/fXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1672273573; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Zjiwbl13z9AnQ9xD6+kgKsIPmqJLmEAMFP0cVylhX10=; b=hA+uUhA0JU/8+jrb6RicZyx3Pv70/Dlp1bPoQX5ySdzBSc6OO6iUgCCPk7LpHFK7b7VXAW TpwEcHofyDVWXXzeJKlgWGE5eFpDcMfuViH5vRXmxEYhnStBRFx4J1Unvb7eGHhV3XXeqv xBftPe6tTADXLpKpz6RXMYHP51fcNmLBYoQCz3HfiLymySBoRicyb5PkDAu80Uq1cuowTh uyZEjS+lbKrBzAgvXD1Fd4bNmnXrm1Oq68LIKI0jPijyyl/wDzUWToi9OeDsT71MVuLizG uSFJig5iCTtBe7tOL43JQDrhk9axX4U+x2ea1OefcoX2j/gyhbl0jzl9ysVd3g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1672273573; a=rsa-sha256; cv=none; b=h31j+/wXTl4iNJxBR6lvahXWkTFVWGefXJrUlAXAjhzrCFwmVQOkHxCQb+UouY/5Bw40mc tr8XBEO9ZqenmC7gKVRNW48DvhBOkFGNRv968xhw9JRcOZjRot6aXNMr0b7IXkDonhWlfL fNsEa/7NL58uVB/w86QUwjQiVVoJ+QpEGy5D3C5nmKMeP+cctoBHPOrLVMn/NJyGdhpfnX Pcd/FUZBolVxafoShIMWTO54YcLCRM1ZXYk9xUi5WUGauly4JKSv2Iz4euFS/LfIpRUNwF GFKIgK9ikiNHZGnrZ0ooK7KVcIUxB4qeslx1xHf8p5zKf3CTfYoVscOx9F8h0A== Received: from mail-vs1-f44.google.com (mail-vs1-f44.google.com [209.85.217.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Nj8M93d08zccT; Thu, 29 Dec 2022 00:26:13 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-vs1-f44.google.com with SMTP id m2so17027381vsv.9; Wed, 28 Dec 2022 16:26:13 -0800 (PST) X-Gm-Message-State: AFqh2ko7N2k4J+zPIee0z62cVHsYY5pVCC8uVW17vAeUvEwpmses0EFa xZZOwToTBPxzXz06HCtxxW1Te99iFq9lRTnJdAY= X-Google-Smtp-Source: AMrXdXtH607y7LUg6uTrDWRTctGh5E0lhjgm5ElF7SSsR3b6F2JFCFsO1QFfcuY9OTNJuBOXperZ1RUzTzDsDJp95Wc= X-Received: by 2002:a67:ec8a:0:b0:3b7:c371:fa0b with SMTP id h10-20020a67ec8a000000b003b7c371fa0bmr3111089vsp.58.1672273573082; Wed, 28 Dec 2022 16:26:13 -0800 (PST) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202212260526.2BQ5QNkY028999@gitrepo.freebsd.org> <8082ef57-e8b6-adc0-5587-a580ce8dbb98@pfeifer.com> In-Reply-To: From: Nuno Teixeira Date: Thu, 29 Dec 2022 00:26:01 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 6622ce688cfd - main - multimedia/libopenshot: Update to 0.3.0 To: Piotr Kubaj Cc: Gerald Pfeifer , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000004a7b3b05f0ec8898" X-ThisMailContainsUnwantedMimeParts: N --0000000000004a7b3b05f0ec8898 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable (...) Got confused with that commit that have some months old. Current Makefile has: --- .if !exists(/usr/include/omp.h) USES+=3D compiler:c++14-lang USE_GCC=3D yes .else USES+=3D compiler:c++14-lang .endif --- And it should be corrected to: --- .if !exists(/usr/include/omp.h) USES+=3D compiler:gcc-c++11-lib .endif --- Is that ok? Sorry because I've got confused Nuno Teixeira escreveu no dia quarta, 28/12/2022 =C3= =A0(s) 23:59: > You have fixed it in > https://cgit.freebsd.org/ports/commit/?id=3Db02f812b43870dc615b6fc713121a= 2e745ed4293 > > I think I understand it better now > > Thanks > > Piotr Kubaj escreveu no dia quarta, 28/12/2022 =C3= =A0(s) > 13:43: > >> It would and I was against removal of USES=3Dcompiler:openmp but it was >> done anyway without any regard for architectures that don't have libomp. >> >> On 22-12-28 14:15:44, Thierry Thomas wrote: >> >Le mer. 28 d=C3=A9c. 22 =C3=A0 13:47:02 +0100, Piotr Kubaj >> =C3=A9crivait : >> > >> >> If OpenMP is still necessary, then the best way would be: >> >> .if !exists(/usr/include/omp.h) >> >> USES+=3D compiler:gcc-c++11-lib >> >> .else >> >> USES+=3D compiler:c++14-lang >> >> .endif >> > >> >It would be great to re-add an argument "openmp" in Mk/Uses/compiler.mk >> >to put this kind of code at a central place. >> >-- >> >Th. Thomas. >> > > > -- > Nuno Teixeira > FreeBSD Committer (ports) > --=20 Nuno Teixeira FreeBSD Committer (ports) --0000000000004a7b3b05f0ec8898 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
(...)

Got confused with that= commit that have some months old.

Current Makefil= e has:
---
.if !exists(/usr/include/omp.h)
USES+=3D = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0compiler:c++14-lang
USE_GCC=3D =C2=A0 = =C2=A0 =C2=A0 =C2=A0yes
.else
USES+=3D =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0compiler:c++14-lang
.endif
---
And it should b= e corrected to:
---
.if !exists(/usr/include/omp.h)
USES+=3D=C2=A0 compiler:gcc-c++11-lib
=
.endif
---

=
Is that ok?
Sorry because I've got confused

Nuno Teixeira = <eduardo@freebsd.org> escr= eveu no dia quarta, 28/12/2022 =C3=A0(s) 23:59:

=
I think I understand it better now

Thanks
=

Piotr Kubaj <pkubaj@anongoth.pl> escreveu no dia quarta, 28/12/2022 =C3=A0(s) = 13:43:
It would = and I was against removal of USES=3Dcompiler:openmp but it was
done anyway without any regard for architectures that don't have libomp= .

On 22-12-28 14:15:44, Thierry Thomas wrote:
>Le mer. 28 d=C3=A9c. 22 =C3=A0 13:47:02 +0100, Piotr Kubaj <pkubaj@anongoth.pl>= =C3=A9crivait=C2=A0:
>
>> If OpenMP is still necessary, then the best way would be:
>> .if !exists(/usr/include/omp.h)
>> USES+=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0compiler:gcc-c++11-lib
>> .else
>> USES+=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0compiler:c++14-lang
>> .endif
>
>It would be great to re-add an argument "openmp" in Mk/Uses/<= a href=3D"http://compiler.mk" rel=3D"noreferrer" target=3D"_blank">compiler= .mk
>to put this kind of code at a central place.
>--
>Th. Thomas.


--
Nuno Teixeira
FreeBSD Co= mmitter (ports)


--
Nun= o Teixeira
FreeBSD Committer (ports)
--0000000000004a7b3b05f0ec8898--