From nobody Wed Dec 28 12:47:02 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Nhrrj2lFpz1J6Fk; Wed, 28 Dec 2022 12:47:17 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Received: from mail.anongoth.pl (mail.anongoth.pl [46.248.190.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X448 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "anongoth.pl", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Nhrrh5JRmz3Btc; Wed, 28 Dec 2022 12:47:16 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Authentication-Results: mx1.freebsd.org; none Received: from anongoth.pl (unknown [192.168.1.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: pkubaj@anongoth.pl) by mail.anongoth.pl (Postfix) with ESMTPSA id A10D61CA67D; Wed, 28 Dec 2022 13:47:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=anongoth.pl; s=ANONGOTH; t=1672231625; bh=KgkYjIMlFRyeMmobaQEq6gaE9JjQ9ahFrSV+d9uG9KA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=YDxG5I/gFNQxaI+kq6yh8t74Ci5nHe0fGGfUwksn7HkxTzG/FxMMZC0C2/PpwyaJl 1lf/8CHeFovGvzcfeHzNlbPwvjDMR2jTfQVnSTB2PsFUqHPnx3joZ7zKth3uL4gO63 0LQK9j5J5IQwlK/uT/UApMNJbihhP5fPGkwpAIOKc1maWRtOhE4YWURV09MfdF7Gw1 maOgxkgB/rNG0oASIPBxBg/NGTpBHiKmI/CoNyvabN6BGhFxpIzl2UcFkVGnFSOFoh xwqvrgdCCDp01dbYOMKKgo7q+kiu6O4DkdaRHZDxt1dohL6kEPkft3a5D9J41KUH6s +v61CtINcojDQ== Date: Wed, 28 Dec 2022 13:47:02 +0100 From: Piotr Kubaj To: Nuno Teixeira Cc: Gerald Pfeifer , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 6622ce688cfd - main - multimedia/libopenshot: Update to 0.3.0 Message-ID: References: <202212260526.2BQ5QNkY028999@gitrepo.freebsd.org> <8082ef57-e8b6-adc0-5587-a580ce8dbb98@pfeifer.com> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7P6EwM0gKktXev0u" Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4Nhrrh5JRmz3Btc X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:47544, ipnet:46.248.160.0/19, country:PL] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --7P6EwM0gKktXev0u Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable No. If OpenMP is still necessary, then the best way would be: =2Eif !exists(/usr/include/omp.h) USES+=3D compiler:gcc-c++11-lib =2Eelse USES+=3D compiler:c++14-lang =2Eendif On 22-12-28 11:29:55, Nuno Teixeira wrote: >This was discussed in PR but not included in update: >--- >Old version have different values for USES: "compiler:gcc-c++11-lib" and >"compiler:c++11-lang". >New version have same value "compiler:c++14-lang" for both. >So we can remove else in this if: >=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >.if !exists(/usr/include/omp.h) >USES+=3D compiler:c++14-lang >USE_GCC=3D yes >.else >USES+=3D compiler:c++14-lang >.endif >----------------------------------- >USES+=3D compiler:c++14-lang >.if !exists(/usr/include/omp.h) >USE_GCC=3D yes >.endif >=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >--- > >Is: >USES+=3D compiler:c++14-lang >.if !exists(/usr/include/omp.h) >USE_GCC=3D yes >.endif > >the best and correct way to do it? > >Thanks > > > > >Piotr Kubaj escreveu no dia segunda, 26/12/2022 =C3= =A0(s) >22:30: > >> On 22-12-26 23:22:49, Gerald Pfeifer wrote: >> >On Mon, 26 Dec 2022, Nuno Teixeira wrote: >> >> .if !exists(/usr/include/omp.h) >> >> -USES+=3D compiler:gcc-c++11-lib >> >> +USES+=3D compiler:c++14-lang >> >> +USE_GCC=3D yes >> >> .else >> >> -USES+=3D compiler:c++11-lang >> >> +USES+=3D compiler:c++14-lang >> >> .endif >> > >> >This sets >> > USES+=3D compiler:c++14-lang >> >in both the if-arm and the else-arm. >> > >> >Why not set this unconditionally then? >> > >> >And combining compiler:c++14-lang and USE_GCC=3Dyes is odd; I don't thi= nk >> >that really works. >> > >> >Are you sure this entire block is still necessary at all? Where would it >> >make a difference? >> > >> >Gerald >> >> Gerald is right. >> >> Moreover, USE_GCC=3Dyes forces linking on libstdc++ which might cause >> runtime issues. >> > > >--=20 >Nuno Teixeira >FreeBSD Committer (ports) --7P6EwM0gKktXev0u Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJkBAABCgBOFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmOsOsYwFIAAAAAAFQAS cGthLWFkZHJlc3NAZ251cGcub3JncGt1YmFqQGFub25nb3RoLnBsAAoJEHpZm4Ug g5ydLC0P/iJlnJWq1ThClbrmRW/cesAg/yNpx+G/VS4oN6XKjzV7aEBX+n5pFJ77 4ZCImEneYnvhqukOQBayIqBTU2EXvG+1T9IHui/MjLacNPYeuqasftiOpSv9+bYg ItDlO8YrwA7eszwej0++ZYCoE7PLRtHXJqOdbsCq5YdNlFuhlBHfbGoBi2zbUHao pz4oC/H/BOky3KanpkPEpp3aK/+83MgbWd20Kk9cze54or8OuWGjflZ/rMjd7byh gH3WvhXRTaHFwFyRqJFdVaUtSSR/74GLOw8OlAcNU+o2i7gih15OHeRMH/0mMfvO F+QTJTBANj/Kqyuc/F8aPqsMjUdJyNatAU8NbvlGajw7sqMkHydkgbbMIJU8c/Y+ ryv5Vnkvk++kwdtgXSNqj9gfu7QotSfZfvqbGkQjFvUF4npS11qGkHFrQcJ9ryRG 2U/DUEGRjHaDwFpYjGRvUrQRzeXmBhf8GU6V4GM3ALs2EeLdmyqt/n+TWk4UMRRq Rg0tKMkUD57kxe1iYMxaDz5pk1OmeJClMQAmD7QBQudLUHnaBYzPc8Khymr/hjd5 QlG+V/T4WeLQ4hSP0DDB1JSj3niZUpibr3LyH/GDT49RmV1SjoKAsdYXosZKeK+H 9gqZl0+rspAsY6P8F0wDtnrF7kr+rh+zVchohfC/1E50umMEl5MY =hjrb -----END PGP SIGNATURE----- --7P6EwM0gKktXev0u--