Re: git: 6622ce688cfd - main - multimedia/libopenshot: Update to 0.3.0
Date: Mon, 26 Dec 2022 22:29:49 UTC
On 22-12-26 23:22:49, Gerald Pfeifer wrote: >On Mon, 26 Dec 2022, Nuno Teixeira wrote: >> .if !exists(/usr/include/omp.h) >> -USES+= compiler:gcc-c++11-lib >> +USES+= compiler:c++14-lang >> +USE_GCC= yes >> .else >> -USES+= compiler:c++11-lang >> +USES+= compiler:c++14-lang >> .endif > >This sets > USES+= compiler:c++14-lang >in both the if-arm and the else-arm. > >Why not set this unconditionally then? > >And combining compiler:c++14-lang and USE_GCC=yes is odd; I don't think >that really works. > >Are you sure this entire block is still necessary at all? Where would it >make a difference? > >Gerald Gerald is right. Moreover, USE_GCC=yes forces linking on libstdc++ which might cause runtime issues.