From nobody Sun Dec 25 22:29:54 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NgFwP08dNz1J3Z1; Sun, 25 Dec 2022 22:29:57 +0000 (UTC) (envelope-from tijl@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NgFwN6L2Bz4Chs; Sun, 25 Dec 2022 22:29:56 +0000 (UTC) (envelope-from tijl@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1672007396; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8RhWH9tbiaGW/+qATkkjReqNzU8iwkwD4cC9yGzYrsk=; b=iHAbQaiWyia/wmJ6yiDsPYTioSz2BOh3hFif/7PGTyiDQ6BE7hwfSS0SEe5HTdOCNnmSoX F+ZeYiGUYBdO/qVIUxPtmWOiNiffBxOzveuf5JpOj4aT5qJFAxgpZKV+lyQ34yC0zlzo5K xQykCte6Whq6Tvq2N47yjrY1FX8ww9nM+/kiab91Uv0gdhRwZavjeQbRFu3458RxMD5Pcj zC+X133//rKqVS3ch0ERS7+KxjO5+5HfEIOUvmCDw7miLwCE1YyElhP2q+usnA13SGBur9 CxC8aZGzZeNCelaXpI0QJBkr1lMaCHW6izoEsKit0ZqRvaT7yfSl6bACRgs4LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1672007396; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8RhWH9tbiaGW/+qATkkjReqNzU8iwkwD4cC9yGzYrsk=; b=gIDCWFhptGjsx2JjB7pKI8Pn/GISog9AgHEEsjO3fqepPQpB2MFnRQ4XRnX2+KNIKu/IWx 2F0EM1oFh8bjsJ0P0TYnT8cS9MsXH57fEKukiFnZq6p4QxWLKPvai4JCRQnVkV9ft0G+Ic mcZ6PUKOwRadnfQHqY3c8Hl/UbhvZv9gPjeAJCUddXxXjsr7F0c91UjGNEh6l3XWA/Dnku qBUlN4UdYt7mw/X0GVXi8kHJxWJGi+bIFVDJit47xMVEcB9YEAxSP6GQ/CGF0XWPVUePSC g2eE4aBlP0e6swWxGJ8fSsuzjJ5EhfX5EpOcw2eSMA02lqeIHk6d+HSOJhpXNA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1672007396; a=rsa-sha256; cv=none; b=junsqSYryLZ2uruHLkxMU+AO9iokG1KeWpyZoKkRD4ZPd1yq2BZ5er9xZ1ZA53cdNmL4Q4 VrLiDVSdA2433P5BRYSxSCBs/1Ybc4JKSzJf9NDIB9T6+RxAk9ov5OPO5ajk8cwXKtqBWg I8GXalWzJ86nfXG3WLIVgFSVy2KEyxtJpAFsodYR8r0KhDZk3JBgrfzDBKQ8mXVs1wJdEk MXlOu7xsD4+9yCuDFEdfC2RKYePDys8lvJDf7gtVoBgIkKP/K9SvniQab+CtWJFkQfaLmZ V9OBwu93+4slnnj0s32Q/P7cyRR0124fLcyeytoIvkLw5Zqa3m+mLJXq3WazGA== Received: from hal.tijl.coosemans.org (unknown [IPv6:2a02:a03f:894b:4700:6c03:7735:be97:4bb8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: tijl) by smtp.freebsd.org (Postfix) with ESMTPSA id 4NgFwM708JzVTp; Sun, 25 Dec 2022 22:29:55 +0000 (UTC) (envelope-from tijl@FreeBSD.org) Date: Sun, 25 Dec 2022 23:29:54 +0100 From: =?UTF-8?B?VMSzbA==?= Coosemans To: Dimitry Andric Cc: Dima Panov , "ports-committers@freebsd.org" , "dev-commits-ports-all@freebsd.org" , "dev-commits-ports-main@freebsd.org" Subject: Re: git: 145ca5487348 - main - audio/openal-soft: fix build with lld 15 on i386 Message-ID: <20221225232954.59833210@hal.tijl.coosemans.org> In-Reply-To: <67C4B58F-2E11-4092-8757-20AC2BF28383@FreeBSD.org> References: <202212251754.2BPHsgY6042846@gitrepo.freebsd.org> <2cf7882a-a250-2c08-4434-80c836a504f8@FreeBSD.org> <67C4B58F-2E11-4092-8757-20AC2BF28383@FreeBSD.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N On Sun, 25 Dec 2022 23:19:10 +0100 Dimitry Andric wrote: > On 25 Dec 2022, at 21:13, Dima Panov wrote: >> On 25.12.2022 20:54, Dimitry Andric wrote: >>> The branch main has been updated by dim (src committer): >>> URL: https://cgit.FreeBSD.org/ports/commit/?id=145ca54873489e7d45eac99de62f733a54dc294d >>> commit 145ca54873489e7d45eac99de62f733a54dc294d >>> Author: Dimitry Andric >>> AuthorDate: 2022-12-20 22:28:41 +0000 >>> Commit: Dimitry Andric >>> CommitDate: 2022-12-25 17:53:21 +0000 >>> audio/openal-soft: fix build with lld 15 on i386 >>> >> [skip] >> >>> +.include >>> + >>> +# The following is actually meant for lld 15.0 and later, but the ports >>> +# framework does not support LINKER_TYPE and LINKER_VERSION yet. >>> +.if ${COMPILER_TYPE} == "clang" && ${COMPILER_VERSION} >= 150 >>> +# Turn off checking of dynamic relocations, to avoid lld diagnostics about >>> +# possibly incorrect addend values. >>> +LDFLAGS_i386+= -Wl,--no-check-dynamic-relocations >>> +.endif >>> + >>> PLIST_SUB= SOVERSION=${PORTVERSION} >>> OPTIONS_DEFINE= CONFIG EXAMPLES JACK OSS PORTAUDIO PULSEAUDIO \ >> >> Looks like 1) misplased .pre.mk include and corresponding section >> 2) not closed with .post.mk >> >> This breaks OPTIONS settings (always sets to off due misconfig) and >> caused unneded rebuild of consumers > > I'm not a ports wizard, so could you enlighten me what the correct > incantation of the various *.mk files is? I.e., first bsd.port.pre.mk, > then where should bsd.port.post.mk be put? > > The reason I put bsd.port.pre.mk there is that without it, the ports > framework does not fill the COMPILER_TYPE and COMPILER_VERSION > variables, even though the port Makefile has "USES=compiler". As far as > I can see in other ports Makefiles, this is solved by including > bsd.port.pre.mk before the first use of those variables. Put ".include " and the .if block right before the post-patch target. Replace ".include " with ".include ".