From nobody Sun Dec 25 22:19:10 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NgFhM3nt8z1J21B; Sun, 25 Dec 2022 22:19:31 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NgFhM3Lyrz497N; Sun, 25 Dec 2022 22:19:31 +0000 (UTC) (envelope-from dim@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1672006771; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RIJoP5BlF275+UkdDJqcb+1bngRtUnJA+/TK8MQMfBg=; b=r+nOylwWzXe3SBKG+10NdD6bxSOH3NqtEI7wW7V7xEoh7D+xu8tm8HhqdkWoOlWeIvOhAJ al1LaSMbPFsIHYn7y52deZeK8tibwsxBoutdQ94u/OlAQPp08m4Y5EXOpySD4pJoKInkyv wLbX7Nkun4uu/fGYcHRJXd1CrJW9tYLG1jgPGhiiBp6T3WhK6Ry6u8v7NRzMOfUr6d+lng 2LAB92uCJqOjJ6HJegHRWpxlcNxLI+vqwKQtJJ6RZP1DqvTGiUIORsjdVOfdrgfKsvRMVK A4MHzChOgEZ+GNWaCnSClFwEdBVLcExuRlBYbtWrn3zX8sLkRdu/rR2A/VxnMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1672006771; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RIJoP5BlF275+UkdDJqcb+1bngRtUnJA+/TK8MQMfBg=; b=G9myG10+ekif826cv0Rb2bMb/YDfh4ha9Ya/IXA1WI0qNLEpDqxiItv1X/YJJRc6Qc0LGS 6G273oMGmvYv1NXbm+GqdTclohHd1h1ZuqWxqhKPWmyGowiL7QmmIUZi4wxLXRNBf+6XoT WjrH72FibaNMbIYzC5YG3EDszJ+WBHxBu4Q3vD/+a8PzL0sYKW93pVeNUQ72Tl+P9Q0z+N nyOzHnJR6bPnwNrWB63+pJRchr/y9VnyDzenRWegZgwH8GRW7zeqhTg1pwwGYw9Sws9022 94w/pQ+i/jaNjpgY8+lOM5dhjHoHW+hHmN/BV10giFPcjth/htP/q300S/jqcw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1672006771; a=rsa-sha256; cv=none; b=RwQqknLGvYDQYJyr5fg6RxYiYgZ9Oe4LqvOBTp3/uiIxDEcKeZVPxj8uS75LFkttAhHU/v Z0kT4gPRHfBxpWmUwcsDQyZTSa2WGvvao7j8EBo7DBjY4edPibjADqslTME9plC/jvJrri Ibm5pBVwrKFgOaqXQ0ovbyXvnWKVVqvDfq5uM5yKxWpUXbuysuYVjVo+x206+mbnKeMj3V fkY/i+2Z6zsRP9S4ODUOQpI/u8fTHmJNiLS/cAQkG8220rXk+kUaxGvW6NMj8G/l20+TQ8 YKfGEHDXsCOLd3HMddZMkFA3/jUzc8ESXex6dUzHNY2xFXTExLLBlPa2PgFCuA== Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "tensor.andric.com", Issuer "R3" (verified OK)) (Authenticated sender: dim) by smtp.freebsd.org (Postfix) with ESMTPSA id 4NgFhM1dgHzVBW; Sun, 25 Dec 2022 22:19:31 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtpclient.apple (longrow.home.andric.com [192.168.0.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 741F914EDE; Sun, 25 Dec 2022 23:19:29 +0100 (CET) Content-Type: multipart/signed; boundary="Apple-Mail=_56180484-5CDE-4B83-A182-104641AFE5AE"; protocol="application/pgp-signature"; micalg=pgp-sha1 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Subject: Re: git: 145ca5487348 - main - audio/openal-soft: fix build with lld 15 on i386 From: Dimitry Andric In-Reply-To: <2cf7882a-a250-2c08-4434-80c836a504f8@FreeBSD.org> Date: Sun, 25 Dec 2022 23:19:10 +0100 Cc: "ports-committers@freebsd.org" , "dev-commits-ports-all@freebsd.org" , "dev-commits-ports-main@freebsd.org" Message-Id: <67C4B58F-2E11-4092-8757-20AC2BF28383@FreeBSD.org> References: <202212251754.2BPHsgY6042846@gitrepo.freebsd.org> <2cf7882a-a250-2c08-4434-80c836a504f8@FreeBSD.org> To: Dima Panov X-Mailer: Apple Mail (2.3731.300.101.1.3) X-ThisMailContainsUnwantedMimeParts: N --Apple-Mail=_56180484-5CDE-4B83-A182-104641AFE5AE Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 25 Dec 2022, at 21:13, Dima Panov wrote: >=20 > On 25.12.2022 20:54, Dimitry Andric wrote: >> The branch main has been updated by dim (src committer): >> URL: = https://cgit.FreeBSD.org/ports/commit/?id=3D145ca54873489e7d45eac99de62f73= 3a54dc294d >> commit 145ca54873489e7d45eac99de62f733a54dc294d >> Author: Dimitry Andric >> AuthorDate: 2022-12-20 22:28:41 +0000 >> Commit: Dimitry Andric >> CommitDate: 2022-12-25 17:53:21 +0000 >> audio/openal-soft: fix build with lld 15 on i386 >>=20 > [skip] >=20 >> +.include >> + >> +# The following is actually meant for lld 15.0 and later, but the = ports >> +# framework does not support LINKER_TYPE and LINKER_VERSION yet. >> +.if ${COMPILER_TYPE} =3D=3D "clang" && ${COMPILER_VERSION} >=3D 150 >> +# Turn off checking of dynamic relocations, to avoid lld diagnostics = about >> +# possibly incorrect addend values. >> +LDFLAGS_i386+=3D -Wl,--no-check-dynamic-relocations >> +.endif >> + >> PLIST_SUB=3D SOVERSION=3D${PORTVERSION} >> OPTIONS_DEFINE=3D CONFIG EXAMPLES JACK OSS PORTAUDIO PULSEAUDIO \ >=20 > Looks like 1) misplased .pre.mk include and corresponding section > 2) not closed with .post.mk >=20 > This breaks OPTIONS settings (always sets to off due misconfig) and = caused unneded rebuild of consumers I'm not a ports wizard, so could you enlighten me what the correct incantation of the various *.mk files is? I.e., first bsd.port.pre.mk, then where should bsd.port.post.mk be put? The reason I put bsd.port.pre.mk there is that without it, the ports framework does not fill the COMPILER_TYPE and COMPILER_VERSION variables, even though the port Makefile has "USES=3Dcompiler". As far = as I can see in other ports Makefiles, this is solved by including bsd.port.pre.mk before the first use of those variables. -Dimitry --Apple-Mail=_56180484-5CDE-4B83-A182-104641AFE5AE Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCY6jMXgAKCRCwXqMKLiCW o2+wAKDOyxFxC4Xik52J+017pAxaesp0gwCfekdLt+chN61eUifnrZ3uGzT77gE= =4AyV -----END PGP SIGNATURE----- --Apple-Mail=_56180484-5CDE-4B83-A182-104641AFE5AE--