From nobody Sun Dec 25 21:10:56 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NgD9S1h9mz1HbTj; Sun, 25 Dec 2022 21:11:08 +0000 (UTC) (envelope-from sbruno@freebsd.org) Received: from mail.ignoranthack.me (ignoranthack.me [199.102.79.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4NgD9R6nxTz3x9T; Sun, 25 Dec 2022 21:11:07 +0000 (UTC) (envelope-from sbruno@freebsd.org) Authentication-Results: mx1.freebsd.org; none Received: from [192.168.1.14] (unknown [98.60.75.233]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sbruno@ignoranthack.me) by mail.ignoranthack.me (Postfix) with ESMTPSA id A30801AF4EB; Sun, 25 Dec 2022 21:11:00 +0000 (UTC) Message-ID: <868a6d45-7909-ddba-cf24-848f1b4e83e9@freebsd.org> Date: Sun, 25 Dec 2022 14:10:56 -0700 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: git: 145ca5487348 - main - audio/openal-soft: fix build with lld 15 on i386 To: Dima Panov , Dimitry Andric , ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org References: <202212251754.2BPHsgY6042846@gitrepo.freebsd.org> <2cf7882a-a250-2c08-4434-80c836a504f8@FreeBSD.org> Content-Language: en-US From: Sean Bruno In-Reply-To: <2cf7882a-a250-2c08-4434-80c836a504f8@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4NgD9R6nxTz3x9T X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:36236, ipnet:199.102.76.0/22, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On 12/25/22 13:13, Dima Panov wrote: > Moin-moin! > > On 25.12.2022 20:54, Dimitry Andric wrote: >> The branch main has been updated by dim (src committer): >> >> URL: >> https://cgit.FreeBSD.org/ports/commit/?id=145ca54873489e7d45eac99de62f733a54dc294d >> >> commit 145ca54873489e7d45eac99de62f733a54dc294d >> Author:     Dimitry Andric >> AuthorDate: 2022-12-20 22:28:41 +0000 >> Commit:     Dimitry Andric >> CommitDate: 2022-12-25 17:53:21 +0000 >> >>      audio/openal-soft: fix build with lld 15 on i386 > [skip] > >> +.include >> + >> +# The following is actually meant for lld 15.0 and later, but the ports >> +# framework does not support LINKER_TYPE and LINKER_VERSION yet. >> +.if ${COMPILER_TYPE} == "clang" && ${COMPILER_VERSION} >= 150 >> +# Turn off checking of dynamic relocations, to avoid lld diagnostics >> about >> +# possibly incorrect addend values. >> +LDFLAGS_i386+=    -Wl,--no-check-dynamic-relocations >> +.endif >> + >>   PLIST_SUB=    SOVERSION=${PORTVERSION} >>   OPTIONS_DEFINE=        CONFIG EXAMPLES JACK OSS PORTAUDIO PULSEAUDIO \ > > Looks like 1) misplased .pre.mk include and corresponding section > 2) not closed with .post.mk > > This breaks OPTIONS settings (always sets to off due misconfig) and > caused unneded rebuild of consumers > > This also broke my amd64 build all together, so it definitely needs to be adjusted. sean