Re: git: b0e97296ca3a - main - x11/libICE: Fix C++ interoperability error due to static_assert define (+)

From: Baptiste Daroussin <bapt_at_FreeBSD.org>
Date: Fri, 09 Dec 2022 10:18:49 UTC
On Tue, Dec 06, 2022 at 01:07:51PM +0000, Dima Panov wrote:
> The branch main has been updated by fluffy:
> 
> URL: https://cgit.FreeBSD.org/ports/commit/?id=b0e97296ca3a3f4f2ee41f1fd5ff4e38039d5a73
> 
> commit b0e97296ca3a3f4f2ee41f1fd5ff4e38039d5a73
> Author:     Dima Panov <fluffy@FreeBSD.org>
> AuthorDate: 2022-12-06 13:01:41 +0000
> Commit:     Dima Panov <fluffy@FreeBSD.org>
> CommitDate: 2022-12-06 13:01:41 +0000
> 
>     x11/libICE: Fix C++ interoperability error due to static_assert define (+)
>     
>     Backport critical fix from upstream.
>     
>     Upstream commit 0269c687 added a static_assert helper
>     that gets defined to blank if left undefined by assert.h.
>     As this is not a macro in other languages that use this header,
>     this can lead to a compile-time error.
>     
>     See also:       https://gitlab.freedesktop.org/xorg/lib/libice/-/commit/e176b676cff17948d68299c00dddefe41638c752
>     
>     Pointy hat to:  manu (for skipped exp-run)
>     Approved by:    portmgr blanket

Please refrain from using pointy hat in the commit log except when referring to
yourself if you think this is appropriate.

We have killed the finger pointing culture long ago, it would be nice to keep it
like this.

Best regards,
Bapt