From nobody Thu Aug 11 16:02:37 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4M3WmW1xC1z4Ykx4; Thu, 11 Aug 2022 16:02:51 +0000 (UTC) (envelope-from nc@FreeBSD.org) Received: from thunderstorm.neelc.org (thunderstorm.neelc.org [66.42.64.109]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4M3WmT6YWSz3jS5; Thu, 11 Aug 2022 16:02:49 +0000 (UTC) (envelope-from nc@FreeBSD.org) Received: from mail.neelc.org (thunderstorm.neelc.org [IPv6:2001:19f0:8001:174b:5400:3ff:febf:260b]) by thunderstorm.neelc.org (Postfix) with ESMTPSA id 4721E2FAF1A; Thu, 11 Aug 2022 09:02:38 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Date: Thu, 11 Aug 2022 09:02:37 -0700 From: Neel Chauhan To: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= Cc: "ports-committers@FreeBSD.org" , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 5d38de488ba0 - main - devel/gindent: fix build In-Reply-To: References: <202208092050.279Ko76l093213@gitrepo.freebsd.org> Message-ID: <7f81101cb04541949f4c7c54505c2349@FreeBSD.org> X-Sender: nc@FreeBSD.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4M3WmT6YWSz3jS5 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=softfail (mx1.freebsd.org: 66.42.64.109 is neither permitted nor denied by domain of nc@FreeBSD.org) smtp.mailfrom=nc@FreeBSD.org X-Spamd-Result: default: False [-3.10 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MLMMJ_DEST(0.00)[dev-commits-ports-all@freebsd.org,dev-commits-ports-main@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; R_DKIM_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; ASN(0.00)[asn:20473, ipnet:66.42.64.0/20, country:US]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; DMARC_NA(0.00)[freebsd.org]; R_SPF_SOFTFAIL(0.00)[~all:c]; FROM_HAS_DN(0.00)[]; FREEFALL_USER(0.00)[nc]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCPT_COUNT_THREE(0.00)[4]; MID_RHS_MATCH_FROM(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TAGGED_RCPT(0.00)[]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N Hi, Sorry for the delay. On 2022-08-09 13:49, Fernando ApesteguĂ­a wrote: > The issue is an unused variable. Wouldn't it be better to fix that > instead of removing -Werror? Also sending that upstream would be nice. This patch technically came from an outside contributor. I can submit a patch to fix this and sent it upstream. -Neel (nc@)