Re: git: 851a5602c7bf - main - print/py-uharfbuzz: mark BROKEN, fails to build after harfbuzz update

From: Jan Beich <jbeich_at_FreeBSD.org>
Date: Tue, 02 Aug 2022 20:07:38 UTC
Dmitry Marakasov <amdmi3@FreeBSD.org> writes:

> The branch main has been updated by amdmi3:
>
> URL: https://cgit.FreeBSD.org/ports/commit/?id=851a5602c7bfafd0e4f664edc12ad4a61d248f76
>
> commit 851a5602c7bfafd0e4f664edc12ad4a61d248f76
> Author:     Dmitry Marakasov <amdmi3@FreeBSD.org>
> AuthorDate: 2022-08-02 18:53:39 +0000
> Commit:     Dmitry Marakasov <amdmi3@FreeBSD.org>
> CommitDate: 2022-08-02 19:08:21 +0000
>
>     print/py-uharfbuzz: mark BROKEN, fails to build after harfbuzz update

Please, document the error snippet in the message body e.g.,

  src/uharfbuzz/_harfbuzz.cpp:20874:25: error: no matching function for call to 'hb_subset_repack_or_fail'
    __pyx_v_packed_blob = hb_subset_repack_or_fail(__pyx_v_obj_list->_hb_obj_list, __pyx_v_num_nodes);
                          ^~~~~~~~~~~~~~~~~~~~~~~~
  /usr/local/include/harfbuzz/hb-subset-repacker.h:73:1: note: candidate function not viable: requires 3 arguments, but 2 were provided
  hb_subset_repack_or_fail (hb_tag_t table_tag,
  ^
  1 error generated.

instead of trying to compress into oneliner for BROKEN at the expense of
context and readability.

>     
>     Approved by:    portmgr blanket

Reported by:	pkg-fallout

> ---
>  print/py-uharfbuzz/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/print/py-uharfbuzz/Makefile b/print/py-uharfbuzz/Makefile
> index c302c62bdd9c..4abb7a2b710a 100644
> --- a/print/py-uharfbuzz/Makefile
> +++ b/print/py-uharfbuzz/Makefile
> @@ -10,6 +10,8 @@ COMMENT=	Streamlined Cython bindings for the harfbuzz shaping engine
>  LICENSE=	APACHE20
>  LICENSE_FILE=	${WRKSRC}/LICENSE
>  
> +BROKEN=		does not build: no matching function for call to 'hb_subset_repack_or_fail'

I've opened https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265585
with the fix.