From nobody Thu Apr 28 13:25:15 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4A3C51993829; Thu, 28 Apr 2022 13:27:29 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KpxHh3RYRz3rxc; Thu, 28 Apr 2022 13:27:28 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Received: by mail-lf1-f53.google.com with SMTP id bq30so8643318lfb.3; Thu, 28 Apr 2022 06:27:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mXcQCa8wtxGz5NB2tCjZtkbr3McDiGlT5xCRPTbGydg=; b=Rf28JJchyYEFm1IB0wckJLylA8D4WsswfV6E9TroGdGKQwLf41oS20jHjx54JHseF5 DuCIZMUfpejGp0gl81AFGnBjcgN3OLWM1NdXRXryxRkRCkMx9hWR1acg2AZt0dokLNRl 62p4BDMX0FSpqCvv98W80oJkXa2v65a5VgUJbDoJAexp9FbsD9IbTOGKX9YIxdO7qqJ/ 0JuRrL/aCmjRhDEByO//9ahJcB3ETUYNBmqdfmXybnjpjQXnZLwZnP+B0ozz3LTuZ/9n BS0+wnoTIbNxOJjX7M3zN9FiGUbKSk6PSVRYkAoegjyw6MJNoGdDf3f5qCtWybkjQp2i z+rw== X-Gm-Message-State: AOAM531C1VG2zn0MUG4fd6ecfV/Z1lRGUyMh/QFdgy7vmrysOYGWrXLZ ZKR12IrdnvKKOTkQx2+yN09ndIx1oJNKLg== X-Google-Smtp-Source: ABdhPJzm5BxYsrn8bnYCsipTIT/ZbljQJV7FvGbVaExzkxKPt0Zx/qt1kbJSCqfpSJWBNuddK00x5g== X-Received: by 2002:a05:6512:3f21:b0:448:2f20:586f with SMTP id y33-20020a0565123f2100b004482f20586fmr25128162lfa.431.1651152440899; Thu, 28 Apr 2022 06:27:20 -0700 (PDT) Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com. [209.85.167.41]) by smtp.gmail.com with ESMTPSA id e28-20020a19691c000000b00471f9848a27sm1359lfc.278.2022.04.28.06.27.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Apr 2022 06:27:20 -0700 (PDT) Received: by mail-lf1-f41.google.com with SMTP id x33so8665038lfu.1; Thu, 28 Apr 2022 06:27:20 -0700 (PDT) X-Received: by 2002:a05:6512:3f26:b0:46b:92c0:54da with SMTP id y38-20020a0565123f2600b0046b92c054damr25761993lfa.369.1651152440067; Thu, 28 Apr 2022 06:27:20 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202204280601.23S61YQQ010774@gitrepo.freebsd.org> In-Reply-To: From: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= Date: Thu, 28 Apr 2022 15:25:15 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 930715f767cc - main - editors/rehex: update to 0.5.0 To: Alexey Dokuchaev Cc: "ports-committers@FreeBSD.org" , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4KpxHh3RYRz3rxc X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of fernandoapesteguia@gmail.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=fernandoapesteguia@gmail.com X-Spamd-Result: default: False [-2.99 / 15.00]; ARC_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; TO_DN_EQ_ADDR_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_COUNT_THREE(0.00)[4]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.99)[-0.992]; RCVD_IN_DNSWL_NONE(0.00)[209.85.167.41:received,209.85.167.53:from]; MLMMJ_DEST(0.00)[dev-commits-ports-all,dev-commits-ports-main]; FORGED_SENDER(0.30)[fernape@freebsd.org,fernandoapesteguia@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.167.53:from]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[fernape@freebsd.org,fernandoapesteguia@gmail.com] X-ThisMailContainsUnwantedMimeParts: N On Thu, Apr 28, 2022 at 8:22 AM Alexey Dokuchaev wrote: > > On Thu, Apr 28, 2022 at 06:01:34AM +0000, Fernando Apestegu??a wrote: > > commit 930715f767ccfb6375ee7c56f7ba3134541593de > > > > editors/rehex: update to 0.5.0 > > > > -MAKE_ENV= LUA_PKG="lua-${LUA_VER}" LUA="${LUA_CMD}" > > +MAKE_ENV= LUA_PKG="lua-${LUA_VER}" LUA="${LUA_CMD}" STRIP="${STRIP}" > > So now you have to pass STRIP explicitly... > > > - install -D -m 0755 $(EXE) $(DESTDIR)$(bindir)/$(EXE) > > -+ $(BSD_INSTALL_PROGRAM) $(EXE) $(DESTDIR)$(bindir)/$(EXE) > > ++ install -m 0755 $(STRIP) $(EXE) $(DESTDIR)$(bindir)/$(EXE) > > ... to use it here, but BSD_INSTALL_PROGRAM already does it automagically, > why remove it and set the Sun by hands? > > > -+ $(BSD_INSTALL_DATA) res/icon$${s}.png $(DESTDIR)$(datarootdir)/icons/hicolor/$${s}x$${s}/apps/rehex.png; \ > > ++ install -m 0644 res/icon$${s}.png $(DESTDIR)$(datarootdir)/icons/hicolor/$${s}x$${s}/apps/rehex.png; \ > > Ditto for BSD_INSTALL_DATA here and below. I've asked the maintainer about this. I reverted the change locally and rebuilt 0.4.1 and I don't see any warnings about not stripped files. Thanks for pointing this out. > > ./danfe