From nobody Wed Apr 27 21:10:36 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 2F00A1AB6CD7; Wed, 27 Apr 2022 21:10:37 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KpWcY0x1vz3n6b; Wed, 27 Apr 2022 21:10:37 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1651093837; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=g4j++pWP7s9dNwLGv13g+TQ5EwySXBm2ay6Gfs+Nvj4=; b=xd1FqKnq7pEe9cHLMShZcpqaMMmnNQTss9bbCD6ZsJmTIGuxlNIqDH5Z0/BndZ1Rt0YDiv GN6wIOpgGEqtTYmF+o5maq+/zmT7QO7i126SopclxxIBy/9Z1WiqS+M8nQzzrQIobTof0k 9PsCfZpI8/8jHkVG/kL57uktOn4BP6H5YivT+KuM8JQk7TjVx5qlz3jQxOZ2wXFiTWSNG5 kxVgXQrkRIPfo8IVSv1KvCXwOxrI+Xkn9NTVFdUG9ldYfYIOI7qbCnFdBrMZxdBp70yoH+ rMLtHu4QF7FxTDLr47Zz/CDu8QoVVfg7BulyqAV/IuxLAmRGiQ2Jg/4QtZl6Fg== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 03654B376; Wed, 27 Apr 2022 21:10:36 +0000 (UTC) Date: Wed, 27 Apr 2022 21:10:36 +0000 From: Alexey Dokuchaev To: Neel Chauhan Cc: Mathieu Arnold , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, dmenelkir@gmail.com Subject: Re: git: a1fa6d25cd6c - main - audio/strawberry: Add pkg-message.in Message-ID: References: <202204261954.23QJsmW9038121@gitrepo.freebsd.org> <20220427090153.cent72zrnib6m5qr@aching.in.mat.cc> <2d47938774a229feab628ce010ca4fd5@FreeBSD.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2d47938774a229feab628ce010ca4fd5@FreeBSD.org> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1651093837; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=g4j++pWP7s9dNwLGv13g+TQ5EwySXBm2ay6Gfs+Nvj4=; b=ub4r9JrrolQWFfH/b8IB1fUuMO5tX0wVimS3MxnY9cJ///b/OYafhaQh9aHOafQusXSrrE VTMK7Xo48zVGgaWPm+/1C2dl+ZObnR5bmxnLEiIl0G8rDVNub1nlJnDX2rjP5JT8+Y21Mt Lc/UNVTM2pRTn7eCxJ/Ij8F11nFxp4koTTJgQAmS4v8vqfFaV8g7mCA+ArysFNVZyZNNqq bHWHHsOYCTJM/BT2E/20+0568JI5dMqhWZUaNdTw5hL/b/gaqPefL/pxaKjnsW5V23u9nW y2qi4royg4mRnbgfpRWt9NGsYbPlPoFQGUZckXTR2fv1dHWw8rgVGcjBJoeF8Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1651093837; a=rsa-sha256; cv=none; b=dK07tBaaRGH0HGkhvEFfTkuiOspguAOG/vhsqiwt+MbzIeD8hEIte2RkKSsMTHMNVN78vg Kz6g/CxkVONqozocVFZBKUIFQG76bkRr+x06GA2BbynN02qkHCcgB4+8Ws/34p0uY0tykh WG7mhWDme3W58KZFan/s2v56vftCTOLCQc8vS6Z6Saq58fXqElRfAkB8Ni9j0xWxeVjGxp +4K1b+3frMjgxf/lfqbk1H61KoBknDCFILu2GG58z+XqyU2677adOb8f97Iwe5a+oX+VnR XdMW9w+f/MPnR5IUjtsqMkODiMDhgyTzYwVjGQD6MM5GZz/sMbvOXCJLzNPwZw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Wed, Apr 27, 2022 at 01:24:17PM -0700, Neel Chauhan wrote: > On 2022-04-27 02:01, Mathieu Arnold wrote: > > Why files/pkg-message.in and not simply pkg-message ? There is no > > replacement done in there, no need to have the file run through sed for > > replacements that are not there. > > It was done by the person who made the patch, for some reason they chose > to use pkg-message.in. It's your responsibility as a committer to review and brush up whatever patches you intend to commit. We should never blindly accept proposed changes and check them in verbatim. ./danfe