From nobody Tue Apr 26 21:05:02 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 230D81994326; Tue, 26 Apr 2022 21:05:05 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KnvXd0Ps9z4gkt; Tue, 26 Apr 2022 21:05:05 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1651007105; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f3z5wlXNZp1oPMbkfMZoKcOPT33v342korjbV+vXsig=; b=vEXbA027jXRDOeYIKJ1rcbHC+S+5aqHvprd5ExSyqbbPLPuGXmseIVGIy17t+sG2sdn4Bg 7fVSDE8mItBSRfH9xbOp1qPQ0MrEkb+58IkiwLm9LB0CCBLIBYyabdybSpnVS62kk4fK3z 8E0DRvlw1xB4dfbRw9P1JOOpjFLJrg9so9NlaBqE4X9aljusMgKyluX2z+1paEGopGtr6D pgy0tnHd50cKy1TrzzH1aQ1pPkZoFeR3eRJx8pcYCg2fPb/G4cWtKmXll2W1antD6f7Fbt dKRzTSqkYZqY7CyrLFs2egUI6CLfFiUve1KAyd+NaFMgFe8/mhGZBd9NJXc+Pg== Received: from [172.24.42.21] (host-87-3-132-229.retail.telecomitalia.it [87.3.132.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: madpilot/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 5FD6D2FA21; Tue, 26 Apr 2022 21:05:04 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Message-ID: <8bc69c82-b058-eedc-52a5-de2341cdef93@FreeBSD.org> Date: Tue, 26 Apr 2022 23:05:02 +0200 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: git: 48a481f83ecb - main - www/firefox: fix build with sndio Content-Language: en-US To: Christoph Moench-Tegeder , ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org References: <202204261851.23QIpdlL055150@gitrepo.freebsd.org> From: Guido Falsi In-Reply-To: <202204261851.23QIpdlL055150@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1651007105; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f3z5wlXNZp1oPMbkfMZoKcOPT33v342korjbV+vXsig=; b=RyQi27DkFE29aBmqAeWnEag6gIE1i4iIrTDNMac6FcryDflafzPduc0rqXuECMCYy9LORo z3Y/HJoG1/JtCNQDoD352R2eB72eX9NWz4Qd8+sy6JiK7p6Sq/Zwt0Kts8GZ8+CLc+ue2C fnGCRp3yoEyMksFo2cw0IrpEQNX5P+UjVUXgaHPl0awXmNAoHaaArLEbo8tR9nSn2jzQCB 2/y7Mdgdfwv9newCGXK+09PEnDrb9UYMUUNeVhf4BKfz9iwBmZFX1ZKa5cpU2ffkx7PrRs 5s9mGz2jFhEiTAATGsQ2Hy9TXfJdrJ7FV3qUZ2aTSpWJet+YdKCwYRSOQH7KCA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1651007105; a=rsa-sha256; cv=none; b=ZPZjIAlEUQ0YX6j3DdH8u/1mXZG43oBF0z62OWoVAc3VSMiWz6ytQuyi3KxkFngIy4tu0R VKKWG6ctlK4Ag2b/3gkuBfKwxdKtq8wsk4JiZ6iWXxXy7ZzEFzu618auBoHy239l3rIXrk 3xkfB8Upv6mGvhsd/gwKecIXut5CGkJCkBu8k5ySNg+KC5kmlaUW2BzBL90O5Q6+eVNx1d MH4P+G2K6rMwfJuAytxNY5f3WalxB3SJGt9S0bOcu/dquxxbVLlUdPUvcBue5p3PEhHfW9 FMqY1Hewsk3MjSHtKU6/TjEdka6CFLYcnnhSO31pq8FvaA/BoAKtiVHax3FbIA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 26/04/22 20:51, Christoph Moench-Tegeder wrote: > The branch main has been updated by cmt: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=48a481f83ecbb669a22c2c9f9dc3712bf5a7b71c > > commit 48a481f83ecbb669a22c2c9f9dc3712bf5a7b71c > Author: Christoph Moench-Tegeder > AuthorDate: 2022-04-26 18:49:11 +0000 > Commit: Christoph Moench-Tegeder > CommitDate: 2022-04-26 18:49:11 +0000 > > www/firefox: fix build with sndio > > upstream sndio handling was fixed for non-OpenBSD systems: > https://bugzilla.mozilla.org/show_bug.cgi?id=1351378 > so our own "fixing" actually broke build. > > PR: 263587 > Reported by: Robert Cina, jkim@ > --- > Mk/bsd.gecko.mk | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Mk/bsd.gecko.mk b/Mk/bsd.gecko.mk > index eef9db747685..cee597e4e465 100644 > --- a/Mk/bsd.gecko.mk > +++ b/Mk/bsd.gecko.mk > @@ -270,10 +270,15 @@ MOZ_OPTIONS+= --disable-pulseaudio > > . if ${PORT_OPTIONS:MSNDIO} > BUILD_DEPENDS+= ${LOCALBASE}/include/sndio.h:audio/sndio > +MOZ_OPTIONS+= --enable-sndio > +. if ${MOZILLA_VER:R:R} < 100 > post-patch-SNDIO-on: > @${REINPLACE_CMD} -e 's|OpenBSD|${OPSYS}|g' \ > -e '/DISABLE_LIBSNDIO_DLOPEN/d' \ > ${MOZSRC}/media/libcubeb/src/moz.build > +. endif > +. else > +MOZ_OPTIONS+= --disable-sndio > . endif > > . if ${PORT_OPTIONS:MDEBUG} > Unluckily this makes thunderbird fail: checking whether cross compiling... no Traceback (most recent call last): File "/wrkdirs/usr/ports/mail/thunderbird/work/thunderbird-91.8.1/configure.py", line 226, in sys.exit(main(sys.argv)) File "/wrkdirs/usr/ports/mail/thunderbird/work/thunderbird-91.8.1/configure.py", line 50, in main sandbox.run(os.path.join(os.path.dirname(__file__), "moz.configure")) File "/wrkdirs/usr/ports/mail/thunderbird/work/thunderbird-91.8.1/python/mozbuild/mozbuild/configure/__init__.py", line 554, in run raise InvalidOptionError(msg) mozbuild.configure.options.InvalidOptionError: Unknown option: --disable-sndio ===> Script "configure" failed unexpectedly. I'm trying to fix it locally, but thought to report it right away. -- Guido Falsi