From nobody Fri Apr 01 05:42:57 2022
X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id D114E1A5BBC7;
	Fri,  1 Apr 2022 05:42:57 +0000 (UTC)
	(envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
	 client-signature RSA-PSS (4096 bits) client-digest SHA256)
	(Client CN "freefall.freebsd.org", Issuer "R3" (verified OK))
	by mx1.freebsd.org (Postfix) with ESMTPS id 4KV8G95bRSz4SGG;
	Fri,  1 Apr 2022 05:42:57 +0000 (UTC)
	(envelope-from danfe@freebsd.org)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim;
	t=1648791777;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=XoXgyQqm/+sl4ZGj7g2laukIRY29/7Qr7N8dfVM+HYQ=;
	b=SKTi17sIPYSpNbgvZnQ0bJebPL/pbCfZqJMyDDhTXr8mUaS6RQJY1UuFU1mSflI7av5OfU
	6oyxtgDGgQH8jWSjsjq/iv1WyM5slZKEU1Fh3KZrnX6Fhnu8zp5BMnrSHKVxUw0xrf4Gc6
	RsYOL1EJEDw0sJ7+3MLZyFxUZqISDH56vjNhr49/cMYtbdkopXNjh980O+SBtMsIHwtQeT
	wm9eBNCVi2qO/9XDXfA+hjKDaNXmtR1gbJghUfNWneVpkBYnF0EOsqYwBYJUJl990DqrE0
	CR/L38ODXU/m/NzgcgGX/kez6nTmwM2rR8OLJO/Z0t4IVg/o9hvfUrfrtu3ytw==
Received: by freefall.freebsd.org (Postfix, from userid 1033)
	id AA9EFDDB3; Fri,  1 Apr 2022 05:42:57 +0000 (UTC)
Date: Fri, 1 Apr 2022 05:42:57 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Christoph Moench-Tegeder <cmt@burggraben.net>
Cc: Neel Chauhan <nc@freebsd.org>, ports-committers@freebsd.org,
	dev-commits-ports-all@freebsd.org,
	dev-commits-ports-main@freebsd.org
Subject: Re: git: e23a5a20b30f - main - mail/evolution: Update to 3.44.0
Message-ID: <YkaQ4US/9Ex1ImJO@FreeBSD.org>
References: <202203292005.22TK5BfW011072@gitrepo.freebsd.org>
 <YkRjwbCAo32+l/+t@elch.exwg.net>
List-Id: Commits to the main branch of the FreeBSD ports repository <dev-commits-ports-main.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main
List-Help: <mailto:dev-commits-ports-main+help@freebsd.org>
List-Post: <mailto:dev-commits-ports-main@freebsd.org>
List-Subscribe: <mailto:dev-commits-ports-main+subscribe@freebsd.org>
List-Unsubscribe: <mailto:dev-commits-ports-main+unsubscribe@freebsd.org>
Sender: owner-dev-commits-ports-main@freebsd.org
X-BeenThere: dev-commits-ports-main@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YkRjwbCAo32+l/+t@elch.exwg.net>
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org;
	s=dkim; t=1648791777;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=XoXgyQqm/+sl4ZGj7g2laukIRY29/7Qr7N8dfVM+HYQ=;
	b=ZtAG/shhK2gaqMLz48aXFRp7Y+V1+sPjdfzpWuLUV1a2l+VKbBuDzXnq4EJhHPkVJsL4qM
	1j6SL34C+Uwf1/QcM+/+DHfyVdhvxcLusNDbSW/OMNcw8uYqMn920Gh4yVI5oG+gEKPanR
	N2CI5LfabbVUahywpCCaG49eKn0U4VIbfqIsbKrDXvlnzJjCC8V1utJO9JfoekghDXGHZP
	N67qpoSEe3//hACMWDJvvEuHFvwEOoIQSFMPCuVruQrmXoHa36qlX6tkbYHenCbhYEUJEv
	RvEdR36we8IbCNMIWQXMJl/5MSlx1dvODg1wqWLO2Jbq19fqnagyr/qpcFFJOg==
ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1648791777; a=rsa-sha256; cv=none;
	b=dFU8mF28aitf9mjeSU1ygIW98miOJrUSWI7FuaWlVZNEPFRT4H+HFPd+bIIiTKX7woVaWL
	iHiSyCTOpHs4d5qOS6MpjkqLIR8TowqUZkTtp/BsWESFuie2z7ABxExrSxejkMMsJkZwgj
	tom1A9EtQ6odtb654oildDC8CMs2TQvHKhCJ/lrNy2aOjaMgnOmIksicz91hrpOHx6Hohu
	Ik91NDt54n5kS9EISEd7Xu86Iba9WBxeW4d1QrEHPvBcqUfyYuAytp2xeiTY7JR2xzGyqw
	rW34Hdai0eDSeqv7HcVZp4npf4t7508+5Rsc92lGJ67um1Ps9+AZdvbRmAV4eQ==
ARC-Authentication-Results: i=1;
	mx1.freebsd.org;
	none
X-ThisMailContainsUnwantedMimeParts: N

On Wed, Mar 30, 2022 at 04:05:53PM +0200, Christoph Moench-Tegeder wrote:
> ## Neel Chauhan (nc@FreeBSD.org):
> >     mail/evolution: Update to 3.44.0
> > -%%BOGOFILTER%%lib/evolution/modules/module-bogofilter.so
> > +lib/evolution/modules/module-bogofilter.so
> 
> It might have crossed your mind that these conditionals (yes, plural,
> all of them) did actually serve a purpose here.
> In short, this commit broke packaging for non-default options.

Not the first time.  Neel, do you actually read the email coming from
your fellow committers?  Do you try to learn from your past mistakes?

./danfe