From nobody Fri Oct 29 09:19:33 2021 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 6AC77181A713; Fri, 29 Oct 2021 09:19:35 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HgcMC2Wlkz4jPb; Fri, 29 Oct 2021 09:19:35 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from [172.24.42.13] (host-95-250-211-60.retail.telecomitalia.it [95.250.211.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: madpilot/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id BC0AB210E5; Fri, 29 Oct 2021 09:19:34 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Message-ID: Date: Fri, 29 Oct 2021 11:19:33 +0200 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: git: 027ed04832c4 - main - deskutils/nextcloudclient: Fix build failure when tests are enabled Content-Language: en-US From: Guido Falsi To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org References: <202110290915.19T9FsiG028735@gitrepo.freebsd.org> In-Reply-To: <202110290915.19T9FsiG028735@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N On 29/10/21 11:15, Guido Falsi wrote: > The branch main has been updated by madpilot: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=027ed04832c4160ac66139b8769a33d828ee7573 > > commit 027ed04832c4160ac66139b8769a33d828ee7573 > Author: Guido Falsi > AuthorDate: 2021-10-29 09:13:03 +0000 > Commit: Guido Falsi > CommitDate: 2021-10-29 09:13:03 +0000 > > deskutils/nextcloudclient: Fix build failure when tests are enabled > > Upstream build system tries to include a Linux only library in the > build when tests are enabled. > > This patch has already been accepted upstream. > > PR: 258119 > Approved by: Maintiner timeout > Obtained from: https://github.com/nextcloud/desktop/pull/3880 > --- > deskutils/nextcloudclient/Makefile | 1 - > .../files/patch-test_nextcloud__add__test.cmake | 11 +++++++++++ > 2 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/deskutils/nextcloudclient/Makefile b/deskutils/nextcloudclient/Makefile > index 57197c93ee57..7fd8e3ddd1c5 100644 > --- a/deskutils/nextcloudclient/Makefile > +++ b/deskutils/nextcloudclient/Makefile > @@ -29,7 +29,6 @@ CMAKE_ARGS= -DBUILD_UPDATER:BOOL=OFF \ > -DWITH_STACK_PROTECTOR:BOOL=OFF > USE_LDCONFIG= yes > > -DEBUG= yes > USE_GITHUB= yes > GH_ACCOUNT= nextcloud > GH_PROJECT= desktop Oops, I forgot to mention this, I also remove thiss spurious variable here, it's a nop. -- Guido Falsi