Re: git: f8daab173840 - main - devel/kf5-kio: Remove extra CPE_VENDOR and inherit from USES=kde instead
Date: Mon, 18 Oct 2021 10:28:25 UTC
On Mon, Oct 18, 2021 at 08:34:13AM +0000, Bernhard Froehlich wrote: > -USES= cmake compiler:c++11-lib cpe desktop-file-utils \ > - gettext gnome kde:5 qt:5 ssl tar:xz > -CPE_VENDOR= kde > +USES= cmake compiler:c++11-lib desktop-file-utils \ > + gettext gnome kde:5 cpe qt:5 ssl tar:xz Wouldn't it better to change USES=cpe a little to set variables later in _USES_POST? Then other USES can set their own defaults for CPE_* and we don't create a USES ordering problem that contributors have to be surprised by. diff --git a/Mk/Uses/cpe.mk b/Mk/Uses/cpe.mk index 410a05c6e437..d88aa06c17f8 100644 --- a/Mk/Uses/cpe.mk +++ b/Mk/Uses/cpe.mk @@ -18,6 +18,11 @@ .if !defined(_INCLUDE_USES_CPE_MK) _INCLUDE_USES_CPE_MK= yes +_USES_POST+= cpe +.endif + +.if defined(_POSTMKINCLUDED) && !defined(_INCLUDE_USES_CPE_POST_MK) +_INCLUDE_USES_CPE_POST_MK= yes CPE_PART ?= a CPE_PRODUCT ?= ${PORTNAME:tl}