From nobody Sat Oct 16 14:45:59 2021 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id E619917F0BBC; Sat, 16 Oct 2021 14:46:02 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta002.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HWmCt4qWFz4V5D; Sat, 16 Oct 2021 14:46:02 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from shw-obgw-4003a.ext.cloudfilter.net ([10.228.9.183]) by cmsmtp with ESMTP id biqmmjOhVps7PbkwkmBacG; Sat, 16 Oct 2021 14:46:02 +0000 Received: from spqr.komquats.com ([70.66.148.124]) by cmsmtp with ESMTPA id bkwim8vp7hYGxbkwjmjZr2; Sat, 16 Oct 2021 14:46:02 +0000 X-Authority-Analysis: v=2.4 cv=QIIL+iHL c=1 sm=1 tr=0 ts=616ae5aa a=Cwc3rblV8FOMdVN/wOAqyQ==:117 a=Cwc3rblV8FOMdVN/wOAqyQ==:17 a=kj9zAlcOel0A:10 a=8gfv0ekSlNoA:10 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=YxBL1-UpAAAA:8 a=dgy2CQ7uz54Z5MalCLcA:9 a=CjuIK1q_8ugA:10 a=vRcdKC0ogzYA:10 a=IjZwj45LgO3ly-622nXo:22 a=LK5xJRSDVpKd5WXXoEvA:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id BD2BF351; Sat, 16 Oct 2021 07:45:59 -0700 (PDT) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.16.1/8.16.1) with ESMTP id 19GEjx4Y006148; Sat, 16 Oct 2021 07:45:59 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <202110161445.19GEjx4Y006148@slippy.cwsent.com> X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Kyle Evans , mw@FreeBSD.org cc: Cy Schubert , ports-committers , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 8dc43f07dc66 - main - net/ntp: Reverse "Disable ntpd stack gap" In-reply-to: References: <202110160359.19G3xJZ0004440@gitrepo.freebsd.org> Comments: In-reply-to Kyle Evans message dated "Sat, 16 Oct 2021 00:20:31 -0500." List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sat, 16 Oct 2021 07:45:59 -0700 X-CMAE-Envelope: MS4xfI/ry95c22pIYZK8QCErFb0T0WaEfG+7EnMr3dhkkxpmG4F3OULMiuXy2MzZr0k1uJXUknaDwtx0nlKBfmglXmav0Qn8CwoKbnSOjWQKamEoJTYfw+is XyM0vGXklUNWOqYdL6De55B4g1dCIvZSpNBl5N4TrNPFrdmtqyU/KEIufvXV34qV0R3o6f+EwchUcutO/bJlsuyL62ELs+tsFvB9r/vOp1BAC84a4kgFubi6 Put5Agy5bV6EiIHYqFk9MptA8P4+QYR4gqMe0mpFI9PszcWcb23kTqZiUDnenUR3/+D7s4+KvPFAzyq5QFZflerD6YC8D4jtOB+tISTvbtcB/xlqJLTxx7Ob 1ITBqGQ21QO0G2A7R3hHdFBVwadL8Ap0lGMwYs2htq5AJJMLVmk= X-Rspamd-Queue-Id: 4HWmCt4qWFz4V5D X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N In message , Kyle Evans writes: > On Fri, Oct 15, 2021 at 10:59 PM Cy Schubert wrote: > > > > The branch main has been updated by cy: > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=8dc43f07dc662e4e7404b5521ba0 > 3c2e7f25470a > > > > commit 8dc43f07dc662e4e7404b5521ba03c2e7f25470a > > Author: Cy Schubert > > AuthorDate: 2021-10-16 03:50:11 +0000 > > Commit: Cy Schubert > > CommitDate: 2021-10-16 03:59:14 +0000 > > > > net/ntp: Reverse "Disable ntpd stack gap" > > > > 120137c822c9697c19cf94461f436f8ccc372d24 (svn r517694) disabled ntpd > > ASLR stack gap, which caused ntpd to segfault. (The patch in > > 120137c822c9697c19cf94461f436f8ccc372d24 was subsequently submitted > > to nwtime.org for inclusion into upstream ntp.) src commit > > 889b56c8cd84c9a9f2d9e3b019c154d6f14d9021 addressed the underlying cause > > for the setrlimit segfault negating the need for this workaround. This > > commit removes the workaround. > > > > MFH: 2021Q4 (after a month) > > Er, stack gap landed in 13.0, didn't it? I think you still need this > for the time being, at least gated behind a check for 13.0. I suppose a __FreeBSD_version bump on -CURRENT and subsequently on stable/13 when it's MFCed would be of benefit. Thoughts? -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org The need of the many outweighs the greed of the few.