From nobody Sat Oct 16 05:20:31 2021
X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id E803517F9BE2;
	Sat, 16 Oct 2021 05:20:42 +0000 (UTC)
	(envelope-from kevans@freebsd.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
	 client-signature RSA-PSS (4096 bits) client-digest SHA256)
	(Client CN "smtp.freebsd.org", Issuer "R3" (verified OK))
	by mx1.freebsd.org (Postfix) with ESMTPS id 4HWWgZ4pDYz4sJQ;
	Sat, 16 Oct 2021 05:20:42 +0000 (UTC)
	(envelope-from kevans@freebsd.org)
Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK))
	(Authenticated sender: kevans)
	by smtp.freebsd.org (Postfix) with ESMTPSA id 8119926A99;
	Sat, 16 Oct 2021 05:20:42 +0000 (UTC)
	(envelope-from kevans@freebsd.org)
Received: by mail-qt1-f173.google.com with SMTP id g17so2474554qtk.8;
        Fri, 15 Oct 2021 22:20:42 -0700 (PDT)
X-Gm-Message-State: AOAM530hTIB2yYQQ1gEoTV1OR3btEZtnWD1RzA+xCCln2dIgFjqEzTgl
	8yzBMnJsEhzKxGu4GsJVVan+DKeizq+J+rQv33k=
X-Google-Smtp-Source: ABdhPJwjE5PefAdXfm8z0aYVYMCZdKMCXqoGuxW8je073bN8zg6v+Z6zGH4R3nAxtEgRVQLvwc5u2KVIY1+WDqMqViE=
X-Received: by 2002:a05:622a:11d6:: with SMTP id n22mr17718819qtk.337.1634361641807;
 Fri, 15 Oct 2021 22:20:41 -0700 (PDT)
List-Id: Commits to the main branch of the FreeBSD ports repository <dev-commits-ports-main.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main
List-Help: <mailto:dev-commits-ports-main+help@freebsd.org>
List-Post: <mailto:dev-commits-ports-main@freebsd.org>
List-Subscribe: <mailto:dev-commits-ports-main+subscribe@freebsd.org>
List-Unsubscribe: <mailto:dev-commits-ports-main+unsubscribe@freebsd.org>
Sender: owner-dev-commits-ports-main@freebsd.org
X-BeenThere: dev-commits-ports-main@freebsd.org
MIME-Version: 1.0
References: <202110160359.19G3xJZ0004440@gitrepo.freebsd.org>
In-Reply-To: <202110160359.19G3xJZ0004440@gitrepo.freebsd.org>
From: Kyle Evans <kevans@freebsd.org>
Date: Sat, 16 Oct 2021 00:20:31 -0500
X-Gmail-Original-Message-ID: <CACNAnaEP=YWLpws9M2-H+YZBH5m=D+1N_YShhVY7HWQ23jOjEw@mail.gmail.com>
Message-ID: <CACNAnaEP=YWLpws9M2-H+YZBH5m=D+1N_YShhVY7HWQ23jOjEw@mail.gmail.com>
Subject: Re: git: 8dc43f07dc66 - main - net/ntp: Reverse "Disable ntpd stack gap"
To: Cy Schubert <cy@freebsd.org>
Cc: ports-committers <ports-committers@freebsd.org>, dev-commits-ports-all@freebsd.org, 
	dev-commits-ports-main@freebsd.org
Content-Type: text/plain; charset="UTF-8"
X-ThisMailContainsUnwantedMimeParts: N

On Fri, Oct 15, 2021 at 10:59 PM Cy Schubert <cy@freebsd.org> wrote:
>
> The branch main has been updated by cy:
>
> URL: https://cgit.FreeBSD.org/ports/commit/?id=8dc43f07dc662e4e7404b5521ba03c2e7f25470a
>
> commit 8dc43f07dc662e4e7404b5521ba03c2e7f25470a
> Author:     Cy Schubert <cy@FreeBSD.org>
> AuthorDate: 2021-10-16 03:50:11 +0000
> Commit:     Cy Schubert <cy@FreeBSD.org>
> CommitDate: 2021-10-16 03:59:14 +0000
>
>     net/ntp: Reverse "Disable ntpd stack gap"
>
>     120137c822c9697c19cf94461f436f8ccc372d24 (svn r517694) disabled ntpd
>     ASLR stack gap, which caused ntpd to segfault. (The patch in
>     120137c822c9697c19cf94461f436f8ccc372d24 was subsequently submitted
>     to nwtime.org for inclusion into upstream ntp.) src commit
>     889b56c8cd84c9a9f2d9e3b019c154d6f14d9021 addressed the underlying cause
>     for the setrlimit segfault negating the need for this workaround. This
>     commit removes the workaround.
>
>     MFH:            2021Q4 (after a month)

Er, stack gap landed in 13.0, didn't it? I think you still need this
for the time being, at least gated behind a check for 13.0.

Thanks,

Kyle Evans