git: 74d6d059f41c - main - net-im/libnice-gst1: Fix dependencies and make sure QA passes

From: Tobias Kortkamp <tobik_at_FreeBSD.org>
Date: Tue, 12 Oct 2021 15:02:35 UTC
The branch main has been updated by tobik:

URL: https://cgit.FreeBSD.org/ports/commit/?id=74d6d059f41cc70cb58ade97fc990d292a157fe6

commit 74d6d059f41cc70cb58ade97fc990d292a157fe6
Author:     Tobias Kortkamp <tobik@FreeBSD.org>
AuthorDate: 2021-10-12 10:56:11 +0000
Commit:     Tobias Kortkamp <tobik@FreeBSD.org>
CommitDate: 2021-10-12 15:01:37 +0000

    net-im/libnice-gst1: Fix dependencies and make sure QA passes
    
    LIB_DEPENDS is overwritten later in the master port, so libnice is
    never added as a dependency.  Setting MAINTAINER is redundant since
    it is overwritten later too.
    
    While here amend the plist to exclude unwanted files.
    
    Reported by:    portscan (overwritten variables)
---
 net-im/libnice-gst1/Makefile  |  3 +--
 net-im/libnice-gst1/pkg-plist | 24 ++++++++++++++++++++++++
 net-im/libnice/Makefile       |  4 ++--
 3 files changed, 27 insertions(+), 4 deletions(-)

diff --git a/net-im/libnice-gst1/Makefile b/net-im/libnice-gst1/Makefile
index 060cfcc353b1..695e30ccee83 100644
--- a/net-im/libnice-gst1/Makefile
+++ b/net-im/libnice-gst1/Makefile
@@ -1,9 +1,8 @@
 # Created by: Joe Marcus Clarke <marcus@FreeBSD.org>
 
-PORTREVISION=	0
+PORTREVISION=	1
 PKGNAMESUFFIX=	-gst1
 
-MAINTAINER=	gnome@FreeBSD.org
 COMMENT=	GStreamer 1 plugin from libnice
 
 LIB_DEPENDS=	libnice.so:net-im/libnice
diff --git a/net-im/libnice-gst1/pkg-plist b/net-im/libnice-gst1/pkg-plist
index 85a21aad0539..88bd88c72ad8 100644
--- a/net-im/libnice-gst1/pkg-plist
+++ b/net-im/libnice-gst1/pkg-plist
@@ -1 +1,25 @@
+@comment bin/stunbdc
+@comment bin/stund
+@comment include/nice/address.h
+@comment include/nice/agent.h
+@comment include/nice/candidate.h
+@comment include/nice/debug.h
+@comment include/nice/interfaces.h
+@comment include/nice/nice.h
+@comment include/nice/pseudotcp.h
+@comment include/stun/constants.h
+@comment include/stun/debug.h
+@comment include/stun/stunagent.h
+@comment include/stun/stunmessage.h
+@comment include/stun/usages/bind.h
+@comment include/stun/usages/ice.h
+@comment include/stun/usages/timer.h
+@comment include/stun/usages/turn.h
+@comment include/stun/win32_common.h
+@comment lib/girepository-1.0/Nice-0.1.typelib
 lib/gstreamer-1.0/libgstnice.so
+@comment lib/libnice.so
+@comment lib/libnice.so.10
+@comment lib/libnice.so.10.11.0
+@comment libdata/pkgconfig/nice.pc
+@comment share/gir-1.0/Nice-0.1.gir
diff --git a/net-im/libnice/Makefile b/net-im/libnice/Makefile
index 1e63ca4ddde7..57614ec4d46e 100644
--- a/net-im/libnice/Makefile
+++ b/net-im/libnice/Makefile
@@ -6,12 +6,12 @@ CATEGORIES=	net-im devel
 MASTER_SITES=	http://nice.freedesktop.org/releases/
 
 MAINTAINER=	gnome@FreeBSD.org
-COMMENT=	Library and transmitter that implements ICE-19
+COMMENT?=	Library and transmitter that implements ICE-19
 
 LICENSE=	LGPL21 MPL11
 LICENSE_COMB=	dual
 
-LIB_DEPENDS=	libgnutls.so:security/gnutls
+LIB_DEPENDS?=	libgnutls.so:security/gnutls
 BUILD_DEPENDS=	gtk-doc>0:textproc/gtk-doc
 
 USES=		gettext gmake gnome libtool localbase:ldflags pathfix pkgconfig meson python