From nobody Tue Oct 12 10:09:39 2021 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 276F717E750B; Tue, 12 Oct 2021 10:09:48 +0000 (UTC) (envelope-from cmt@burggraben.net) Received: from smtp.burggraben.net (smtp.burggraben.net [88.198.69.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.burggraben.net", Issuer "R3" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HTBH002zXz4ZP9; Tue, 12 Oct 2021 10:09:47 +0000 (UTC) (envelope-from cmt@burggraben.net) Received: from elch.exwg.net (elch.exwg.net [IPv6:2001:470:7120:1:127b:44ff:fe4f:148d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "elch.exwg.net", Issuer "R3" (verified OK)) by smtp.burggraben.net (Postfix) with ESMTPS id F04D8C00312; Tue, 12 Oct 2021 12:09:39 +0200 (CEST) Received: by elch.exwg.net (Postfix, from userid 1000) id 971C13AB07; Tue, 12 Oct 2021 12:09:39 +0200 (CEST) Date: Tue, 12 Oct 2021 12:09:39 +0200 From: Christoph Moench-Tegeder To: Neel Chauhan Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 72913e45e14b - main - devel/newt: Update to 0.52.21 Message-ID: References: <202110112311.19BNBBFJ028307@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <202110112311.19BNBBFJ028307@gitrepo.freebsd.org> User-Agent: Mutt/2.1.3 (2021-09-10) X-Rspamd-Queue-Id: 4HTBH002zXz4ZP9 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N ## Neel Chauhan (nc@FreeBSD.org): > devel/newt: Update to 0.52.21 How was this tested? With PYTHON=ON (the default), configure fails with checking for python versions... ./configure: 3839: Syntax error: ")" unexpected (expecting "fi") as configure.ac changed and doesn't match the assumptions in post-patch-PYTHON-on anymore (and as it's just REINPLACE_CMD and not a proper patch, you'll get no warning on that). In any case, that post-patch operation isn't even neccessary, according to configure.ac and my tests, a simple "PYTHON_CONFIGURE_WITH=python=${PYTHON_VERSION}" in our Makefile just does the job. > --- a/devel/newt/files/patch-configure.ac > +++ b/devel/newt/files/patch-configure.ac > @@ -1,15 +1,6 @@ > ---- configure.ac.orig 2017-03-17 10:36:31 UTC > +--- configure.ac.orig 2019-05-27 12:57:40 UTC > +++ configure.ac > -@@ -2,7 +2,7 @@ AC_INIT([newt_pr.h]) > - > - PACKAGE=newt > - VERSION=0.52.20 > --SONAME=0.52 > -+SONAME=52 And this breaks packaging and perhaps even usage: this changes the library name and (as the variable names imply) the SONAME: old was SONAME libnewt.so.52 and new is SONAME libnewt.so.0.52 all the while that change was never mentioned in the commit message. What the heck? This is not a competition "who has the most commits". Regards, Christoph -- Spare Space