From nobody Mon Oct 11 19:43:51 2021 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id BC4C317FB298 for ; Mon, 11 Oct 2021 19:43:53 +0000 (UTC) (envelope-from decke@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HSq3s19X6z4ZYj for ; Mon, 11 Oct 2021 19:43:53 +0000 (UTC) (envelope-from decke@freebsd.org) Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: decke) by smtp.freebsd.org (Postfix) with ESMTPSA id EA6E225FD for ; Mon, 11 Oct 2021 19:43:52 +0000 (UTC) (envelope-from decke@freebsd.org) Received: by mail-io1-f48.google.com with SMTP id i189so13397881ioa.1 for ; Mon, 11 Oct 2021 12:43:52 -0700 (PDT) X-Gm-Message-State: AOAM530X0zLLFFppPKY6Go9zWVCarEfZ+4d7/4ggvGSPQ21YrAWjQ6vn zEKbkoUo+oCvriUctBCWhuIVnyk8YraSvpU2SVqLuA== X-Google-Smtp-Source: ABdhPJzGNcRRGWkxUkTlxrisiVxcJ3EbYW0i7HVgyAKpb6OKef1x/imABru6UQvmXrtNAX0F4NSkkY4VIysoH3a4UEg= X-Received: by 2002:a05:6602:13c3:: with SMTP id o3mr7825219iov.142.1633981432262; Mon, 11 Oct 2021 12:43:52 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Received: by 2002:a92:6007:0:0:0:0:0 with HTTP; Mon, 11 Oct 2021 12:43:51 -0700 (PDT) In-Reply-To: <3067458.bT80LyP3VS@mercury> References: <202110111458.19BEw4xF062545@gitrepo.freebsd.org> <3067458.bT80LyP3VS@mercury> From: =?UTF-8?Q?Bernhard_Fr=C3=B6hlich?= Date: Mon, 11 Oct 2021 21:43:51 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: a90e961f4d19 - main - */*: Avoid extra CPE_VENDOR=kde by properly sorting USES To: Max Brazhnikov Cc: "ports-committers@freebsd.org" , "dev-commits-ports-all@freebsd.org" , "dev-commits-ports-main@freebsd.org" Content-Type: multipart/alternative; boundary="000000000000d7041f05ce18f234" X-ThisMailContainsUnwantedMimeParts: N --000000000000d7041f05ce18f234 Content-Type: text/plain; charset="UTF-8" On Monday, October 11, 2021, Max Brazhnikov wrote: > On Mon, 11 Oct 2021 14:58:04 GMT Bernhard Froehlich wrote: > > The branch main has been updated by decke: > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id= > a90e961f4d19d53621612d1257a77a5635906ee0 > > > > commit a90e961f4d19d53621612d1257a77a5635906ee0 > > Author: Bernhard Froehlich > > AuthorDate: 2021-10-11 14:53:15 +0000 > > Commit: Bernhard Froehlich > > CommitDate: 2021-10-11 14:57:51 +0000 > > > > */*: Avoid extra CPE_VENDOR=kde by properly sorting USES > > > > CPE_VENDOR=kde is already set in Uses/kde.mk so adding cpe after > > kde in our USES line makes sure that it's picked up properly. > > I believe you shouldn't rely on USES order, it will be broken sooner or > later. > Doesn't matter much since CPE data is a moving target anyway. To handle that I created chkcpe [1] which automatically analyzes the portstree once a day and verifies the CPE data it finds. In this particular case it will detect a invalid CPE vendor/product and will list the port under "invalid". There are similar cases like port rename, " repocopy" etc. which can also easily lead to invalid CPE data. [1] https://github.com/decke/chkcpe -- Bernhard Froehlich http://www.bluelife.at/ --000000000000d7041f05ce18f234--