Re: git: ae1787aab23e - main - shells/zsh: Add BASE_ZSH option

On Fri, Nov 26, 2021 at 12:55:10AM +0000, Yasuhiro Kimura wrote:
> The branch main has been updated by yasu:
> 
> URL: https://cgit.FreeBSD.org/ports/commit/?id=ae1787aab23e44e369dbb0cc814e8318c6f86e0d
> 
> commit ae1787aab23e44e369dbb0cc814e8318c6f86e0d
> Author:     Yasuhiro Kimura <yasu@FreeBSD.org>
> AuthorDate: 2021-10-12 16:47:27 +0000
> Commit:     Yasuhiro Kimura <yasu@FreeBSD.org>
> CommitDate: 2021-11-26 00:53:36 +0000
> 
>     shells/zsh: Add BASE_ZSH option
>     
>     Add new option BASE_ZSH that makes zsh and rzsh also available as
>     /bin/zsh and /bin/rzsh.
>     
>     Under ports flamework everything is installed under /usr/local unless
>     custom prefix is used. And according to it zsh is installed as
>     /usr/local/bin/zsh. But on most Linux based OSes zsh is installed as
>     /bin/zsh. And it causes problem if user's account information is
>     shared between FreeBSD and Linux by using such tools as LDAP or NIS as
>     account information also includes absolute path of user's login shell.
>     To work around it I have created /bin/zsh as symbolic link referencing
>     /usr/local/bin/zsh and also edited /etc/shells to add /bin/zsh to it
>     every time I set up new FreeBSD system. But it's quite bothersome and
>     that is why I add new BASE_ZSH option.
>     
>     While I'm here,
>     
>     * Pet portclippy
>     * Re-format Makefile with portfmt
>     
>     PR:             259109
>     Proposed by:    Chris Hutchinson (more intuitive option name)
>     Approved by:    maintainer timeout (> 2 weeks)
> ---
>  shells/zsh/Makefile  | 80 ++++++++++++++++++++++++++++------------------------
>  shells/zsh/pkg-plist |  2 ++
>  2 files changed, 45 insertions(+), 37 deletions(-)

Please revert, sorry I should have seen and replied to this PR which I didn't.
We have been fighting for years to try to reduce the number of ports installing
things in the base system.


Best regards,
Bapt