Re: git: 46ce086c7130 - main - Mk/Uses: default version for nodejs
- In reply to: Po-Chuan Hsieh : "Re: git: 46ce086c7130 - main - Mk/Uses: default version for nodejs"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Mon, 22 Nov 2021 06:04:43 UTC
Am 21.11.2021 um 22:18 schrieb Po-Chuan Hsieh: > > Don't get me wrong. > Adding USES=nodejs is one thing. Changing the default nodejs is > another thing. > We need more work before changing the default. > For example, it is really weird to have 4 npm ports, www/npm and > www/npm-node{14,16,17}, now. > > My point is, you did this just because gitlab does not support node 17. > Even so, you should always find a less aggressive way to fix things. > Your first trial did break rubygem-rails60. > Your second trial which is unnecessary just affects lots of ports. > And it is not accepted/approved. > > Here's the patch [1] which does not have www/node in gitlab's > dependencies. > I'll commit it later. > > [1] https://people.FreeBSD.org/~sunpoet/patch/node.txt > <https://people.FreeBSD.org/~sunpoet/patch/node.txt> I don't get you wrong, but I do not understand why you would like to roll back something, where we received no bug report. To clean up the ports can be done, but I do not understand why you enforce the user, that they must use an unstable development version of node. Having now [npm,yarn]{-14,-16-17} will allow the full flexibility for the users to install whatever combination they like, without compiling anything (just use pkg). I'm very sure that this commit even fixed most of the problems for most users. Rolling back node to unstable development version will break node again for some users (it really depends what npm dependencies you use, but many of them are marked to be broken with node17). I think that Bradley should comment on this and I'm sure, if he has time again, he will. We emailed in private and told me that he wanted to have that done this already for years, but did not have time for this. Gruß Matthias -- "Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the universe trying to produce bigger and better idiots. So far, the universe is winning." -- Rich Cook