From nobody Wed Nov 17 03:53:29 2021 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 243B21889248; Wed, 17 Nov 2021 03:53:30 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Hv8DB0Lczz3nLV; Wed, 17 Nov 2021 03:53:30 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1637121210; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FZuH5OzmJMq0TrpKHNI/yvLW/rt0WGjGKAxal9Yjrx0=; b=YwilWmCSI/mJjjQ55JkCawsIce18gyu2jh2tCqXADOlNuyBkehBE+BTnMJ6guYP2/X9/b8 CHIHXbLpdGITmzJfoDePjA/MA2Wx6HhJJJQfe8dvxe4lyWRl84dSEifeWDWRSk5rSY7+KZ LMjnQ51+I0ZozLD1iJO+3Fkp3SYEtrlWcVqtgM0EFj85MIJsd0ziazWHQUGsAHdAk+BuFE Rcp+fIC0CEcgwsHxCz1bQ4lOYrofR0c8WkDiEQXkska4DzeBYsCWaQJlEs3QjWwYs4kJey /4R82vGOdI8mEPC53lymoBVKWgaHfx68t6z7rkT/knttNPi7oIObYFFmdgGozw== Received: by freefall.freebsd.org (Postfix, from userid 1033) id E7B2540A4; Wed, 17 Nov 2021 03:53:29 +0000 (UTC) Date: Wed, 17 Nov 2021 03:53:29 +0000 From: Alexey Dokuchaev To: Yasuhiro Kimura Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: bb8dbe1580ae - main - sysutils/lnav: Fix distinfo Message-ID: References: <202111170314.1AH3ETSV087319@gitrepo.freebsd.org> <20211117.124452.1254944101155682425.yasu@utahime.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211117.124452.1254944101155682425.yasu@utahime.org> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1637121210; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FZuH5OzmJMq0TrpKHNI/yvLW/rt0WGjGKAxal9Yjrx0=; b=vmmw1bdfn3XCXPgNJtT6q93A+gjRp7NGzKgco/YCduS3C42aJt3+8yV+Y55tCnT7cjNuiY 9rY+C1SsRPXVdes7OEYTeS9r73sQqpUt/Rf8acWeQpo3eMFCsIrkHszMKpxkTjPOdBU7J5 dnJhYaTFOzTVIai0w2K7JOwGfY3wTGuep5Kr9ciWFYZzCp1CMk+FYgE5RX2LBTjv+5RrQ5 XmuKbkj+fglHcCI6tSN/evhOQQhgeBxd4EJZCfpX30N/GeUOWT6TEh7kTVSCxfsZ2XYnmC 9zAdaIP32v3U/wlVhywFyNFKp/Vc4z2oAzmxS93ddG96Myl7FyvIssefHfWGNQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1637121210; a=rsa-sha256; cv=none; b=gkeiDnYXn1tD+Nl8DgiFYK+y66cJGhAUL6z1XRCMw7SN+mjLv19Jb7RrMty3LLGNGqAyHF 35Docw+qb3yoMIyRPNyd3f07hk+Kfrt07PAiqUZEhmuxKTAQke8YK+HLeJ7ls3SsofzM2p xiop11lN7B/637Or0hPe53aejpxP80Bya6RT+kJzaezTNqIvvrQOq0nxr5jgTl6syHf/iA K2EvdXcXhm/PgYnCIqYbvSiklE/BjxuS3PNW8xPLbHCqC8vyvNJtqWdZgVpFkUz6zGGc6/ L1/fxmcF9uj/j4Asexg+dVbgkH3caB6vWPeSllLSYwOGQBmJUKdNcxbAqW/P9A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Wed, Nov 17, 2021 at 12:44:52PM +0900, Yasuhiro Kimura wrote: > From: Alexey Dokuchaev > Subject: Re: git: bb8dbe1580ae - main - sysutils/lnav: Fix distinfo > Date: Wed, 17 Nov 2021 03:24:47 +0000 > > > I know you prefer DISTVERSION by default for some obscure reason, but > > changing just the knob spelling without actual version number is what > > we call gratuitous change and something we try to avoid as it clobbers > > the history, thus pessimizing code archaeology process, and decreases > > commit diff SNR. > > It's not just my personal preference. Section of 5.2.2 of Porter's > Handbook says as following. Yeah, I know, and I don't buy this reasoning, but that's not the point, the point is gratuitous changes and "fixing" what ain't broken. ./danfe