From nobody Wed Nov 10 14:22:03 2021 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id ED1B818496EB; Wed, 10 Nov 2021 14:23:04 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Received: from mail-yb1-xb36.google.com (mail-yb1-xb36.google.com [IPv6:2607:f8b0:4864:20::b36]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Hq6Wr59vGz3qSb; Wed, 10 Nov 2021 14:23:04 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Received: by mail-yb1-xb36.google.com with SMTP id e136so6840363ybc.4; Wed, 10 Nov 2021 06:23:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ngwxtHAW6pd5AaFTtqRwb5YdFaXhA2q8u1zuyy3k/MA=; b=hZ/+J3s2bNVVtCRZFMgFonqYitq7jz08s9bUNqLLmDMZaC5uoW5/kd82WT5x8D0sno Lpx364yrQyxdZNglDplRJbw3urhwyA0JGYZd/JK7GM8H/c/i1xN/FtuwQFteXWf9wPtm hv3AT25AKqxozPa/qX7IBY3Bp/87jv5nXm5AB6Q1QWlXk7Lv1/mGEudRQq9ni/cQlYsJ KqFXxbeGGewZoXlQbEEKQkXMDfzCmEqOCPJHbVfJeqYJFYFEWLfRTXKepm0aKR+HeCRz 2whdfbjy7c29kHU0S4aSGHmvAM/Qw9+crzyNxYA+lzaOD7hLp9RZUbOrSpVcvK4uLfPA pgcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ngwxtHAW6pd5AaFTtqRwb5YdFaXhA2q8u1zuyy3k/MA=; b=3KKjs2Ss6C0eqohO7hBCpFwAD24cFl2dgs+pwuI05e3TH8Kd12+gNdlwM6duuO9YIV pXoJ1FnXO1XSkINjaZPEqHGCLels3QcUP1xp7Q/f48kGWotuVUzuxDhBXgp/g+bMwKu7 9RG4uh3w7k3VycWdfqFXe7HLdfioaIUYn7OFzTFGCqO+e4/As27vEf/0erOCxDsx03gR caVh4uPBCwYXQmUR0lpRUWacZ9cn/kf5AVEO5K1Ro/ybzs1IruFHuhmJt2SQiw3TDGz6 b18+D6jfDsjQIDB6WO10PKX1deldMYHt/zOvgNscMJOeInLxBWAduZaVTwddwL1BJSAk 2vew== X-Gm-Message-State: AOAM533PaOuK64uiQkR+8JnLRgC9mkIq2n9Q26vGmlv/h5eVHyQE4x7k cwQKryBQ0C1q8xn1gpo3zDxPmmu87iR8HK1PIZGYU/uX X-Google-Smtp-Source: ABdhPJz4tw/kUXasji5BUI+y0N4cuBdst+TfzACYAdLubqR7FmnZCwQRXWcgrd8JHyE0wo2STZ2cIKPam4R+Nbe9O+8= X-Received: by 2002:a5b:d41:: with SMTP id f1mr1422300ybr.447.1636554183907; Wed, 10 Nov 2021 06:23:03 -0800 (PST) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202111101058.1AAAwkpv046598@gitrepo.freebsd.org> <20211110111807.godb2dxxsdjlv7wk@aniel.nours.eu> In-Reply-To: From: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= Date: Wed, 10 Nov 2021 15:22:03 +0100 Message-ID: Subject: Re: git: b68bef1f6425 - main - x11-wm/kwinft: unbreak build after 5d998836b36f To: Jan Beich Cc: Baptiste Daroussin , "ports-committers@FreeBSD.org" , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4Hq6Wr59vGz3qSb X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On Wed, Nov 10, 2021 at 1:41 PM Jan Beich wrote: > > Baptiste Daroussin writes: > > > On Wed, Nov 10, 2021 at 10:58:46AM +0000, Jan Beich wrote: > > > >> The branch main has been updated by jbeich: > >> > >> URL: https://cgit.FreeBSD.org/ports/commit/?id=b68bef1f6425117cd0d0d95626178db4c4fb3073 > >> > >> commit b68bef1f6425117cd0d0d95626178db4c4fb3073 > >> Author: Jan Beich > >> AuthorDate: 2021-11-10 09:24:08 +0000 > >> Commit: Jan Beich > >> CommitDate: 2021-11-10 10:58:09 +0000 > >> > >> x11-wm/kwinft: unbreak build after 5d998836b36f > >> > >> input/filters/window_selector.cpp:19:10: fatal error: 'linux/input.h' file not found > >> #include > >> ^~~~~~~~~~~~~~~ > >> > >> Pointy hat to: manu > > > > To be honnest I am puzzled about this pointy hat, while manu should have tested the > > reverse dependencies of mtdev to make sure noone wrongly took its run > > dependencies as granted as its own build dependencies and fix them upfront, > > On the otherside, all the ports should be explicit about ALL their direct build > > dependencies, and not expect another port to provide them. > > According to FreshPorts devel/libmtdev has 3 consumers: > > - x11/libinput has 22 consumers > - x11-drivers/xf86-input-evdev has 1 consumer > - x11-toolkits/qt5-gui has 1033 consumers > > Testing all qt5-gui consumers locally is challenging. Some of those may > have consumers of their own. > > > Meaning the said ports were buggy in the first place. > > It was unexpected/disrupting. And without exp-run it's unknown how many > more ports may need to be fixed (I only regularly test mine). Besides, > destabilizing the tree too much degrades the quality of exp-runs that > maybe ongoing in parallel for unrelated changes. > > > > > This is one of the reason the Pointy hat culture has been removed from the ports > > land in general in favor or at best only accepting self pointy hatting. > > > > So as a community if we could avoid finger pointing at others. > > Agree, pointy hats can discourage new contributors, drive away existing > ones due to exhausting negativity or attract trolls. This was mostly a > silly/petty attempt to grab (mainly manu's) attention. In order to do that, we could use the Fixed: field in the commit template. After all, that is what it is for. Extra bonus if there is a hook that sends a private mail to the committer whose commit is being fixed. Just my 2 cents.