From nobody Mon Nov 01 18:44:31 2021 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 1A43E1821460; Mon, 1 Nov 2021 18:44:36 +0000 (UTC) (envelope-from tobias.kortkamp@gmail.com) Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Hjhll0pwzz3Hf9; Mon, 1 Nov 2021 18:44:35 +0000 (UTC) (envelope-from tobias.kortkamp@gmail.com) Received: by mail-ed1-f50.google.com with SMTP id g10so67173767edj.1; Mon, 01 Nov 2021 11:44:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BSO+CXxoaLOo77Lv+1zMiI31dZbBi3+ffEEmFV7NiY8=; b=OQ1cghr8IMf2CXZ+lU7FQCV2RFTO2kAQ3cWc1b2kEQD3Q8xX13V4plkLZyig9JHx4N oDDaTtM7f5+h2wa4kNGjGN2a7cSNEn/9EdBVg4wny2Z1/QS4wony0sDipndZuQ2jQU7H H/MLo8NdPYdU5/C5Mlp/GDY/+IlNwJodPV1jMx0ZwVUBJKtnyWcwreT8H7XmqseEiyVz NV+V/Se6yZ26A0jLFWMj1ASag9UJr4Cy3GHfl/JVhCUxiEP3s7Y+EeOiAIJhAEKdTomj w//LXkxEM3OlI0ZVGj+KiS9UmeWK/sDQD+Sa7R4mO+IvR8HyizZYrPspR47nkMoLm14s rTmA== X-Gm-Message-State: AOAM533tHsmwPrvypmUI2KsqM366vB8Z3EvncHV3nH+mI02FVxNx/mqT 545wo2/EFozOEXf2hRNnvOEVzqFA5uw= X-Google-Smtp-Source: ABdhPJwOVsMSKkO1iv8UBWTPF//BttWY2OBMA0coUome4eHa+iktJNqb0UzB3ob1DueOQHUZWwFm8Q== X-Received: by 2002:a17:906:a84a:: with SMTP id dx10mr19326043ejb.569.1635792273774; Mon, 01 Nov 2021 11:44:33 -0700 (PDT) Received: from loki.kortkamp.xyz (p200300e49706cf0002155dfffe002610.dip0.t-ipconnect.de. [2003:e4:9706:cf00:215:5dff:fe00:2610]) by smtp.gmail.com with ESMTPSA id hp13sm7434676ejc.66.2021.11.01.11.44.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Nov 2021 11:44:33 -0700 (PDT) Date: Mon, 1 Nov 2021 19:44:31 +0100 From: Tobias Kortkamp To: Yasuhiro Kimura Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: d356121270d7 - main - mail/postfix{,-ldap-sasl,-sasl}: Flavorize Message-ID: References: <202110280007.19S07MMW076891@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="g5ZxA2BwedQK2K0v" Content-Disposition: inline In-Reply-To: <202110280007.19S07MMW076891@gitrepo.freebsd.org> X-Rspamd-Queue-Id: 4Hjhll0pwzz3Hf9 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of tobiaskortkamp@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=tobiaskortkamp@gmail.com X-Spamd-Result: default: False [-5.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_NEQ_ENVFROM(0.00)[tobik@freebsd.org,tobiaskortkamp@gmail.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; DMARC_NA(0.00)[freebsd.org]; NEURAL_HAM_LONG(-1.00)[-1.000]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCVD_IN_DNSWL_NONE(0.00)[209.85.208.50:from]; SIGNED_PGP(-2.00)[]; FORGED_SENDER(0.30)[tobik@freebsd.org,tobiaskortkamp@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.208.50:from]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; MIME_TRACE(0.00)[0:+,1:+,2:~]; TAGGED_FROM(0.00)[] X-ThisMailContainsUnwantedMimeParts: N --g5ZxA2BwedQK2K0v Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 28, 2021 at 12:07:22AM +0000, Yasuhiro Kimura wrote: > -POSTFIX_CCARGS+=3D -DDEF_CONFIG_DIR=3D\\\"${ETCDIR}\\\" \ > - -DDEF_DAEMON_DIR=3D\\\"${DAEMONDIR}\\\" \ > - -DDEF_META_DIR=3D\\\"${META_DIRECTORY}\\\" \ > - -DDEF_COMMAND_DIR=3D\\\"${PREFIX}/sbin\\\" \ > - -DDEF_SENDMAIL_PATH=3D\\\"${PREFIX}/sbin/sendmail\\\" \ > - -DDEF_NEWALIAS_PATH=3D\\\"${PREFIX}/bin/newaliases\\\" \ > - -DDEF_MAILQ_PATH=3D\\\"${PREFIX}/bin/mailq\\\" \ > - -DDEF_MANPAGE_DIR=3D\\\"${MANPREFIX}/man\\\" \ > - -DDEF_README_DIR=3D\\\"${READMEDIR}\\\" \ > - -DDEF_HTML_DIR=3D\\\"${READMEDIR}\\\" \ > - -DDEF_QUEUE_DIR=3D\\\"/var/spool/postfix\\\" \ > - -DDEF_DATA_DIR=3D\\\"/var/db/postfix\\\" \ > - -DDEF_MAIL_OWNER=3D\\\"postfix\\\" \ > - -DDEF_SGID_GROUP=3D\\\"maildrop\\\" \ > - -Wmissing-prototypes -Wformat -Wno-comment > +POSTFIX_CCARGS+=3D -DDEF_CONFIG_DIR=3D\\\"${ETCDIR}\\\" -DDEF_DAEMON_DIR= =3D\\\"${DAEMONDIR}\\\" -DDEF_META_DIR=3D\\\"${META_DIRECTORY}\\\" -DDEF_CO= MMAND_DIR=3D\\\"${PREFIX}/sbin\\\" -DDEF_SENDMAIL_PATH=3D\\\"${PREFIX}/sbin= /sendmail\\\" -DDEF_NEWALIAS_PATH=3D\\\"${PREFIX}/bin/newaliases\\\" -DDEF_= MAILQ_PATH=3D\\\"${PREFIX}/bin/mailq\\\" -DDEF_MANPAGE_DIR=3D\\\"${MANPREFI= X}/man\\\" -DDEF_README_DIR=3D\\\"${READMEDIR}\\\" -DDEF_HTML_DIR=3D\\\"${R= EADMEDIR}\\\" -DDEF_QUEUE_DIR=3D\\\"/var/spool/postfix\\\" -DDEF_DATA_DIR= =3D\\\"/var/db/postfix\\\" -DDEF_MAIL_OWNER=3D\\\"postfix\\\" -DDEF_SGID_GR= OUP=3D\\\"maildrop\\\" -Wmissing-prototypes -Wformat -Wno-comment Hi, this is caused by a tokenizer bug in portfmt where it treated the entire thing as one word. It is not ok for portfmt to format POSTFIX_CCARGS like that. I fixed it in [0]. Sorry, I saw it in the review earlier but forgot to comment on it. Please report stuff like this to me on GitHub [1] or on Bugzilla. Thanks! [0] https://github.com/t6/portfmt/commit/001ba6fa4b0f1f5b5e4dfd913564dc5641= 8d0a36 [1] https://github.com/t6/portfmt/issues=20 --g5ZxA2BwedQK2K0v Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEElXvTEJc6ePgdQuobpPCftzzFH2EFAmGANY1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk1 N0JEMzEwOTczQTc4RjgxRDQyRUExQkE0RjA5RkI3M0NDNTFGNjEACgkQpPCftzzF H2FzbwgAn0ugCUPf38EgNR3q07vPTZmFb/WJFmnAWljwrfsA+e4vIyNpl4oawRgi e4jBYonwU6plPJ8s7U8fTG2jFwkZMvdXdvbE1ZdjIPA7X3PGisg8RzfOqw4jRdTg +t58u/VfpcxNtlYCTMr9EgdEDiKl66tNZWeQAvR8cF3yptc3wCN51iNVWPDvF7E9 uXptlDtVEcoGj70AtHmygVXSWTjkL3KsHgLHNFvx3FSFRFDI43527TqS0EOgenck SYq3JJ4yI8VLJetf0naBsUiEm4/kfn+US2csAHtclHQLdUNGH2auCgIB/lImFoee 6pdZWa9gxAcREmOJzt0bHKv9rpwppA== =LZQu -----END PGP SIGNATURE----- --g5ZxA2BwedQK2K0v--