From nobody Thu Dec 30 14:36:44 2021 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 825631912F51 for ; Thu, 30 Dec 2021 14:37:02 +0000 (UTC) (envelope-from ericturgeon.bsd@gmail.com) Received: from mail-vk1-xa2e.google.com (mail-vk1-xa2e.google.com [IPv6:2607:f8b0:4864:20::a2e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JPrSs56xnz3l2h; Thu, 30 Dec 2021 14:37:01 +0000 (UTC) (envelope-from ericturgeon.bsd@gmail.com) Received: by mail-vk1-xa2e.google.com with SMTP id 70so13791223vkx.7; Thu, 30 Dec 2021 06:37:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dqbJNF9pT/oSOnKRg6pm2Bcql6C06nUs3QsuEJwFeAg=; b=mDt3uBC6Qacxmw7NOdy8juF9idqmFV1xVERQo13idA5F9j/Pa7oqmMHBxkvVahMISy BExO+33CEVoHUCVaWTMSYzUl2DPgb63eygPwiqlHlb3xsthARtLmqlkilSu1dr9KYX8E QbBwbC5Y3UILr8j07K4xxQiWncFLkY9S521f3bByZquMe6JKCbJ0k7210u4n1PL5mzs2 h6cmIvS2d3pZ/H9m+XCUpjovFKU908zhR7mNV65PLIAxj8p42/H1e6a6JvZtwc1vALDw gxwMqX3MHA4JbzGIXsp51s29s4EyB0Dw3DpPbHG21wxxS/NLPh32t2UD7WIjEwbGaWAu urPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dqbJNF9pT/oSOnKRg6pm2Bcql6C06nUs3QsuEJwFeAg=; b=OXtEaSTZggPEUSjGzF9DVU/j1t6Xp3caPonLFbapCCMp15PFOB0kE4TLIFmgo50Hyl +7escykVeBcKhUTDAXKC8/N6gsHrJQwq7tphugrlIJRx9WmIXmw1thybDsAsv+q1uI/m IAKwHrOMfMK7FE5ZfsxRd8X/GB8wP/hyX/2oMbPMuJW8R4AVo0XhyO7sG72MjGhQSsUX TwaFTzMHxtcistamCS3c3DOlfm7r0jKWL6TMkbLjPSnAfufRs6XHh3jaHnXfJSSDipLd KyUIu0qPPUwHzJvznC0VTC8Dnxifeh75BidDcF+aqUbSBAdzklZ7MgtlAQwx+y5RUS1m hjlQ== X-Gm-Message-State: AOAM531fzDRJFE65dVb80u73DRWaYNBpprzN2ZrRDbXs37QDsh//iYhM XJGVzvLrKwLfGO0f23ewvTzAZ7y1u6+dSd4asFnotYeIMPs= X-Google-Smtp-Source: ABdhPJxlHyG+oCJC2vG7t/F7h9nKDJUv8DlpxXHA5ImulHabaYgYS6XW1G36btm53MccZgTFIDkjXkQJ37gGVPOI43o= X-Received: by 2002:a05:6122:8c6:: with SMTP id 6mr9678478vkg.33.1640875014991; Thu, 30 Dec 2021 06:36:54 -0800 (PST) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <20211230110857.1c0ac0e19e8206cb64a040d7@dec.sakura.ne.jp> <202112300342.1BU3gPt9003879@slippy.cwsent.com> In-Reply-To: <202112300342.1BU3gPt9003879@slippy.cwsent.com> From: Eric Turgeon Date: Thu, 30 Dec 2021 10:36:44 -0400 Message-ID: Subject: Re: git: f3caf742108b - main - x11/mate-screensaver: Fix PAM build To: Cy Schubert Cc: Tomoaki AOKI , dev-commits-ports-main@freebsd.org, Cy Schubert Content-Type: multipart/alternative; boundary="00000000000063b43405d45dfc6d" X-Rspamd-Queue-Id: 4JPrSs56xnz3l2h X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20210112 header.b=mDt3uBC6; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of ericturgeonbsd@gmail.com designates 2607:f8b0:4864:20::a2e as permitted sender) smtp.mailfrom=ericturgeonbsd@gmail.com X-Spamd-Result: default: False [-0.36 / 15.00]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20210112]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FREEMAIL_FROM(0.00)[gmail.com]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; NEURAL_HAM_LONG(-1.00)[-0.999]; TO_DN_SOME(0.00)[]; NEURAL_SPAM_MEDIUM(0.67)[0.665]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MID_RHS_MATCH_FROMTLD(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::a2e:from]; NEURAL_SPAM_SHORT(0.98)[0.978]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-Spam: Yes X-ThisMailContainsUnwantedMimeParts: N --00000000000063b43405d45dfc6d Content-Type: text/plain; charset="UTF-8" Do we have an equivalent of security/_pam_macros.h? *Eric Turgeon* On Wed, Dec 29, 2021 at 11:42 PM Cy Schubert wrote: > This commit only fixed a compile time error, include file > security/_pam_macros.h not found (discovered by my poudriere build). > security/_pam_macros is an include file found only on some distros of > Linux, a Linuxism. Try it without PAM enabled; the file not found error > may > just be the beginning of a multitude of PAM issues. > > I'll try to look at it over the next couple days. > > > -- > Cheers, > Cy Schubert > FreeBSD UNIX: Web: https://FreeBSD.org > NTP: Web: https://nwtime.org > > The need of the many outweighs the greed of the few. > > > In message <20211230110857.1c0ac0e19e8206cb64a040d7@dec.sakura.ne.jp>, > Tomoaki > AOKI writes: > > Hi. > > Wondered whih commit to comment but decided to latest. > > mate-screensaver no longer opens login panel after upgrading from > > 1.26.0 to 1.26.1. > > > > Created Bug 260811 [1]. > > > > [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=260811 > > > > > > > The branch main has been updated by cy: > > > > > > URL: > > > https://cgit.FreeBSD.org/ports/commit/?id=f3caf742108bb552724d4c4dae74b28ea26 > > 6a6a3 > > > > > > commit f3caf742108bb552724d4c4dae74b28ea266a6a3 > > > Author: Cy Schubert > > > AuthorDate: 2021-12-29 03:12:39 +0000 > > > Commit: Cy Schubert > > > CommitDate: 2021-12-29 03:12:39 +0000 > > > > > > x11/mate-screensaver: Fix PAM build > > > > > > Fix build when PAM enabled; is a Linuxism. > > > --- > > > x11/mate-screensaver/files/patch-helper_pam-helper.c | 10 ++++++++++ > > > 1 file changed, 10 insertions(+) > > > > > > diff --git a/x11/mate-screensaver/files/patch-helper_pam-helper.c > > b/x11/mate-screensaver/files/patch-helper_pam-helper.c > > > new file mode 100644 > > > index 000000000000..605141fb0e54 > > > --- /dev/null > > > +++ b/x11/mate-screensaver/files/patch-helper_pam-helper.c > > > _at__at_ -0,0 +1,10 _at__at_ > > > +--- helper/pam-helper.c.orig 2021-11-15 14:28:47.000000000 -0800 > > > ++++ helper/pam-helper.c 2021-12-28 19:09:39.501645000 -0800 > > > +_at__at_ -33,7 +33,6 _at__at_ > > > + */ > > > + > > > + #include > > > +-#include > > > + > > > + #include > > > + #include > > > > -- > > Tomoaki AOKI > > > --00000000000063b43405d45dfc6d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Do we have an equivalent of security/_pam_macros.h?

Eric Turgeon


On Wed, Dec 29, 2021= at 11:42 PM Cy Schubert <C= y.Schubert@cschubert.com> wrote:
This commit only fixed a compile time error, includ= e file
security/_pam_macros.h not found (discovered by my poudriere build).
security/_pam_macros is an include file found only on some distros of
Linux, a Linuxism. Try it without PAM enabled; the file not found error may=
just be the beginning of a multitude of PAM issues.

I'll try to look at it over the next couple days.


--
Cheers,
Cy Schubert <Cy.Schubert@cschubert.com>
FreeBSD UNIX:=C2=A0 <cy@FreeBSD.org>=C2=A0 =C2=A0Web:=C2=A0 https://FreeB= SD.org
NTP:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<cy@nwtime.org>=C2=A0 =C2=A0 Web:=C2=A0 https://nwt= ime.org

=C2=A0 =C2=A0 =C2=A0 =C2=A0 The need of the many outweighs the greed of the= few.


In message <20211230110857.1c0ac0e19e8206cb64a040d7@d= ec.sakura.ne.jp>,
Tomoaki
AOKI writes:
> Hi.
> Wondered whih commit to comment but decided to latest.
> mate-screensaver no longer opens login panel after upgrading from
> 1.26.0 to 1.26.1.
>
> Created Bug 260811 [1].
>
> [1] https://bugs.freebsd.org/bugzilla= /show_bug.cgi?id=3D260811
>
>
> > The branch main has been updated by cy:
> >
> > URL:
> https://cgit.Fre= eBSD.org/ports/commit/?id=3Df3caf742108bb552724d4c4dae74b28ea26
> 6a6a3
> >
> > commit f3caf742108bb552724d4c4dae74b28ea266a6a3
> > Author:=C2=A0 =C2=A0 =C2=A0Cy Schubert <cy_at_FreeBSD.org><= br> > > AuthorDate: 2021-12-29 03:12:39 +0000
> > Commit:=C2=A0 =C2=A0 =C2=A0Cy Schubert <cy_at_FreeBSD.org><= br> > > CommitDate: 2021-12-29 03:12:39 +0000
> >
> >=C2=A0 =C2=A0 =C2=A0x11/mate-screensaver: Fix PAM build
> >=C2=A0 =C2=A0 =C2=A0
> >=C2=A0 =C2=A0 =C2=A0Fix build when PAM enabled; <security/_pam_= macros.h> is a Linuxism.
> > ---
> >=C2=A0 x11/mate-screensaver/files/patch-helper_pam-helper.c | 10 += +++++++++
> >=C2=A0 1 file changed, 10 insertions(+)
> >
> > diff --git a/x11/mate-screensaver/files/patch-helper_pam-helper.c=
> b/x11/mate-screensaver/files/patch-helper_pam-helper.c
> > new file mode 100644
> > index 000000000000..605141fb0e54
> > --- /dev/null
> > +++ b/x11/mate-screensaver/files/patch-helper_pam-helper.c
> > _at__at_ -0,0 +1,10 _at__at_
> > +--- helper/pam-helper.c.orig=C2=A0 =C2=A0 =C2=A0 =C2=A02021-11-1= 5 14:28:47.000000000 -0800
> > ++++ helper/pam-helper.c=C2=A0 =C2=A0 2021-12-28 19:09:39.5016450= 00 -0800
> > +_at__at_ -33,7 +33,6 _at__at_
> > +=C2=A0 */
> > +
> > + #include <security/pam_appl.h>
> > +-#include <security/_pam_macros.h>
> > +
> > + #include <sys/types.h>
> > + #include <stdarg.h>
>
> --
> Tomoaki AOKI=C2=A0 =C2=A0 <junchoon@dec.sakura.ne.jp>


--00000000000063b43405d45dfc6d--