From nobody Wed Dec 15 12:04:38 2021 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 239D518F5FCC; Wed, 15 Dec 2021 12:06:13 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from sprint-2.amdmi3.ru (sprint-2.amdmi3.ru [IPv6:2a0a:2b41:94:cb5e::]) by mx1.freebsd.org (Postfix) with ESMTP id 4JDYqm6xVpz3KR9; Wed, 15 Dec 2021 12:06:12 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from amdmi3.ru (localhost [IPv6:::1]) by sprint-2.amdmi3.ru (Postfix) with SMTP id D2ADD1889CF; Wed, 15 Dec 2021 15:06:03 +0300 (MSK) Received: by amdmi3.ru (nbSMTP-1.00) for uid 1000 amdmi3@amdmi3.ru; Wed, 15 Dec 2021 15:06:03 +0300 (MSK) Date: Wed, 15 Dec 2021 15:04:38 +0300 From: Dmitry Marakasov To: "Tobias C. Berner" Cc: ports-committers , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, Baptiste Daroussin Subject: Re: git: 45526ecbeec3 - main - framework: Add new USES 'magick' for graphics/ImageMagick* Message-ID: References: <202112111351.1BBDp91x095991@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4JDYqm6xVpz3KR9 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N * Tobias C. Berner (tcberner@freebsd.org) wrote: > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=45526ecbeec33dbb87f0b678d4c04988aab9b657 > > > > > > commit 45526ecbeec33dbb87f0b678d4c04988aab9b657 > > > Author: Tobias C. Berner > > > AuthorDate: 2021-10-30 18:08:16 +0000 > > > Commit: Tobias C. Berner > > > CommitDate: 2021-12-11 13:50:53 +0000 > > > > > > framework: Add new USES 'magick' for graphics/ImageMagick* > > > > It's great that someone finally decided to unify imagemagick > > version handling, however as it is now it's a huge pessimization > > and I'm rolling it back for my ports. > > > > The problem is that ports which depend just on e.g. convert utility > > built with any version and flavor of imagemagick before, but now these > > require specific version and cause conflicts. > > > > Please rollback all cases which depend on utilities, e.g. > > > > {BUILD,RUN}_DEPENDS={convert,montage,identify,...}:graphics/ImageMagick* > > You can already depend on any version (i.e. the default) by not > specifying the version -- ports that explicitly only require the > binaries should be using > USES=magick:run resp USES=magick:build,run > So they pull in what the user specified as IMAGEMAGIC_DEFAULT-version. The default version is not an "any" version, it's a specific conflicting version, so no, you cannot depend on any version. As a result, after installing something which requires magick:6 you cannot install something which requires magick:build. > > or provide a way to depend on *any* version of imagemagick in the > > framework. > > > > > A new USES has been added to depend on ImageMagick. > > > > > > USES=magick > > > > > > adds a LIB_DEPENDS on graphics/ImageMagick${IMAGEMAGICK_DEFAULT}. > > > > > > If a specific version is required, use for example > > > > > > USES=magick:6 resp. USES=magick:7 > > > > > > If only a build, run or test is required, use for example > > > > > > USES=magick:build resp. USES=magick:6,build,test > > > > > > If a dependency on the nox11 flavor is required, use for example > > > > > > USES=magick:nox11 resp. USES=magick:7,nox11,run,test > > > > > > See magick.mk for more details on the available flags. > > > > > > The tree has been completely converted to make use of this. > > > > > > Approved by: bapt > > > Differential Revision: https://reviews.freebsd.org/D32754 > > > > -- > > Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D > > amdmi3@amdmi3.ru ..: https://github.com/AMDmi3 https://amdmi3.ru > > > -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: https://github.com/AMDmi3 https://amdmi3.ru