From nobody Wed Dec 15 11:51:14 2021 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id F2A9918F32BB; Wed, 15 Dec 2021 11:51:33 +0000 (UTC) (envelope-from tcberner@gmail.com) Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JDYVs6GQYz3Hf1; Wed, 15 Dec 2021 11:51:33 +0000 (UTC) (envelope-from tcberner@gmail.com) Received: by mail-ed1-f49.google.com with SMTP id x15so74713277edv.1; Wed, 15 Dec 2021 03:51:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8svqMictYH2sBzjS3YpOd/EXUFbI0r1+xPw48J4YURs=; b=1MsQtnkRf1rryGsY+qO263DztxqoZGXDePlh3DBzw9pd+vk0NUDJu7jYHpFTvVzYd3 OOvYeSEbUQjLlLnzKY0y3WnmdgADwqVHzxZhbYT7cdjEpE1B1csXUGjno9GsB/3Egh6c 3AwjVlxStk29CF6+n5cykRrsTVz9z17LOTgfmUE38VkjHzL0+g8ksGIfsb6xejUKRJyx Y1R4KrKgW1B4+iB4KWRk55dVBPjgya80bJskRB1aMfpwLsay5rElLEMoDcnEWU4/zZFs MXnO6jyh3VxAaI9Gmog91VWVS5X6az16n/oPv6ofPfJUcXBTDFddgfNmqYVLoV7yqK5U uVrw== X-Gm-Message-State: AOAM531pgCU45JGx9lc3GEikjKjU6LiKR5qjqkaX8zhs2y0evdIMLAPf XIiY2hE4F11wrgZ0evB3xfinjE2qg38bTw== X-Google-Smtp-Source: ABdhPJzTQ1/knqAh1l2ucBxj6CC/wjJ8Q4Yk6a+UXIUdQisrHcQAO/6NJfG4dBbQByS3QaGYksxMdQ== X-Received: by 2002:a17:907:6da3:: with SMTP id sb35mr10859480ejc.692.1639569087144; Wed, 15 Dec 2021 03:51:27 -0800 (PST) Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com. [209.85.208.48]) by smtp.gmail.com with ESMTPSA id oz31sm648292ejc.35.2021.12.15.03.51.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Dec 2021 03:51:26 -0800 (PST) Received: by mail-ed1-f48.google.com with SMTP id b7so14538967edd.6; Wed, 15 Dec 2021 03:51:26 -0800 (PST) X-Received: by 2002:a17:906:4792:: with SMTP id cw18mr10662362ejc.168.1639569086033; Wed, 15 Dec 2021 03:51:26 -0800 (PST) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202112111351.1BBDp91x095991@gitrepo.freebsd.org> In-Reply-To: From: "Tobias C. Berner" Date: Wed, 15 Dec 2021 12:51:14 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 45526ecbeec3 - main - framework: Add new USES 'magick' for graphics/ImageMagick* To: Dmitry Marakasov Cc: "Tobias C. Berner" , ports-committers , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, Baptiste Daroussin Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4JDYVs6GQYz3Hf1 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N Moin moin On Wed, 15 Dec 2021 at 12:37, Dmitry Marakasov wrote: > > * Tobias C. Berner (tcberner@FreeBSD.org) wrote: > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=45526ecbeec33dbb87f0b678d4c04988aab9b657 > > > > commit 45526ecbeec33dbb87f0b678d4c04988aab9b657 > > Author: Tobias C. Berner > > AuthorDate: 2021-10-30 18:08:16 +0000 > > Commit: Tobias C. Berner > > CommitDate: 2021-12-11 13:50:53 +0000 > > > > framework: Add new USES 'magick' for graphics/ImageMagick* > > It's great that someone finally decided to unify imagemagick > version handling, however as it is now it's a huge pessimization > and I'm rolling it back for my ports. > > The problem is that ports which depend just on e.g. convert utility > built with any version and flavor of imagemagick before, but now these > require specific version and cause conflicts. > > Please rollback all cases which depend on utilities, e.g. > > {BUILD,RUN}_DEPENDS={convert,montage,identify,...}:graphics/ImageMagick* You can already depend on any version (i.e. the default) by not specifying the version -- ports that explicitly only require the binaries should be using USES=magick:run resp USES=magick:build,run So they pull in what the user specified as IMAGEMAGIC_DEFAULT-version. mfg Tobias > > or provide a way to depend on *any* version of imagemagick in the > framework. > > > A new USES has been added to depend on ImageMagick. > > > > USES=magick > > > > adds a LIB_DEPENDS on graphics/ImageMagick${IMAGEMAGICK_DEFAULT}. > > > > If a specific version is required, use for example > > > > USES=magick:6 resp. USES=magick:7 > > > > If only a build, run or test is required, use for example > > > > USES=magick:build resp. USES=magick:6,build,test > > > > If a dependency on the nox11 flavor is required, use for example > > > > USES=magick:nox11 resp. USES=magick:7,nox11,run,test > > > > See magick.mk for more details on the available flags. > > > > The tree has been completely converted to make use of this. > > > > Approved by: bapt > > Differential Revision: https://reviews.freebsd.org/D32754 > > -- > Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D > amdmi3@amdmi3.ru ..: https://github.com/AMDmi3 https://amdmi3.ru >