From nobody Wed Dec 15 04:18:07 2021 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id AB0B418DFCE9; Wed, 15 Dec 2021 04:18:07 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JDMRg4WyXz3FCK; Wed, 15 Dec 2021 04:18:07 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1639541887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hriTBHvjvGnRBjyg0EwhsRbXxrIq6ybFIVfwv1GihbM=; b=TIdeeJEq6zr1ga4PFq7sqHeAb41/KHy4rKF1Obh0E0Nr3X2SZPKAyzdH1WsH7ys0gJQ3mg MKT9GvW/RznQdJr0ZaDG35Kbkk1tj28zCqPfl7PIvI5gVbjBKUq1DCX/v6CNxHhI7zFs53 MviG3+MUpTD43rDEMV/FUdsnbLOdpjG4LB9ZGdy0rqkgR4aclkpziReNj59U0iKdnqtT1G RTGSYf02pKNakncTyhXKa8KCJ6wHg3tvr75ElpzLaPc7hl6e+xo5XhkIzHDczbwazBC+NJ LelxPqXDfZsdj96wnYLRHR2k/Qx/OYMnmA3TZyvwOSSBDr0x8lKPcbsstnV+Xw== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 7BC1F3B3D; Wed, 15 Dec 2021 04:18:07 +0000 (UTC) Date: Wed, 15 Dec 2021 04:18:07 +0000 From: Alexey Dokuchaev To: John Hixson Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: cc1054f95110 - main - sysutils/oc: Update to use personal fork of oc Message-ID: References: <202112150129.1BF1TiVb091373@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1639541887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hriTBHvjvGnRBjyg0EwhsRbXxrIq6ybFIVfwv1GihbM=; b=un/ynuevTR5D86hFZrfwWXH05TAxusf6bmiOE3y6QX5uyY0MCg6QcHtZFVmkh7YgYpq41W pqbA33lF9MVBdLMUXJeUNidiA3UaOBOy5uvIfa0N5cFdIsCDVxyOBksOSuPJnZq7sqbMfY JvJo4a/HgkPOjNefdwBmDOSb2qiBJkQF7564XyPZwnAXUMaJFp+UNQL5gPtX9xgtuds+uC 4pIo8uuvfbaRYNhaHyzq7FTsN9tpA9SwCSHD/6kyvm/i/ScO3ygs+pkWkX7gMzs6gZ/27J PW6D7eVOFu0G4YVQ+vnsArZCrr2sqH64Nppe9Aov65MgLrGRhTJ09HOa+kizEw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1639541887; a=rsa-sha256; cv=none; b=DJJV8kfsMq7PwEinKcyFAFnGA9tbJnTnmuk0Wl8qZv/OQIqX2F1/ZlIwHKoxivF4f/OyXw PJE5ycjyzFRp3A6Xdy36UjDDqKyR6ukff+jwdjBum/1bNLTqqnRT14PSNWbL7/ZfL9jYKU uHe3YlOvSB1MqLPFj2Mmw8LYSKWz8DQOZcM+wqrQsKMfYa6GqacTsu1iV3WIyBCeRFucSY 2RPKQFCdMG8e7Q2LiVFPbVSigTnqUDTaVBgHf+qn4nLqyGRBDbtQXv6GJMlSUs5JQFW1za ahskFK8LSXFqoE8f98E0NusnjTRrYHeVc06l2Af/ZBhYB0o6EGvGc8PDiD6LOw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Tue, Dec 14, 2021 at 08:06:04PM -0800, John Hixson wrote: > On Wed, Dec 15, 2021 at 02:19:38AM +0000, Alexey Dokuchaev wrote: > > On Wed, Dec 15, 2021 at 01:29:44AM +0000, John Hixson wrote: > > > commit cc1054f951104c0404446bc0787de6e3399c4a66 > > > > > > sysutils/oc: Update to use personal fork of oc > > > > Why? Please don't just translate the diff into English, you have to > > explain the changes, esp. dubious ones like this. > > My apologies. I will write better commit messages. Fetching keeps > breaking because the downloadable tarball keeps changing. I beleive it's > from forced pushes and commits changing. I can track it with my own fork > so that it doesn't keep changing and breaking. Is this practice frowned > upon? No, given the explanation it's okay. Yes, please write elaborate commit logs, what might be obvious to you, as an author, is not necessarily so for a random reader. Changing upsream from official to something else would certainly raise a few eyebrows. ./danfe