Re: git: b8c4bfe660b3 - main - sysutils/reptyr: Address LLVM 13 build failure

In message <YagxPMhGLs+rFO5A@FreeBSD.org>, Alexey Dokuchaev writes:
> On Thu, Dec 02, 2021 at 12:05:46PM +1100, Kubilay Kocak wrote:
> > On 2/12/2021 11:54 am, Cy Schubert wrote:
> > > commit b8c4bfe660b373862165a58514f270a51e77e147
> > > 
> > >   sysutils/reptyr: Address LLVM 13 build failure
> > > ...
> > >   2 errors generated.
> > 
> > Ports usually shouldn't use -Werror and people are strongly encouraged
> > to add -Wno-error
>
> On the other hand, every project really should enable -Werror so the
> compiler catches as much as it can for you.  Having it enabled during
> development is a must, having it enabled in releases is arguable as
> it might bring extra burden to maintainer, but it does help to catch
> bugs in the environment original developer has no access to, so no,
> we don't strongly encourage -Wno-error when specific warnings can be
> scoped as it helps to catch other warnings in the future.  Now they
> will likely went unnoticed, ergo unreported and unfixed.

Then it behooves port maintainers to upstream patches whenever possible.

This has been fixed using a proper patch and a pull request has been 
submitted to our upstream. I should have done this from the get-go.


-- 
Cheers,
Cy Schubert <Cy.Schubert@cschubert.com>
FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  https://FreeBSD.org
NTP:           <cy@nwtime.org>    Web:  https://nwtime.org

	The need of the many outweighs the greed of the few.