From nobody Thu Dec 02 02:36:44 2021 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 7689718AFAD7; Thu, 2 Dec 2021 02:36:44 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4J4Kph2wwDz4qqy; Thu, 2 Dec 2021 02:36:44 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1638412604; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iwfBeWFYlnPUmdPckT6gP9CBHqZdUwg9Mgi8MdeA3Vs=; b=ZY5LjR7vVPCUJH3PtMe1anzjFbYnAXrH+pxza3yIgCNfU83WsjWX90kvC3/zqR43HetVjo TY6Rm6rg+Pirh+Tflclk3j7VahQW1eHCs9CLw9UDHrF521nwV9w4W0pPvysqqNj03mqK71 zFC0zG47HXroFyiTYxYQl3OUU3GemjGSNfCgI5h4nrN6CjDfQati5riN01Go5WXgNcI4fs Gqt9+1q2uUf4qMvYDC4QJERaVElgBjDA+X2OxbSwe/YwJ0BSoRlzhzIlec8dNljtHSzYP8 RB1e8uozO83QPYxaNSR1IsRtKynmiQqCQQnO1wlavnssISnJPV9ufxYTIawdkA== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 4B0549325; Thu, 2 Dec 2021 02:36:44 +0000 (UTC) Date: Thu, 2 Dec 2021 02:36:44 +0000 From: Alexey Dokuchaev To: Kubilay Kocak Cc: Cy Schubert , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: b8c4bfe660b3 - main - sysutils/reptyr: Address LLVM 13 build failure Message-ID: References: <202112020054.1B20sZXk040844@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1638412604; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iwfBeWFYlnPUmdPckT6gP9CBHqZdUwg9Mgi8MdeA3Vs=; b=pYGjZYJuky+TDgLbxazzWQ/M6+6Et2a/HQF9qAQ/5IvUpMREYxyQgOKYdx4ewCKqFXsccG efzi7dh1v3U09atYxojUjXQPTBPQo4QNwLG628In60gbkZp7FUMCvUzb5QmyVyIQdfAiWE V5lzziS+MXlYnmE3mtH3JF6BRy/EyLLkTIQ8IcZ5YazPTvxiKnCQTianGEjdTCU48QKnjm NEnhtaY2n7CCsTclRpk6M2iPUqqxci3w9qQx4wSzHZeEB/GUw5Z0TZTAlOx8uQgwZBRFaw qhNvcIQL/unv9W5zFN2VAESjSGhHANFLxNeV1mFSmCHk2AFfdGUIgt9KG/vv5w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1638412604; a=rsa-sha256; cv=none; b=BFI/RQM/rcN/4bWbG2BZTl4Fry/6Uzsh1320Y2P3RsWqoGFE2Ynl23LB8NV85yJ3iY4krt vGIup0Hnh1iPFoCue7VdnKM4I7zo2hyyUWV81lhWnrfPExKGDfB8bdMtiLPEnE2puXzZs9 9rqQg3D6ZE9UJmc2evJPaWlh5f9O03q5N1yFmmQEZTEXsL4DkEOTelBcDPtZS7MhCUFp/4 CnHmXcrhv9XikTlpo8Dn37EqS6qwhVqeZUIKYkcbfa8mHwB3eES+Qz61OH+N4ds+QXy22J OMvh3Rbly5ibV4e17PKEvB1TjhZ8qWAY9hXA73bY6q+FAVoT7M/5zetVzjRnHw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Thu, Dec 02, 2021 at 12:05:46PM +1100, Kubilay Kocak wrote: > On 2/12/2021 11:54 am, Cy Schubert wrote: > > commit b8c4bfe660b373862165a58514f270a51e77e147 > > > > sysutils/reptyr: Address LLVM 13 build failure > > ... > > 2 errors generated. > > Ports usually shouldn't use -Werror and people are strongly encouraged > to add -Wno-error On the other hand, every project really should enable -Werror so the compiler catches as much as it can for you. Having it enabled during development is a must, having it enabled in releases is arguable as it might bring extra burden to maintainer, but it does help to catch bugs in the environment original developer has no access to, so no, we don't strongly encourage -Wno-error when specific warnings can be scoped as it helps to catch other warnings in the future. Now they will likely went unnoticed, ergo unreported and unfixed. ./danfe