From nobody Wed Oct 30 11:55:12 2024 X-Original-To: dev-commits-ports-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Xdltn5W5Mz5bDHh; Wed, 30 Oct 2024 11:55:29 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Xdltn4YzYz4XM1; Wed, 30 Oct 2024 11:55:29 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730289329; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2I4UO5etE+ikeF8+Sl+2Kauw19p/kgjxiUKNhqRX+vU=; b=ZvQzybHKgleFkxXsH8wUTIvEMusrD3K/wKVrsbIfCusG3fUwMlrLv+NNwR/Twj+uOn8eqe pwfFoYWy5ERDttiYSkUuqNmKP08dj3MvEOK75NbpIRvpmUR8xFa1rNyQuLDtJpuyHR9Jx1 65H457Rq9yC9b/QeYKQXo8A4JjDV47G2m1KWHf/YQnFmqFcW8K/1YdmJr38keWnXvwngLT KLr6KVhib0twkwoZp45IkX1zN6IDOqZMj8WMm8JIn7LSQD2QOmfXS9naeX0Ni6NJOXvunC ewJSS88DfyUUO8XKntGhwQcbJQjC19snbQbql9Ybt6f1wV+Y+Z7wXE8DU2v5YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730289329; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2I4UO5etE+ikeF8+Sl+2Kauw19p/kgjxiUKNhqRX+vU=; b=h2MOoMYINR9smb9QZq1b3n0sMgdXt6Ov0W1wIi30WqVJ9RyQ/Peo2vfwbmzpszPLChDe0W TQbfveyRtNHFnafgHzlRoU27cus+04FueF4189tX6JJt3LgBe4vIe0csnyoDoq/+/qhbsP Y+kYpED3UNEdfVtpTsOuZ9+VIr6yzibtJKnoSMlqFDN3f1y322KOax1NZPa4MtCEsPx2YD olLH9eex96xA7goPr0p2EhYraQZJT0CMjCK3Wk5Qbz9WsuqtrtjuQEGOx2jwpdeht9HYBp jFfX5FS9R2Oh0gLjlragvu9H2RXZgQNp1lHq0BXtw95jrE1o8wHBpE8RsfeHsA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1730289329; a=rsa-sha256; cv=none; b=CquWKuhUfkfmKiFBBgIjUPw1kEkleL+8DBZTNLbfC5yC3hZRAAY2kYGXpa0+jgXiX/XDTo EiX+Ix7yXn5Pm854y6B3rGvzxq96+dD+/w26D+mqNn9h5SYUC3VkW+ZMdRzYZMBCgIQgCN Cy4FgSp77l4/9MY2rMK74mfyOHLLndUZNXXksc3xhJAs6qMyPeji7hXbz44nF7IDfFBi6Z O0XtN5/k5G+QIg8/HRnNDS7dP6YHzkDy4At/StcvcKITx62irtJWrK+L84z0dQhoEGkcWs VH4Wzq+BMYMmcU9fwipHKetG1b26lKADyZaV1g43rgd/PTt4SEDc1KQQXOB+WA== Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Xdltn41pFzGlY; Wed, 30 Oct 2024 11:55:29 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-qv1-f43.google.com with SMTP id 6a1803df08f44-6cbe53e370eso10845296d6.2; Wed, 30 Oct 2024 04:55:29 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUSYqUaOkwMkhSZVQ5KN+aToIi9NuB3COvyzELoc8WT4h0WbDKvxGeRo/S7nlr3m8C0/WD9MdR/VMQkYlo4m/tjCvOGXEU=@freebsd.org, AJvYcCVqGVxOy5iMp6dS2/R+Ov8VMdjbb3SCT40yZWxbH4KxflpMxTiQ/Ekb/QgXJ0h1Wz+1/LI7s1Vm2rrg5dfpQRk/HjsMWdyIm8/ChEU=@freebsd.org X-Gm-Message-State: AOJu0YzjUqULS27E7VXf/xX4pzxWttxs6wiJBbeK+Xsz7nPeGZEXOGme KOQ9Y++hjMpO1Z6RN9Mhx5cN1raCI2A9CovD9wAlEli0z4HhWNs/UZzzZvQey5NqJIDyNez6GgA o98xh7uGyKgT8mUvi59v8rGutqHE= X-Google-Smtp-Source: AGHT+IG0L1IqLyH6pHvf8Shsnu7crfbJ2P50pX1+GhQJt94r3GrSQlDrcfzlhnbk/xgmykcUsgqCUs7KEdhTzoBI4NE= X-Received: by 2002:ac8:598c:0:b0:460:e1e6:7db2 with SMTP id d75a77b69052e-4613c03be8fmr104288111cf.9.1730289328988; Wed, 30 Oct 2024 04:55:28 -0700 (PDT) List-Id: Commits to the quarterly branches of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-branches@freebsd.org Sender: owner-dev-commits-ports-branches@FreeBSD.org MIME-Version: 1.0 References: <202410300858.49U8wD5g095990@gitrepo.freebsd.org> In-Reply-To: From: Nuno Teixeira Date: Wed, 30 Oct 2024 11:55:12 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 8e9ad0847d59 - 2024Q4 - science/step: Fix build with LLVM >= 19.1.0-rc1 To: "Jason E. Hale" Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-branches@freebsd.org Content-Type: multipart/alternative; boundary="000000000000d036060625b060ed" --000000000000d036060625b060ed Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable (...) Forgot to mention PR https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D282407 Still looking on how to fix this kind of error. Cheers, Nuno Teixeira escreveu (quarta, 30/10/2024 =C3=A0(s) 10:53): > Hello Jason, > > Could you take a look at sysutils/lnav upstream PR > https://github.com/tstack/lnav/issues/1328 ? > > Any help is welcome. > > Cheers, > > Jason E. Hale escreveu (quarta, 30/10/2024 =C3=A0(s) > 08:58): > >> The branch 2024Q4 has been updated by jhale: >> >> URL: >> https://cgit.FreeBSD.org/ports/commit/?id=3D8e9ad0847d59db0920a771915b16= c66deceb2a80 >> >> commit 8e9ad0847d59db0920a771915b16c66deceb2a80 >> Author: Jason E. Hale >> AuthorDate: 2024-10-30 06:43:09 +0000 >> Commit: Jason E. Hale >> CommitDate: 2024-10-30 08:57:36 +0000 >> >> science/step: Fix build with LLVM >=3D 19.1.0-rc1 >> >> Clang >=3D 19.1.0-rc1 requires a template argument list after an >> identifier >> prefixed by the template keyword. [1] >> >> >> /wrkdirs/usr/ports/science/step/work/step-23.08.5/stepcore/object.h:252:= 45: >> error: a template argument list is expected after a name prefixed by >> the >> template keyword [-Wmissing-template-arg-list-after-template-kw] >> 252 | if(!src || !src->metaObject()->template inherits(_Dst())= ) >> return NULL; >> >> [1] >> https://github.com/llvm/llvm-project/commit/f46d1463b835560d90ad3ac02b63= c771e4ebe566 >> >> Reported by: pkg-fallout >> MFH: 2024Q2 >> >> (cherry picked from commit f812d021d79f6a4034640eece6b7ae1b32df21a0) >> --- >> science/step/files/patch-stepcore_object.h | 21 +++++++++++++++++++++ >> 1 file changed, 21 insertions(+) >> >> diff --git a/science/step/files/patch-stepcore_object.h >> b/science/step/files/patch-stepcore_object.h >> new file mode 100644 >> index 000000000000..5b2f47415a27 >> --- /dev/null >> +++ b/science/step/files/patch-stepcore_object.h >> @@ -0,0 +1,21 @@ >> +Clang >=3D 19.1.0-rc1 requires a template argument list after an identi= fier >> +prefixed by the template keyword. [1] >> + >> >> +/wrkdirs/usr/ports/science/step/work/step-23.08.5/stepcore/object.h:252= :45: >> +error: a template argument list is expected after a name prefixed by th= e >> +template keyword [-Wmissing-template-arg-list-after-template-kw] >> + 252 | if(!src || !src->metaObject()->template inherits(_Dst())) >> return NULL; >> + >> +[1] >> https://github.com/llvm/llvm-project/commit/f46d1463b835560d90ad3ac02b63= c771e4ebe566 >> + >> +--- stepcore/object.h.orig 2024-02-10 03:35:30 UTC >> ++++ stepcore/object.h >> +@@ -249,7 +249,7 @@ _Dst stepcore_cast(_Src src) { >> + /** Casts between pointers to Object */ >> + template // XXX: implement it better >> + _Dst stepcore_cast(_Src src) { >> +- if(!src || !src->metaObject()->template inherits(_Dst())) return >> NULL; >> ++ if(!src || !src->metaObject()->template inherits<_Dst>(_Dst())) >> return NULL; >> + return static_cast<_Dst>(src); >> + } >> + >> > > > -- > Nuno Teixeira > FreeBSD UNIX: Web: https://FreeBSD.org > --=20 Nuno Teixeira FreeBSD UNIX: Web: https://FreeBSD.org --000000000000d036060625b060ed Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Still = looking on how to fix this kind of error.

Cheers,
Nuno Teix= eira <eduardo@freebsd.org>= escreveu (quarta, 30/10/2024 =C3=A0(s) 10:53):
Hello Jason,

Could you take a look at sysutils/lnav upstream PR https://= github.com/tstack/lnav/issues/1328 ?

Any help is welc= ome.

Cheers,

Jason E. Hale <jhale@freebsd.org> escreveu (q= uarta, 30/10/2024 =C3=A0(s) 08:58):
The branch 2024Q4 has been updated by jhale:

URL: https://cgi= t.FreeBSD.org/ports/commit/?id=3D8e9ad0847d59db0920a771915b16c66deceb2a80

commit 8e9ad0847d59db0920a771915b16c66deceb2a80
Author:=C2=A0 =C2=A0 =C2=A0Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2024-10-30 06:43:09 +0000
Commit:=C2=A0 =C2=A0 =C2=A0Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2024-10-30 08:57:36 +0000

=C2=A0 =C2=A0 science/step: Fix build with LLVM >=3D 19.1.0-rc1

=C2=A0 =C2=A0 Clang >=3D 19.1.0-rc1 requires a template argument list af= ter an identifier
=C2=A0 =C2=A0 prefixed by the template keyword. [1]

=C2=A0 =C2=A0 /wrkdirs/usr/ports/science/step/work/step-23.08.5/stepcore/ob= ject.h:252:45:
=C2=A0 =C2=A0 error: a template argument list is expected after a name pref= ixed by the
=C2=A0 =C2=A0 template keyword [-Wmissing-template-arg-list-after-template-= kw]
=C2=A0 =C2=A0 =C2=A0 252 |=C2=A0 =C2=A0 =C2=A0if(!src || !src->metaObjec= t()->template inherits(_Dst())) return NULL;

=C2=A0 =C2=A0 [1] https://github.com/llvm/llvm-project/commit/f46d1463b835560d90ad3ac02b63c= 771e4ebe566

=C2=A0 =C2=A0 Reported by:=C2=A0 =C2=A0 pkg-fallout
=C2=A0 =C2=A0 MFH:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 2024Q2

=C2=A0 =C2=A0 (cherry picked from commit f812d021d79f6a4034640eece6b7ae1b32= df21a0)
---
=C2=A0science/step/files/patch-stepcore_object.h | 21 +++++++++++++++++++++=
=C2=A01 file changed, 21 insertions(+)

diff --git a/science/step/files/patch-stepcore_object.h b/science/step/file= s/patch-stepcore_object.h
new file mode 100644
index 000000000000..5b2f47415a27
--- /dev/null
+++ b/science/step/files/patch-stepcore_object.h
@@ -0,0 +1,21 @@
+Clang >=3D 19.1.0-rc1 requires a template argument list after an identi= fier
+prefixed by the template keyword. [1]
+
+/wrkdirs/usr/ports/science/step/work/step-23.08.5/stepcore/object.h:252:45= :
+error: a template argument list is expected after a name prefixed by the +template keyword [-Wmissing-template-arg-list-after-template-kw]
+=C2=A0 252 |=C2=A0 =C2=A0 =C2=A0if(!src || !src->metaObject()->templ= ate inherits(_Dst())) return NULL;
+
+[1] https://git= hub.com/llvm/llvm-project/commit/f46d1463b835560d90ad3ac02b63c771e4ebe566
+
+--- stepcore/object.h.orig=C2=A0 =C2=A0 =C2=A02024-02-10 03:35:30 UTC
++++ stepcore/object.h
+@@ -249,7 +249,7 @@ _Dst stepcore_cast(_Src src) {
+ /** Casts between pointers to Object */
+ template<class _Dst, class _Src> // XXX: implement it better
+ _Dst stepcore_cast(_Src src) {
+-=C2=A0 =C2=A0 if(!src || !src->metaObject()->template inherits(_Dst= ())) return NULL;
++=C2=A0 =C2=A0 if(!src || !src->metaObject()->template inherits<_= Dst>(_Dst())) return NULL;
+=C2=A0 =C2=A0 =C2=A0return static_cast<_Dst>(src);
+ }
+


--


--
Nuno Teixeira
FreeBSD UNIX:=C2=A0 <eduardo@FreeBSD.org>=C2=A0 =C2=A0Web:=C2=A0 https://Fr= eeBSD.org
--000000000000d036060625b060ed--