From nobody Wed Nov 20 08:50:17 2024 X-Original-To: dev-commits-ports-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XtZnQ1lCXz5dT3M; Wed, 20 Nov 2024 08:50:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XtZnQ18D1z4YWV; Wed, 20 Nov 2024 08:50:18 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1732092618; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AKMNA0/xPApZgkbiGPrAlsvbTq2XPTQ4d27ZE3JaOIg=; b=HtLa0h/eEwrYXrGcTZfJDN46OCjqCq38cXZDnzhPB/Fn3scU5HDjdwazID3LHgg0/a4HFm fXZBP8eOio0NU7nX6IflNAFFYyof9amQFlI10+sxXay98Syt2NJaJaCCRckIcFTzQOrF+N FHQhwa80ZjbCT8jT1mcnnLiuXHl1pJtdMxwZyxLpQwvN4AJtTkzEil4osS0H021T4xg8hf BwwYfZ1Jqo4ePN6/cWup1sWxGOahIvxd7ix3P7yvjhcHADw5j15op+tnmEH0BScBEDBaQf kEyfnaVe+kc5/o1cKRz0GXNqnIWe3FpCCC/W0/oskbeqoOJ+egsnxn1hsm3juw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1732092618; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AKMNA0/xPApZgkbiGPrAlsvbTq2XPTQ4d27ZE3JaOIg=; b=UBr7Te0z1LzhD1p5YMpFij4+7UKOPQ4EzyeO58mN7ugYfrmCIquCfrLrrcKy1I0USXmZ91 nE/KfboRqGeqGmW7fwsHDtDHKQhQ+rYLv4/41ZENvSJ9bLabo82QY0BCvrY2LlBRv5bn7H PgrpFg+9szZH4uADIQZ+Id+SnhYkAphNuJ5kvq95u3xpy2fxu9KmoTNZ45+8APlLAGbcAe UWb7F2wpbd8yzlXNzj/liD/H+XeBgVhp3dFvbBPiKnparzZjeIaYUkrN3iDsZheapXGHH5 Lzl7/wBCnuHte4gQvI8Ayy4N8q5SQE+8CSEs1KofsuNxvGNfmPGSzKtV3XmA7Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1732092618; a=rsa-sha256; cv=none; b=u+V1BNMbU/O8d7FAS3cfVwAXJT0wwupHtlRkM5SoMddptQYdApo4ZXhyJPDddTVViQcDzd EsbB3v4HTbhrDCL4HK/bJmKf2SjUj4A0izURObnCmSyJhbNZrgbqZ/0qRjM1DEgtvnS7Ob iBsLgHncHysMHqCHC+e2QIAHp3eJ2FrubA+axtS8P7sMXV7O5JttwzQ88aREUu8kk8gB/Q R+cB6yWEjmCrbSVWvQJ+XMBIsCsKhl5+cNaPXwvSmeB1M1Wz4hgmA5QVHIaIlIyZJK/Kou C/YS9pwnods0UUzWWP8gJscqpGZhLH2ROrlGs8p6rDDF+uYVtPE2fKCf6bm25A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XtZnQ0dGXznRy; Wed, 20 Nov 2024 08:50:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4AK8oHGU083622; Wed, 20 Nov 2024 08:50:17 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4AK8oHff083619; Wed, 20 Nov 2024 08:50:17 GMT (envelope-from git) Date: Wed, 20 Nov 2024 08:50:17 GMT Message-Id: <202411200850.4AK8oHff083619@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-branches@FreeBSD.org From: Dimitry Andric Subject: git: 18716b688cfb - 2024Q4 - math/givaro: fix build with clang 19 List-Id: Commits to the quarterly branches of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-branches@freebsd.org Sender: owner-dev-commits-ports-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: ports X-Git-Refname: refs/heads/2024Q4 X-Git-Reftype: branch X-Git-Commit: 18716b688cfbad2fcb3a34d6520d982b6aa3c13a Auto-Submitted: auto-generated The branch 2024Q4 has been updated by dim: URL: https://cgit.FreeBSD.org/ports/commit/?id=18716b688cfbad2fcb3a34d6520d982b6aa3c13a commit 18716b688cfbad2fcb3a34d6520d982b6aa3c13a Author: Dimitry Andric AuthorDate: 2024-11-18 10:12:37 +0000 Commit: Dimitry Andric CommitDate: 2024-11-20 08:50:07 +0000 math/givaro: fix build with clang 19 Clang 19 has become more strict about errors in member functions, which results in errors building math/givaro: ./givaro/givaro/givaro/random-integer.h:94:51: error: no viable overloaded '=' 94 | const_cast(_ring)=R._ring; | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~ ./givaro/givaro/givaro/random-integer.h:94:51: note: type 'Integer_Domain' (aka 'ZRing') is incomplete 94 | const_cast(_ring)=R._ring; | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~ In file included from givintprime.C:19: In file included from ./givaro/givintprime.h:24: In file included from ./givaro/givaro/givinteger.h:25: ../../../src/kernel/ring/givaro/zring.h:123:13: warning: misleading indentation; statement is not part of the previous 'while' [-Wmisleading-indentation] 123 | return a; } | ^ ../../../src/kernel/ring/givaro/zring.h:121:11: note: previous statement is here 121 | { while (isZero(init(a, g()))) | ^ The `const_cast` line has been removed by upstream as part of https://github.com/linbox-team/givaro/commit/b0cf33e1, but that commit is rather large. It is enough to only delete the line. Also fix a failure that occurs when running "make test": ../src/kernel/recint/rfiddling.h:170:29: error: no member named 'Low' in 'rint' This is because the expression `max.Low.Value` should actually be `max.Value.Low`. PR: 282830 Approved by: pi (maintainer) MFH: 2024Q4 (cherry picked from commit b47d453f0aac2e1b349475f9e7fd44fde0a35d76) --- math/givaro/files/patch-src_kernel_integer_random-integer.h | 10 ++++++++++ math/givaro/files/patch-src_kernel_recint_rfiddling.h | 11 +++++++++++ 2 files changed, 21 insertions(+) diff --git a/math/givaro/files/patch-src_kernel_integer_random-integer.h b/math/givaro/files/patch-src_kernel_integer_random-integer.h new file mode 100644 index 000000000000..901ddd8ea8e3 --- /dev/null +++ b/math/givaro/files/patch-src_kernel_integer_random-integer.h @@ -0,0 +1,10 @@ +--- src/kernel/integer/random-integer.h.orig 2021-12-14 10:00:03 UTC ++++ src/kernel/integer/random-integer.h +@@ -91,7 +91,6 @@ namespace Givaro + if (this != &R) { + _bits = R._bits; + _integer = R._integer; +- const_cast(_ring)=R._ring; + } + return *this; + } diff --git a/math/givaro/files/patch-src_kernel_recint_rfiddling.h b/math/givaro/files/patch-src_kernel_recint_rfiddling.h new file mode 100644 index 000000000000..5591e9e210bf --- /dev/null +++ b/math/givaro/files/patch-src_kernel_recint_rfiddling.h @@ -0,0 +1,11 @@ +--- src/kernel/recint/rfiddling.h.orig 2021-12-14 10:00:03 UTC ++++ src/kernel/recint/rfiddling.h +@@ -167,7 +167,7 @@ namespace RecInt + template + inline rint rint::maxFFLAS() { + rint max; +- set_highest_bit(max.Low.Value); ++ set_highest_bit(max.Value.Low); + return max; + } +