From nobody Thu May 16 00:04:47 2024 X-Original-To: dev-commits-ports-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Vfr1q1PY6z5K5gj; Thu, 16 May 2024 00:04:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Vfr1q0vr3z4Ng6; Thu, 16 May 2024 00:04:47 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715817887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LkirNxy2CULqj2a5L55rEzUsltnqtbKvYiwwo53SZWQ=; b=rIJUK7FgXTzlcBqlVNETHlO2X2Gdi76E/IUmV+o6kvEOtNBVWbNLZaCXtKpeHUMdwZLpYk G32II0feedCgy84z2DD80MscRbEFjITQEVVuPk6qM7mEUW0HLG5GNz1uV5cPZhqO302H8U ivNgT4W2yxif9uGLbypF8WK/LBsLdIBE3CbdQkhFg4rd+63WJHaSiBPfCVxaI+JyMMMJhF ROT0QBqrx6xObHmPUtGx1TCDwx8maPhc8ZrP2H0FkNO3sWZqT3eTsntYskLBwtTM93SbGs jO3jzpQNozvf9RsUBOAvdpHOqNYDusyoBJGJjfMcGBB224i3aFeKt+G7NHlmpQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1715817887; a=rsa-sha256; cv=none; b=i0iOfeJcmQKJGD/MWvr5bVKgMOKtY/kDA7BMj0uKMSnHJ+Ksy9VjoqyK3bEvrIfiGF1Tb8 t2a2MX+fysONa0EjTCcNRNG0aLco32Q1YEEqOgDKviOnSzJGbagQDHglwDDgejCuRcgy8f TpXSB7PNbiPOPBcY3eMDE+6sGigyTBe7j4xFS4Xm8eNxQSzv0axlX5U9zCvabXecf5B++A dnwfEev3CD2N9SPHGYk6PS5hVYstG4arCJR9ZO8sZvJjD8kHOCxNPo9lotBR9xTX5vM7+Q IxgH0jWjvXIcAVzBC96tNFy2s2yB6vLR5yniEV0xEVjL2HmY2401ykrfFtr3DQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715817887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LkirNxy2CULqj2a5L55rEzUsltnqtbKvYiwwo53SZWQ=; b=QvH4rxfBVfPxXaupKGfR4+DtM4W5bDBDK7h/CaT15nN6HFLy84tiKXfHIuhTNjuq2YA6iK buj9VYuAOybMOxEPyA/wroTIJhO8h9i1It7EA4fbBooXwTYXnocNu2MGo3s3kIfiGrFBbC lpG4aYw4rG7SDAZ138ZF04VVupsIRfqEgIppgbdTM0Kk0zfwOgtOkCLau92NIFFMWLOCPs WXM6FvrzR8J5VbPyJUrYRwrrdxMYMSqPaC0E5sj4nbiBGAX99BomhGMc6xo/0yURbLGQLp BI7h7obHjOSOFbJ6hM6VDEbuEjzBxzTt5pAt8TPub7DY+zcGod9A/bpIt9d7eg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Vfr1q0VhSzcST; Thu, 16 May 2024 00:04:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 44G04lpt086810; Thu, 16 May 2024 00:04:47 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 44G04lE5086807; Thu, 16 May 2024 00:04:47 GMT (envelope-from git) Date: Thu, 16 May 2024 00:04:47 GMT Message-Id: <202405160004.44G04lE5086807@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-branches@FreeBSD.org From: "Jason E. Hale" Subject: git: 910c4d572da2 - 2024Q2 - audio/rsgain: Fix segmentation fault List-Id: Commits to the quarterly branches of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-branches@freebsd.org Sender: owner-dev-commits-ports-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhale X-Git-Repository: ports X-Git-Refname: refs/heads/2024Q2 X-Git-Reftype: branch X-Git-Commit: 910c4d572da2fcc17dc9d646136dfb6d6e9fdcc4 Auto-Submitted: auto-generated The branch 2024Q2 has been updated by jhale: URL: https://cgit.FreeBSD.org/ports/commit/?id=910c4d572da2fcc17dc9d646136dfb6d6e9fdcc4 commit 910c4d572da2fcc17dc9d646136dfb6d6e9fdcc4 Author: Jason E. Hale AuthorDate: 2024-05-15 23:56:38 +0000 Commit: Jason E. Hale CommitDate: 2024-05-16 00:04:35 +0000 audio/rsgain: Fix segmentation fault When calculating album loudness on a drectory containing one or more audio files using `rsgain easy .`, for example, a segmentation fault can occur. Affects versions 3.4 and 3.5. PR: 278838 Reported by: MFH: 2024Q2 (cherry picked from commit 99bafb68144c1824441d3b47c3dc141c7721148b) --- audio/rsgain/Makefile | 1 + audio/rsgain/files/patch-src_scan.cpp | 16 ++++++++++++++++ 2 files changed, 17 insertions(+) diff --git a/audio/rsgain/Makefile b/audio/rsgain/Makefile index 77f2e7f5f933..0c4d8bd4aa04 100644 --- a/audio/rsgain/Makefile +++ b/audio/rsgain/Makefile @@ -1,5 +1,6 @@ PORTNAME= rsgain DISTVERSION= 3.5 +PORTREVISION= 1 DISTVERSIONSUFFIX= -source CATEGORIES= audio MASTER_SITES= https://github.com/complexlogic/rsgain/releases/download/v${DISTVERSION}/ diff --git a/audio/rsgain/files/patch-src_scan.cpp b/audio/rsgain/files/patch-src_scan.cpp new file mode 100644 index 000000000000..3d9dbb23b23f --- /dev/null +++ b/audio/rsgain/files/patch-src_scan.cpp @@ -0,0 +1,16 @@ +Fix a segfault when calculating album loudness. + +PR: 278838 +Regressed by: https://github.com/complexlogic/rsgain/commit/63e87a4f7d3b5c816eab630fba41ba9a63b82519 + +--- src/scan.cpp.orig 2024-02-25 17:47:20 UTC ++++ src/scan.cpp +@@ -639,7 +639,7 @@ void ScanJob::calculate_album_loudness() + std::vector states(nb_states); + for (const Track &track : tracks) + if (track.result.track_loudness != -HUGE_VAL) +- states.emplace_back(track.ebur128.get()); ++ states[(size_t) (&track - &tracks[0])] = track.ebur128.get(); + + if (ebur128_loudness_global_multiple(states.data(), states.size(), &album_loudness) != EBUR128_SUCCESS) + album_loudness = config.target_loudness;