From nobody Tue Apr 09 07:44:02 2024 X-Original-To: dev-commits-ports-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VDHzm4zqFz5GtYZ; Tue, 9 Apr 2024 07:44:52 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4VDHzl19Ggz4Slb; Tue, 9 Apr 2024 07:44:50 +0000 (UTC) (envelope-from manu@bidouilliste.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bidouilliste.com header.s=mx header.b=WlBiETJL; dmarc=pass (policy=none) header.from=bidouilliste.com; spf=pass (mx1.freebsd.org: domain of manu@bidouilliste.com designates 212.83.155.74 as permitted sender) smtp.mailfrom=manu@bidouilliste.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1712648682; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T+BEOGs99vbIXP2DwkgYVtLD0ZPzu895od5L208YR1o=; b=WlBiETJLM2na8D2519BI7ZYmTlk+5PuO8JBJ5FsyEEgJyh6xAamWL0bsqXW3uGyKSThFrx 3cJpHsrdualuhK59b8JTYhLJWVALvSsRHDzMeYFDzVXpGztftBmaKUwfham99HwPP0Uwd9 oe3A52TINqzyXiMQ/lYoOlKJEOmR8no= Received: from skull.home.blih.net (lfbn-lyo-1-2174-135.w90-66.abo.wanadoo.fr [90.66.97.135]) by mx.blih.net (OpenSMTPD) with ESMTPSA id b7b07d6e (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 9 Apr 2024 07:44:42 +0000 (UTC) Date: Tue, 9 Apr 2024 09:44:02 +0200 From: Emmanuel Vadot To: Jan Beich Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-branches@FreeBSD.org Subject: Re: git: 77f72c463b90 - 2024Q1 - x11-servers/xwayland-devel: backport recent secfixes Message-Id: <20240409094402.147972b37e03f594f3d7f588@bidouilliste.com> In-Reply-To: References: <202404040955.4349tDrM089062@gitrepo.freebsd.org> <20240404125743.1e52876a69053b726cb456e4@bidouilliste.com> <8r1t-ny0j-wny@FreeBSD.org> <20240404141239.35d54535539b66cd6336ee5b@bidouilliste.com> <7chd-l2ru-wny@FreeBSD.org> <20240404151554.04340786db8562e522f7b1a8@bidouilliste.com> <20240405104111.9d9263dfe7ce99a01d620ab3@bidouilliste.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd15.0) List-Id: Commits to the quarterly branches of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-branches@freebsd.org X-BeenThere: dev-commits-ports-branches@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.40 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.998]; DMARC_POLICY_ALLOW(-0.50)[bidouilliste.com,none]; MV_CASE(0.50)[]; R_DKIM_ALLOW(-0.20)[bidouilliste.com:s=mx]; R_SPF_ALLOW(-0.20)[+ip4:212.83.155.74/32]; ONCE_RECEIVED(0.10)[]; MIME_GOOD(-0.10)[text/plain]; ASN(0.00)[asn:12876, ipnet:212.83.128.0/19, country:FR]; FREEFALL_USER(0.00)[manu]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FROM_HAS_DN(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-ports-branches@FreeBSD.org,dev-commits-ports-all@FreeBSD.org]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[bidouilliste.com:+] X-Rspamd-Queue-Id: 4VDHzl19Ggz4Slb On Sat, 06 Apr 2024 12:01:54 +0200 Jan Beich wrote: > Emmanuel Vadot writes: > > > On Thu, 04 Apr 2024 15:48:55 +0200 > > Jan Beich wrote: > > > >> Emmanuel Vadot writes: > >> > >> >> but also introduced a number of regressions that > >> >> don't exist in my port, all of which were documented in my reviews. > >> > > >> > What regressions ? I'm using xwayland for more than a year on my > >> > desktop instead of -devel and haven't seen a problem. > >> > >> Try diff xwayland{,-devel}/Makefile: > >> - Missing XSECURITY (ssh -X vs. ssh -Y; xorg-server parity per bug 221984) > > > > I admit that I'm a bit lost on this one, I did some test and here is > > what I found : > > > > - Using sway and xwayland (so without xcsecurity enabled) I can't ssh > > -X to a xorg host and run applications (DISPLAY is not set), but I can > > ssh -Y fine > > Works fine here: > > # Prepare by removing existing permissions > $ rm ~/.Xauthority > $ ssh test@jail rm \~/.Xauthority > > # x11-servers/xwayland-devel > $ ssh -X test@jail xeyes > /usr/local/bin/xauth: file /home/test/.Xauthority does not exist > Xlib: extension "XInputExtension" missing on display "localhost:10.0". > ^C > > # x11-servers/xwayland > $ ssh -X test@jail xeyes > Warning: untrusted X11 forwarding setup failed: xauth key data not generated > Error: Can't open display: > > Alternatively, SECURITY extension can be tested locally: > > $ xauth generate $DISPLAY . untrusted && xeyes > xauth: file /home/jbeich/.Xauthority does not exist > Xlib: extension "XInputExtension" missing on display ":0". > ^C > > Curiously, wlroots starts Xwayland without -auth argument unlike others. > https://gitlab.gnome.org/GNOME/mutter/-/commit/a8984a81c2e8 > https://invent.kde.org/plasma/kwin/-/commit/335d9c41925d > > > So what I did next was to recompile xorg-server with xcsecurity > > set to false. And to my surprise ssh -X from a xorg host to the one > > with the modified xorg-server still worked. > > Did you run the modified xorg-server locally? ssh -X doesn't use > xorg-server on the remote host, where sshd server is running. > > > xcsecurity is disabled by default in xorg-server upstream (in meson) > > and I think that we should do the same (granted that XACE works > > correctly). > > From https://gitlab.freedesktop.org/xorg/xserver/-/blob/c93c2e7718bc/Xext/Makefile.am#L58-59 > # X-ACE extension: provides hooks for building security policy extensions > # like XC-Security, X-SELinux & XTSol > > X-SELinux is Linux-only. XTSol is Solaris-only. Everyone else is left > with the legacy XC-Security (trusted/untrusted) or nothing. No, We build with X-ACE currently and this isn't what the doc is saying. It just says that X-ACE is somewhat what X-SELinux and XTSol is. In fact it seems that XCSECURITY imply X-ACE, I haven't looked at the code but it's possible that the XCSECURITY code is using X-ACE as the backend. -- Emmanuel Vadot