From nobody Fri Apr 05 09:38:06 2024 X-Original-To: dev-commits-ports-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4V9thL0mRDz5G591; Fri, 5 Apr 2024 09:38:10 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4V9thJ6HW0z4c7D; Fri, 5 Apr 2024 09:38:08 +0000 (UTC) (envelope-from manu@bidouilliste.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bidouilliste.com header.s=mx header.b=d4mVFUrT; dmarc=pass (policy=none) header.from=bidouilliste.com; spf=pass (mx1.freebsd.org: domain of manu@bidouilliste.com designates 212.83.155.74 as permitted sender) smtp.mailfrom=manu@bidouilliste.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1712309887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TpMj7hTg0aHT54LlwNsdNyUMs8H+DMjInr1+z1LgotA=; b=d4mVFUrT/Bz69r7Yc15c1WROBELKFY1BGWDcWErmkZf9QiXLvbkvJyHMFUvZjht7Pfxa/x oJ5CeG/1od7kENcvry9qKKp+PlJ8BTYOSKcAape6IyrfYaDnaznyUPKJb4puooUdwff+q2 OhBmYItB0kW8g8ym6/MtTdbHRl/ee2o= Received: from skull.home.blih.net (lfbn-lyo-1-2174-135.w90-66.abo.wanadoo.fr [90.66.97.135]) by mx.blih.net (OpenSMTPD) with ESMTPSA id 35606cd1 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 5 Apr 2024 09:38:07 +0000 (UTC) Date: Fri, 5 Apr 2024 11:38:06 +0200 From: Emmanuel Vadot To: Jan Beich Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-branches@FreeBSD.org Subject: Re: git: 77f72c463b90 - 2024Q1 - x11-servers/xwayland-devel: backport recent secfixes Message-Id: <20240405113806.889fae681a45e844579c453c@bidouilliste.com> In-Reply-To: <20240405104111.9d9263dfe7ce99a01d620ab3@bidouilliste.com> References: <202404040955.4349tDrM089062@gitrepo.freebsd.org> <20240404125743.1e52876a69053b726cb456e4@bidouilliste.com> <8r1t-ny0j-wny@FreeBSD.org> <20240404141239.35d54535539b66cd6336ee5b@bidouilliste.com> <7chd-l2ru-wny@FreeBSD.org> <20240404151554.04340786db8562e522f7b1a8@bidouilliste.com> <20240405104111.9d9263dfe7ce99a01d620ab3@bidouilliste.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd15.0) List-Id: Commits to the quarterly branches of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-branches@freebsd.org X-BeenThere: dev-commits-ports-branches@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.38 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.98)[-0.977]; DMARC_POLICY_ALLOW(-0.50)[bidouilliste.com,none]; MV_CASE(0.50)[]; R_DKIM_ALLOW(-0.20)[bidouilliste.com:s=mx]; R_SPF_ALLOW(-0.20)[+ip4:212.83.155.74/32]; ONCE_RECEIVED(0.10)[]; MIME_GOOD(-0.10)[text/plain]; ASN(0.00)[asn:12876, ipnet:212.83.128.0/19, country:FR]; FREEFALL_USER(0.00)[manu]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FROM_HAS_DN(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-ports-branches@FreeBSD.org,dev-commits-ports-all@FreeBSD.org]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[bidouilliste.com:+] X-Rspamd-Queue-Id: 4V9thJ6HW0z4c7D On Fri, 5 Apr 2024 10:41:11 +0200 Emmanuel Vadot wrote: > On Thu, 04 Apr 2024 15:48:55 +0200 > Jan Beich wrote: > > > Emmanuel Vadot writes: > > > > >> but also introduced a number of regressions that > > >> don't exist in my port, all of which were documented in my reviews. > > > > > > What regressions ? I'm using xwayland for more than a year on my > > > desktop instead of -devel and haven't seen a problem. > > > > Try diff xwayland{,-devel}/Makefile: > > - Missing XSECURITY (ssh -X vs. ssh -Y; xorg-server parity per bug 221984) > > I admit that I'm a bit lost on this one, I did some test and here is > what I found : > > - Using sway and xwayland (so without xcsecurity enabled) I can't ssh > -X to a xorg host and run applications (DISPLAY is not set), but I can > ssh -Y fine > - If I enable xcsecurity for xwayland behavior is exactly the same > (i.e. -X doesn't work, -Y does). > - I've confirmed that -X works from another xorg host > > So what I did next was to recompile xorg-server with xcsecurity > set to false. And to my surprise ssh -X from a xorg host to the one > with the modified xorg-server still worked. > xcsecurity was added in 2018 via PR 221984 which states that it fixes > -X, and that doesn't seems to be the case, xcsecurity doesn't seems to > be related to X11 forwarding but something for grouping client so they > can't access to each other or something (see > https://www.x.org/wiki/Development/Documentation/Security/#index2h2 for > more info). > xcsecurity is disabled by default in xorg-server upstream (in meson) > and I think that we should do the same (granted that XACE works > correctly). > > The TLDR is that this has nothing to do with X11 forwarding and that I > think that not enabling this option in xwayland (and in -devel too) is > a good thing, one of the benefit of wayland is to drop the old X11 > crappy model. > > > - Missing XDMCP (xorg-server parity, maybe used with rootful Xwayland and GUI login managers) > > I've lost 2 hours looking at xcsecurity so unless you can prove to me > that this option is good to have enabled (and explained what it does > exactly) I won't look into it for now. bapt@ convinced me that it would be a good thing to have. Also we enable it for xephyr so no good reason to not have it in xwayland. Both gdm and lightdm support xdcmp. > > - Missing XTEST input emulation (XDG Portal API, required by GNOME, Plasma and maybe rootful Xwayland) > > - Missing CSD for rootful (mainly for GNOME, optional even if preferred elsewhere) > > I do agree that both should be enabled, bapt@ started a patch and I've > asked him to wait so I could have a look at XCSECURITY before. > > > - Broken on DragonFly due to forcing -Dsha1 (already default after I've fixed upstream bug years ago) > > - Redundant -Dglamor, -Dipv6, -Dxkb_*, libEGL dependency > > Cheers, > > -- > Emmanuel Vadot -- Emmanuel Vadot