From nobody Thu Apr 04 15:42:08 2024 X-Original-To: dev-commits-ports-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4V9Qpw0nfrz5HCNB; Thu, 4 Apr 2024 15:42:16 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4V9Qpv0kZqz4SPn; Thu, 4 Apr 2024 15:42:14 +0000 (UTC) (envelope-from manu@bidouilliste.com) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1712245332; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SP4klEmpdo0bxcp5L34G/DqloYdVqX5MVIBTKwVeqvw=; b=Z1R0KaYboQc6FAWRmCLabVZfbSzMyNTpGAugtcTutZOqBP55P2WLm/Do5t9Di2FluDeEQ2 //iB21UHwJ78h2T7qSmFzXXqyxgeGJqMo/3eW4N4Ny5MQPLLDcqgcrh3uqsnJFzb1d29wO J06PWAZ484vuN844crZXD+3aUH1xhUc= Received: from skull.home.blih.net (lfbn-lyo-1-2174-135.w90-66.abo.wanadoo.fr [90.66.97.135]) by mx.blih.net (OpenSMTPD) with ESMTPSA id f0b97a50 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 4 Apr 2024 15:42:11 +0000 (UTC) Date: Thu, 4 Apr 2024 17:42:08 +0200 From: Emmanuel Vadot To: Jan Beich Cc: Baptiste Daroussin , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-branches@freebsd.org Subject: Re: git: 77f72c463b90 - 2024Q1 - x11-servers/xwayland-devel: backport recent secfixes Message-Id: <20240404174208.2eaefae74933715eeb31ccbc@bidouilliste.com> In-Reply-To: <8r1t-chhu-wny@FreeBSD.org> References: <202404040955.4349tDrM089062@gitrepo.freebsd.org> <20240404125743.1e52876a69053b726cb456e4@bidouilliste.com> <8r1t-ny0j-wny@FreeBSD.org> <20240404141239.35d54535539b66cd6336ee5b@bidouilliste.com> <7chd-l2ru-wny@FreeBSD.org> <20240404151554.04340786db8562e522f7b1a8@bidouilliste.com> <8r1t-chhu-wny@FreeBSD.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd15.0) List-Id: Commits to the quarterly branches of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-branches@freebsd.org X-BeenThere: dev-commits-ports-branches@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:12876, ipnet:212.83.128.0/19, country:FR] X-Rspamd-Queue-Id: 4V9Qpv0kZqz4SPn On Thu, 04 Apr 2024 16:47:09 +0200 Jan Beich wrote: > Baptiste Daroussin writes: > > > On Thu 04 Apr 15:48, Jan Beich wrote: > > > >> Emmanuel Vadot writes: > >> > >> >> but also introduced a number of regressions that > >> >> don't exist in my port, all of which were documented in my reviews. > >> > > >> > What regressions ? I'm using xwayland for more than a year on my > >> > desktop instead of -devel and haven't seen a problem. > >> > >> Try diff xwayland{,-devel}/Makefile: > >> - Missing XSECURITY (ssh -X vs. ssh -Y; xorg-server parity per bug 221984) > >> - Missing XDMCP (xorg-server parity, maybe used with rootful Xwayland and GUI login managers) > >> - Missing XTEST input emulation (XDG Portal API, required by GNOME, Plasma and maybe rootful Xwayland) > >> - Missing CSD for rootful (mainly for GNOME, optional even if preferred elsewhere) All those options could be added. The main reason that they are not is that x11-server/xwayland isn't used by anyone but me as it requires patching ports to use it. So obviously if they aren't needed for my case no one will stand up and ask for them to be enabled. Another way to view this is that you enabled all those options without consulting anyone, why would you you might ask, it's your port ? Well yes but since this port is forced to be used by everyone enabling option and dependencies should be a concensus between multiple users. For some, (like XSECURITY) you've explained in the commit message so that's good at least. Other like CSD was enabled without anything in the commit message except that this was an update, this is not good. > >> - Broken on DragonFly due to forcing -Dsha1 (already default after I've fixed upstream bug years ago) I don't care about Dragonfly, they are grown ups and can manage their own ports. > >> - Redundant -Dglamor, -Dipv6, -Dxkb_*, libEGL dependency I'll fix those if that's the case. > > > > Those feature are not present as well in non of the Xwayland used in production > > in linux distributions. > > How did you check? I see > * -Dxcsecurity=true (XCSECURITY) in Arch, Fedora, Alpine, Gentoo recipes > * libXdmcp (XDMCP) being used on Fedora and Gentoo > * libei (XTEST) being used on Fedora and Gentoo > * libdecor (CSD) being used on Fedora > > > They are in development, and that is what -devel is for, you can test in > > advance, but this is not needed for production > > That's reasonable if not for the above bugs shrugged off under > "works for me" blanket aka "maintainer's discretion". Lol, very bold of you to say this as all your ports forced on others follow your views. I think that you should fork the ports tree to JanPorts, do your stuff there and for the FreeBSD ports tree please start engaging discussion with the community, you are not alone. Cheers, > > Even linux distros are not including those patches, beside them being more > > mainstream for Wayland than we are. > > Do you mean HiDPI patches? Plasma and Hyprland implemented their own > scaling while the rest rely on buggy workarounds. I'll probably drop > the patches if I can't manage to rebase after upstream rootful HiDPI. > To reduce POLA violation this was postponed until 2024Q2 branches. > > IIRC, one Arch-based distro included HiDPI patches and old version of > Hyprland used to bundle those via Nix flake. -- Emmanuel Vadot