From nobody Thu Apr 04 14:47:09 2024 X-Original-To: dev-commits-ports-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4V9PbR07PYz5H76v; Thu, 4 Apr 2024 14:47:15 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4V9PbQ6ntHz4LDj; Thu, 4 Apr 2024 14:47:14 +0000 (UTC) (envelope-from jbeich@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1712242035; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/6NzHig53ul6nCPsoTfNxtiwqWjMBiJsTAXZLuIYs9E=; b=RsOUC/WoKqjqO2iU18DS4OMdaLuy0TYOcIrD5SsWCUoC8mYhch9kPXmk0xz1H57pqZI7No 5J5VI9zEE+Sk0jbgclvdoRYfjt+KHQ+vfP+5Qcqkk3HIdLck0q4M7jP56AgjpTEwhn0dqq mat8j2kp/UX5cWa7VfS3hxmMmOkJNnvStgR/tVGVgdd9NRWb3aHfJJSn3VgluDERhkYGYX SeZXqBYJGTQkwTxoIMTUB51TJC+9FhVGIs1nGGFiUjttCdfyd+zKSb1H3dIL0tg7JkBDBh B89mdga+MwijkZRuUka6+RscbO9wz4iJra5jacvYDomgpOWIC15ZMKq5XQLZGw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1712242035; a=rsa-sha256; cv=none; b=s81X2XJGxbGt1CDPPY2nwF8ddCvSm2laEj19OcEh80LALUC5bcextueZ/D+bgW5G/+Ay3A ofEVEgcZc0FxExjWj7ZsSWhwR+oK9XRdXNl4XuZq8hEWndIicvdU64TIrcLLzEIhIkLnQZ TknGMhVlzxN0jdd6VOxc+YhxN80qrEh8o7v4pWWYn/EiR+Mq0BSWDub5/QpEIxJKxV+ppM eipB8mMAHoeBXnPbHniOF2nhC9hzMDW/hc/h2MYMddan4V6ZVdZznaSD9TxA53nHOZg9b3 3xDKXCxVF5qkJbEiZdOBZVpraJYVACxemoLkMZ+6HFek2hi+njrJ7aGhSn4Fuw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1712242035; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/6NzHig53ul6nCPsoTfNxtiwqWjMBiJsTAXZLuIYs9E=; b=WE8fIDrSKEXNHujZA91H+mX5KbW3Y1Tu1bCvPxxzfu4nN85azenfk4lswZnZYRz6gVFBLV uGfxpcEQXOm1G0fG1JjI2mcCdWVDNDh4lxufD47oweGqo9JFTb4t1ksH+ts4eAlMMruWft HjljmYZ285t1jHDbUiVkC1whYDDm39b3chdvVxpwcKdM160LUXzaHbinIzDRDuiKdPhY/5 Q6Q02ZJIQ8fqqJnbh4xdVhmbimuSooTR3XNo8WpqJtknsqnutC7xF+ScUv3qSig/oTU59h 5sx3qLa/fJjMIAk6N0+1wQwCj0v1Gu3n5rQ63xzt2oLLeH3lzKW0F9mcl9WqXQ== Received: by freefall.freebsd.org (Postfix, from userid 1354) id A4BAD1A8D1; Thu, 4 Apr 2024 14:47:14 +0000 (UTC) From: Jan Beich To: Baptiste Daroussin Cc: Emmanuel Vadot , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-branches@freebsd.org Subject: Re: git: 77f72c463b90 - 2024Q1 - x11-servers/xwayland-devel: backport recent secfixes In-Reply-To: (Baptiste Daroussin's message of "Thu, 4 Apr 2024 16:08:04 +0200") References: <202404040955.4349tDrM089062@gitrepo.freebsd.org> <20240404125743.1e52876a69053b726cb456e4@bidouilliste.com> <8r1t-ny0j-wny@FreeBSD.org> <20240404141239.35d54535539b66cd6336ee5b@bidouilliste.com> <7chd-l2ru-wny@FreeBSD.org> <20240404151554.04340786db8562e522f7b1a8@bidouilliste.com> Date: Thu, 04 Apr 2024 16:47:09 +0200 Message-ID: <8r1t-chhu-wny@FreeBSD.org> List-Id: Commits to the quarterly branches of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-branches@freebsd.org X-BeenThere: dev-commits-ports-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain Baptiste Daroussin writes: > On Thu 04 Apr 15:48, Jan Beich wrote: > >> Emmanuel Vadot writes: >> >> >> but also introduced a number of regressions that >> >> don't exist in my port, all of which were documented in my reviews. >> > >> > What regressions ? I'm using xwayland for more than a year on my >> > desktop instead of -devel and haven't seen a problem. >> >> Try diff xwayland{,-devel}/Makefile: >> - Missing XSECURITY (ssh -X vs. ssh -Y; xorg-server parity per bug 221984) >> - Missing XDMCP (xorg-server parity, maybe used with rootful Xwayland and GUI login managers) >> - Missing XTEST input emulation (XDG Portal API, required by GNOME, Plasma and maybe rootful Xwayland) >> - Missing CSD for rootful (mainly for GNOME, optional even if preferred elsewhere) >> - Broken on DragonFly due to forcing -Dsha1 (already default after I've fixed upstream bug years ago) >> - Redundant -Dglamor, -Dipv6, -Dxkb_*, libEGL dependency > > Those feature are not present as well in non of the Xwayland used in production > in linux distributions. How did you check? I see * -Dxcsecurity=true (XCSECURITY) in Arch, Fedora, Alpine, Gentoo recipes * libXdmcp (XDMCP) being used on Fedora and Gentoo * libei (XTEST) being used on Fedora and Gentoo * libdecor (CSD) being used on Fedora > They are in development, and that is what -devel is for, you can test in > advance, but this is not needed for production That's reasonable if not for the above bugs shrugged off under "works for me" blanket aka "maintainer's discretion". > Even linux distros are not including those patches, beside them being more > mainstream for Wayland than we are. Do you mean HiDPI patches? Plasma and Hyprland implemented their own scaling while the rest rely on buggy workarounds. I'll probably drop the patches if I can't manage to rebase after upstream rootful HiDPI. To reduce POLA violation this was postponed until 2024Q2 branches. IIRC, one Arch-based distro included HiDPI patches and old version of Hyprland used to bundle those via Nix flake.