From nobody Fri Jan 31 21:42:25 2025 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Yl8W63Gpyz5lSsC; Fri, 31 Jan 2025 21:42:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Yl8W60j6tz3h67; Fri, 31 Jan 2025 21:42:26 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738359746; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Yls6Nv1ReYsUrdTk1CbEPL+QkxKPmu9WnU7jd5tLXjA=; b=oCZOSmAHZg9LvT/hYm74jf9D+nAcPe+wM79PisdVPJa4pB9yWj+5HOg/9QDyl+hJazmWZh Q3Ry83NJ3XtoRRO+AIlhJjOsVGl6nZPuXDnemwkQk8Qb/s/V3TutQwyXuIzMSB+Z+tdFMk zMjW0Gvbrqx/pFigTg9Jbz9dINQrzPhZY6PDEHgT/TKSAseliwjj8eif20wng1Pi1QhFSb qMYM3GthEAILmw7521ALFf5IjJBRfwvkwSM9kOTgZiCn8Pc4NJlp2ZYm+Le0f7vfatagk7 2KEMMXK5NjM6+V9oCNohW17cgZbHAZHOaxQXH/nx5tnPihrs95MU0pDEk2EWBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738359746; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Yls6Nv1ReYsUrdTk1CbEPL+QkxKPmu9WnU7jd5tLXjA=; b=kSbM8ZL9J2fwWyz/gpR0qHOZZyLjFmaEDX2uqpB0AHeruCvGhWCQMmIoN3C+WLcz4yoUJx 5qE1Q7cdzaqLCuxuJ7X6uuMmK2YvsGOCBjYba+gHgXtV/RoBsx3njcRb7FEYOMt7p2EXPZ JWETiXCPoWQVka7S2d9/gxt4n+ZsQQqpKHsp3KKgm23C/DSnxddCHKmjRNWh1BbBSHO2jd WFb4kvBnlO0tgU/E/4FvP9jJvXjE1/LcrlLNdIBItVYIYet/ulKj8459ib5CKuwwZYtZCd ofHRqQr/DXyQnmSeWUyu9cqe3+y2Qa/EceNO1KSNag7oXp/DdoDJzIS54lmpDQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1738359746; a=rsa-sha256; cv=none; b=tDGAT5KKP+eHugzalHbxNWrifL3R4ttkySHT7w1XW0TiOlaD7Lflmbm4vuLnfbctozBr9t eNbNp77MMrtjMgZUbyGnbr0SKeTgkReOqQOIXoz20cH4ltVTZ3opLeqd6saWabuthJ469k CbnnnPb7nqofKAXDuqS4Y2U3G7aeylYh1KtdGbslNyMJMvCeQaZepxXaUCodtnhX3ccx2N 8ArWokqkJM8jSjaM7zfp+NYGDawAnm+xB8jTgLYHP8xckqlJYdlWqPSmHcK/Iwl/JjRD9w bpay+ryckUtgL7QfLr15q0Cd1vIqKWX1Mu6teWZZyFaqq7ly8GQbLM1+nzgLSg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Yl8W605yqzcWG; Fri, 31 Jan 2025 21:42:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 50VLgPNr073605; Fri, 31 Jan 2025 21:42:25 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 50VLgPMH073602; Fri, 31 Jan 2025 21:42:25 GMT (envelope-from git) Date: Fri, 31 Jan 2025 21:42:25 GMT Message-Id: <202501312142.50VLgPMH073602@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org From: Matthias Andree Subject: git: 7c091b1abc84 - main - graphics/rawtherapee: pin GCC version to 13. List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mandree X-Git-Repository: ports X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7c091b1abc84f4246e557aaf7d04d111e4db9b8f Auto-Submitted: auto-generated The branch main has been updated by mandree: URL: https://cgit.FreeBSD.org/ports/commit/?id=7c091b1abc84f4246e557aaf7d04d111e4db9b8f commit 7c091b1abc84f4246e557aaf7d04d111e4db9b8f Author: Matthias Andree AuthorDate: 2025-01-31 21:37:37 +0000 Commit: Matthias Andree CommitDate: 2025-01-31 21:42:11 +0000 graphics/rawtherapee: pin GCC version to 13. Apparently GCC 14 has new libstdc++ bits spill over somewhere, and this would break rawtherapee's build at link time, salvadore@ wrote /usr/local/bin/ld: /tmp/ccgto6pJ.ltrans65.ltrans.o: in function `Spot::~Spot() [clone .cold]': :(.text.unlikely+0x89d): undefined reference to `__cxa_call_terminate' /usr/local/bin/ld: /tmp/ccgto6pJ.ltrans76.ltrans.o: in function `(anonymous namespace)::dfInfo::updateBadPixelList(rtengine::RawImage const*) [clone ._omp_fn.0] [clone .cold]': :(.text.unlikely+0x93): undefined reference to `__cxa_call_terminate' /usr/local/bin/ld: /tmp/ccgto6pJ.ltrans77.ltrans.o: in function `rtengine::ImProcFunctions::RGB_denoise(int, rtengine::Imagefloat*, rtengine::Imagefloat*, rtengine::Imagefloat*, float*, float*, float*, bool, rtengine::procparams::DirPyrDenoiseParams const&, double, rtengine::NoiseCurve const&, rtengine::NoiseCurve const&, float&, float&) [clone ._omp_fn.2] [clone .cold]': :(.text.unlikely+0x1d9): undefined reference to `__cxa_call_terminate' /usr/local/bin/ld: /tmp/ccgto6pJ.ltrans81.ltrans.o: in function `rtengine::init(rtengine::Settings const*, Glib::ustring const&, Glib::ustring const&, bool) [clone ._omp_fn.0] [clone .lto_priv.0] [clone .cold]': :(.text.unlikely+0x4be): undefined reference to `__cxa_call_terminate' /usr/local/bin/ld: /tmp/ccgto6pJ.ltrans84.ltrans.o: in function `rtengine::ImProcFunctions::ciecamloc_02float(rtengine::local_params&, int, rtengine::LabImage*, int, int, int, int, LUT const&, bool, LUT const&, bool, LUT const&, bool, LUT const&, bool, LUT const&, bool, rtengine::LocCHCurve const&, rtengine::LocHHCurve const&, rtengine::LocLHCurve const&, bool, bool, bool, rtengine::LocwavCurve const&, bool, float&, float&, float&) [clone ._omp_fn.11] [clone .lto_priv.0] [clone .cold]': :(.text.unlikely+0x5f): undefined reference to `__cxa_call_terminate' And this seems to be https://gcc.gnu.org/pipermail/libstdc++/2023-May/056011.html related to C++ standards compliance - however __cxa_call_terminate specifically is a libstdc++ export function, unavailable in libc++. Rawtherapee needs to link against libc++ because otherwise all C++ libraries it imports would also have to be compiled against libstdc++. Reported by: Lorenzo salvadore@ PR: 284487 --- graphics/rawtherapee/Makefile | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/graphics/rawtherapee/Makefile b/graphics/rawtherapee/Makefile index 58d98dd32baa..f9119609bf02 100644 --- a/graphics/rawtherapee/Makefile +++ b/graphics/rawtherapee/Makefile @@ -113,7 +113,14 @@ OPENMP_LDFLAGS= -lm -lomp # up to twice as fast as clang-16.0 compiled code. # So we shall stick to a modern GCC for now. # -USE_GCC= yes # default +# However, libstdc++14 appears to have some parts spill over into +# GCC14, and that breaks at link time with a linker error +# `undefined reference to `__cxa_call_terminate' +# that stems from our using the FreeBSD base system libc++ +# because otherwise all other C++ libraries would have to +# be compiled with libstdc++ instead. +# See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=284487 +USE_GCC= 13 # default as of 2025-01-31 .if (${OPSYS} == FreeBSD) && (${OSVERSION} >= 1500000) # don't waste everybody's time with Tier-2 and moving targets.